Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4768221rdb; Tue, 12 Dec 2023 08:48:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHd5cnd0BUoy2pxrOQBk/pGbJqRjDYm14o3VdIEXdWJzR/jtZW1LGgs6oqsMdUsJTQN6e+O X-Received: by 2002:a17:902:6f02:b0:1d1:cbbf:8ebb with SMTP id w2-20020a1709026f0200b001d1cbbf8ebbmr3117789plk.40.1702399695086; Tue, 12 Dec 2023 08:48:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702399695; cv=none; d=google.com; s=arc-20160816; b=WDWe5OBBsgHLcXil3J0ysF3/L9HBchHu0oIl5uwfepjb6FY4HO5u3LA4r+MEN/aJW7 CqMY+KoeTsG87CAH3vqMlJASwPIpwKxdWi3UC+wwtNMCt/RMFlCjsCqm+MsfvvEuWc6D oAmTjgrhm3279opo78yZp8sgGZwOTakEjul6/YcLoA5xOZVuzSRfffSIbeiR4noIF03a VGEy61HodKeHbjNySsG2uEirDjuItFSVlgJGbfd4v3uYbc4qPR7nK4wbdK2QML3X89Kb 1D7Mgt4uYVHwIgLEAsLl5CSx5hnTiXs79lFFRPzV9rhgYWTHbaMqQeaVSbI1QY48Npja bhCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XnnUKhdaqaqa/m3Gi7NBJFJO7ypDtmehGpRuMRLVJaw=; fh=UczyO0u/JBlykqv0Cuqv3zDCKVYdjzO6fyj+OMDjssE=; b=XRqfnidPfUYkXuptHPaGpyHxZazHbEheYnFuHueNtwrdYKs0ongeypwKM1zsbo9fuD oma6L7/ryBdpUrU2zRgLE8Z139zg2D1HKOstHrCrxen5deg43vouY3ExBuhMLIoig6D1 s+CCdkIDVai71s87ffWhJko2F8Z4AQrqGebKzwaFdARDB+8KGQ82QqPUsTN7tkot45aN hXIYXQWTkKqw+4lv7X7Rfk1FNSVSVlsA2qxjkC+m3eajIHHS9SpiUjgVdL6REjCZ3HHW BPXB98pLJg5K9FoVV/VSHSHpp0A5MSa+POJuaU9/61EqIO4nzGfivUbbwCVVX6rcDgWo wZQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eFYe3wPM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id u9-20020a170902e80900b001d091c3ab04si8331150plg.355.2023.12.12.08.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 08:48:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eFYe3wPM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id A7FF78026C3A; Tue, 12 Dec 2023 08:48:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232642AbjLLQsA (ORCPT + 99 others); Tue, 12 Dec 2023 11:48:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232460AbjLLQr6 (ORCPT ); Tue, 12 Dec 2023 11:47:58 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBEDAB7 for ; Tue, 12 Dec 2023 08:48:04 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A676C433C7; Tue, 12 Dec 2023 16:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702399684; bh=aNHGA0+OP2YXIV3jh4hVPbn2PRXP966VFGwAlUTm6OE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eFYe3wPMn3Lg3ndIIfcU5/QNd4Hro7G6QeuPLJluyf9mGilUtpinEgnsnB+fDHv+D 7l/2bca7V3e5KvIzg/hfVHk4ZSqfZDNDnzEgF0BV6B3DdcYxGNXRL/CPyQtuNsJddh MzflMEUzxV1Hjt+tk6kWy4IoUjd+3xgAw3/mAtA5YasDuIIQmi77Vaho3sgMTkKyjL 4Qh97xnK4IZH/FOZVFrwn4RClguppq0gSuG0kXGhcs/yzsNahmIM9tHOon1OJc6nbu MA7ep0eoK2Vz25gl0AQNtSgye3/5yRtw8vlwpzIGxAnCx61hHaVUF/92fjbLPQuWeD K+wAFGSyStZLA== Date: Tue, 12 Dec 2023 16:47:59 +0000 From: Conor Dooley To: Ji Sheng Teoh Cc: Xingyu Wu , Samin Guo , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ley Foon Tan , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Message-ID: <20231212-shout-bazooka-714aeda42ec1@spud> References: <20231212031731.2498584-1-jisheng.teoh@starfivetech.com> <20231212031731.2498584-2-jisheng.teoh@starfivetech.com> <20231212-reverb-daisy-4574734ae84f@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lo0V+T4OZHJunVRD" Content-Disposition: inline In-Reply-To: <20231212-reverb-daisy-4574734ae84f@spud> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Dec 2023 08:48:12 -0800 (PST) --lo0V+T4OZHJunVRD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote: > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote: > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100 > > watchdog. > > Since JH8100 watchdog only has 1 reset signal, update binding > > document to support one reset for "starfive,jh8100-wdt" compatible. > >=20 > > Signed-off-by: Ley Foon Tan > > Signed-off-by: Ji Sheng Teoh > > --- > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100= -wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.= yaml > > index 68f3f6fd08a6..02572b16ac08 100644 > > --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.ya= ml > > +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.ya= ml > > @@ -27,6 +27,7 @@ properties: > > enum: > > - starfive,jh7100-wdt > > - starfive,jh7110-wdt > > + - starfive,jh8100-wdt > > =20 > > reg: > > maxItems: 1 > > @@ -45,6 +46,7 @@ properties: > > - const: core > > =20 > > resets: > > + minItems: 1 > > items: > > - description: APB reset > > - description: Core reset >=20 > This relaxes the constraints for the existing devices, please add per > compatible constraints to avoid doing so. Also, you do not appear to have implemented the request from Krzysztof to express compatibility with the jh7110. --lo0V+T4OZHJunVRD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXiOvwAKCRB4tDGHoIJi 0herAQCODs736+Qe5j/hkbfNeI7xdVcGRKkurOrjX+4lQhNvpAEA6MN/UHKEuQ7A 3lki7S8WsCrF5mWZkZpNa9mg7laccgM= =4sul -----END PGP SIGNATURE----- --lo0V+T4OZHJunVRD--