Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231212-removeasmgeneric-v2-1-a0e6d7df34a7@google.com>
In-Reply-To: <20231212-removeasmgeneric-v2-1-a0e6d7df34a7@google.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Tue, 12 Dec 2023 08:56:05 -0800
Message-ID: <CAKwvOdnTH+SgiLDkq4KmjVifF-bkxKfBNxE2o+XHjuRa6ZCSRA@mail.gmail.com>
Subject: Re: [PATCH v2] riscv: remove unused header
To:     tanzirh@google.com
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        Nick Desaulniers <nnn@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Dec 11, 2023 at 4:20=E2=80=AFPM <tanzirh@google.com> wrote:
>
> arch/riscv/kernel/sys_riscv.c builds without using anything
> from asm-generic/mman-common.h. There seems to be no reason
> to include this file.
>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>

Thanks for the patch!

Fixes: 9e2e6042a7ec ("riscv: Allow PROT_WRITE-only mmap()")
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>
> ---

You're still getting funky extra `---`; let's take a look later at how
you're using `b4` together offline.  It's not a problem for me to
apply the patch, but something still isn't quite right. (Do not send a
v3 over this)

> Changes in v2:
> - Changed name to riscv: remove unused header
> - Link to v1: https://lore.kernel.org/r/20231211-removeasmgeneric-v1-1-a0=
274e802789@google.com
> ---
>  arch/riscv/kernel/sys_riscv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.=
c
> index a2ca5b7756a5..ebcaf386ea62 100644
> --- a/arch/riscv/kernel/sys_riscv.c
> +++ b/arch/riscv/kernel/sys_riscv.c
> @@ -14,7 +14,6 @@
>  #include <asm/switch_to.h>
>  #include <asm/uaccess.h>
>  #include <asm/unistd.h>
> -#include <asm-generic/mman-common.h>
>  #include <vdso/vsyscall.h>
>
>  static long riscv_sys_mmap(unsigned long addr, unsigned long len,
>
> ---
> base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
> change-id: 20231211-removeasmgeneric-f6be13a42b6b
>
> Best regards,
> --
> Tanzir Hasan <tanzirh@google.com>
>


--=20
Thanks,
~Nick Desaulniers