Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4792141rdb; Tue, 12 Dec 2023 09:23:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHqCPDaRZZctjOk9d4elnss33feyqr5lakLQFjSx1LDHiVzg21VwW+HDOT4aefH9RnCfH+j X-Received: by 2002:a05:6a20:918f:b0:191:511:a989 with SMTP id v15-20020a056a20918f00b001910511a989mr5406418pzd.39.1702401790795; Tue, 12 Dec 2023 09:23:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702401790; cv=none; d=google.com; s=arc-20160816; b=keRn7fLRcDgY1yVS5K+jmJBrC8jq5BMuPpVS3K5gBhHZeFvywoT9LmKa4usPkxQEo0 uNM4v2mClgjZ84irkmYPy2M52bGnq+U3Sr5Z1e8xo+A+TB66wuR2tfce828R7UUrVLWs /XHHu4VkMoJPFjOJLet19FYQ2bcRomEJnzv64nTi1iYTUzIxZq8MCSrURwog7zhvYVKa pI3SnQWYJX8uS6caKxekdyU+1haFYm/V521767td6ip58TLSQxzMwNDXc2uc0kjGjQiv fVBALkHrITJNciXjSZW3PYMco58iIKQLw4SadURN/bxXHPmvt0UAffbucIcl+3FXJEI5 6m/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Noi9D9Fl5VC63VxFSve6ZHsIOWbbJIGn9bSJCZ+R9+U=; fh=8Y6z0xYuRppV6exiWXqWY/DR9o1+HpZP+OhoEH7KTpo=; b=Ny4RJZ+9ZzNwfpoAvXBl61otgINQvYG92dEYO/7VNz8vDxGvr6hj5C8j4rwVtajnbP 6tMQ1aqs1JNXddjo87ba/50rfgy3ewkSOx4Eapv0Wa12rD4iz5sQTLcRbnCLqkvJ3l7+ kkQnjIVior3bJIfNbmHY421qcuZLHko3IgdWtLvddT+ieS9zIsU2qPrPaSgB+E7Y2Sai fV44z6vMM/CdjsZ9HnNZyPTk7ffIvlK+fX5nifXVPZZfgTiZiHgQdn3ilBlY2ibQtDcc hWrTnnWn7+lNmzbgqSti0Xrk+5vs1xqiZc/xOPWifhVDgLOKaLxDtdyDNL6Cw4FXCWrB fGDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id y66-20020a636445000000b005bdf5961d87si3880465pgb.266.2023.12.12.09.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 09:23:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 5859780A850F; Tue, 12 Dec 2023 09:23:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235106AbjLLRWx (ORCPT + 99 others); Tue, 12 Dec 2023 12:22:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235084AbjLLRWv (ORCPT ); Tue, 12 Dec 2023 12:22:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A3FBEA for ; Tue, 12 Dec 2023 09:22:58 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D12C433C7; Tue, 12 Dec 2023 17:22:56 +0000 (UTC) From: Catalin Marinas To: will@kernel.org, Robin Murphy Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jeremy.linton@arm.com, ilkka@os.amperecomputing.com, renyu.zj@linux.alibaba.com Subject: Re: [PATCH] perf/arm-cmn: Fail DTC counter allocation correctly Date: Tue, 12 Dec 2023 17:22:54 +0000 Message-Id: <170240171501.947884.15604728153384166017.b4-ty@arm.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 12 Dec 2023 09:23:08 -0800 (PST) On Mon, 11 Dec 2023 19:27:28 +0000, Robin Murphy wrote: > Calling arm_cmn_event_clear() before all DTC indices are allocated is > wrong, and can lead to arm_cmn_event_add() erroneously clearing live > counters from full DTCs where allocation fails. Since the DTC counters > are only updated by arm_cmn_init_counter() after all DTC and DTM > allocations succeed, nothing actually needs cleaning up in this case > anyway, and it should just return directly as it did before. > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] perf/arm-cmn: Fail DTC counter allocation correctly https://git.kernel.org/arm64/c/1892fe103c3a -- Catalin