Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20231212141200.62579-1-eichest@gmail.com> <20231212170704.74565969@device.home>
In-Reply-To: <20231212170704.74565969@device.home>
From:   Marcin Wojtas <mw@semihalf.com>
Date:   Tue, 12 Dec 2023 18:39:14 +0100
Message-ID: <CAPv3WKfY2ATjPPV=yFQNUE=dV4wpyV3d0cQNBGOuSPb+id=mvw@mail.gmail.com>
Subject: Re: [PATCH net-next v2] net: mvpp2: add support for mii
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     Stefan Eichenberger <eichest@gmail.com>, linux@armlinux.org.uk,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

wt., 12 gru 2023 o 17:07 Maxime Chevallier
<maxime.chevallier@bootlin.com> napisa=C5=82(a):
>
> Hi Stefan,
>
> On Tue, 12 Dec 2023 15:12:00 +0100
> Stefan Eichenberger <eichest@gmail.com> wrote:
>
> > Currently, mvpp2 only supports RGMII. This commit adds support for MII.
> > The description in Marvell's functional specification seems to be wrong=
.
> > To enable MII, we need to set GENCONF_CTRL0_PORT3_RGMII, while for RGMI=
I
> > we need to clear it. This is also how U-Boot handles it.
> >
> > Signed-off-by: Stefan Eichenberger <eichest@gmail.com>
>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

LGTM, as well.
Reviewed-by: Marcin Wojtas <mw@semihalf.com>

Best regards,
Marcin