Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4809372rdb; Tue, 12 Dec 2023 09:51:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6s2mZwZdT8fxdTuFivu5DYZU9kaLPmx7efGbhqG68beFt55GV3Ym3kZbO4rmfdFsaABAh X-Received: by 2002:a17:902:e551:b0:1d0:baf6:65bf with SMTP id n17-20020a170902e55100b001d0baf665bfmr3384357plf.50.1702403505166; Tue, 12 Dec 2023 09:51:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702403505; cv=none; d=google.com; s=arc-20160816; b=i5XLKWJXRzILc0P41XspyzY5hmMg0LeysWy2lcQNKvnNUGUdo/+08w4P4VeTMhFU3Z d6hvnv/YS8m7yyZq/XrJaN+mq73EE9DVLNp/DaoZinedVKPvUVpqT3+2UVq1G4xzgKeU OcawCAviSG9uUR9VWm7OVDJwagfEtT+DxHN8wXe+pHMjsKwZpqLciylvu8A0tzgU29Em 424CIFnqitK7xT/n8ltgrORe5vSV4h6hATyl7VYL3svKwbx5g2yICc5CtftdOxjFgb4q ykCHyjc+HCtarrRDeKS60r3HBZL3z9iLn3l3llCUKSAzkJ67WISsEyrh3BMP5+Mvg6OX N8sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-filter; bh=yGJlOf/j2McGPzvljEr6MMisBrMZAZjoccSqTDW4uRI=; fh=YtSViko0S4mzjRL+vIBcPZ6MScNClfhalnj7Ll4mpO4=; b=ML4HCSz8g2DA7SLtovSl4bdEq9/4fLEnKtAo96ggOYrvTtK1/Ci0+q9bZY4gHrN+lF 05leS5ZxBMX7G04T9JU5nGyK6KKkob9ZjLj57YmTELwWCVQKzWD0zMGtr8AshiJgKBCC WYPRYf9GjCfcw9P891thO+tfSWKR9r0NeNKjNc3Whdqkk8+N6dXJ8PU6DfBO5HpPfvIZ mbC8v1LFKY+p60SzaEf9ActeVpVm8E7G/IgwrKBOdiFQAzcGCtANAhSYnIjGixWHHR9P YAPA2ernEtRNfzUjWuguDWfWNUH1cS/TANrhXrmGyXnowk3ZPV6cNSHOmC7JVEJ7msNp aOFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=HwT2nbkZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id w15-20020a170902a70f00b001cfabbeeda5si3981380plq.291.2023.12.12.09.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 09:51:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=HwT2nbkZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 206478053CD1; Tue, 12 Dec 2023 09:51:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377011AbjLLRvZ (ORCPT + 99 others); Tue, 12 Dec 2023 12:51:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232358AbjLLRvX (ORCPT ); Tue, 12 Dec 2023 12:51:23 -0500 Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFF7C83; Tue, 12 Dec 2023 09:51:28 -0800 (PST) Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 7D5FD100049; Tue, 12 Dec 2023 20:51:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 7D5FD100049 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1702403487; bh=yGJlOf/j2McGPzvljEr6MMisBrMZAZjoccSqTDW4uRI=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type:From; b=HwT2nbkZMMUfG+DcLYYdXbAFOzWmYbAiTgiStOJHzJon4H0V6FpYVQYy8DzMUF4eg ssqLixs3C0TJOodMS3BPA6x3wqkStgi2uZNs8OyqBGmaXxqSLHoWFTla0y1X8WtBFS hGQnq4aNseFR1RFquhM9okKSTRlU1jxD+FXCB+VK8MpESfiUvRWtxArrbQ8wqIcG/M Mo8n4oohTiczMTowa7YprzLYFkwAVkL9VyHqUWmxMpq9GLTTLopJN3voste/JtYgOW UzmH31wgPN/WU09FZLCfC1+VctVeqkIys+9HSkKRdV0HG+cJC75AVVFDsljI/PoSZI fXwZDKvTn0ZGA== Received: from smtp.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Tue, 12 Dec 2023 20:51:27 +0300 (MSK) Received: from [192.168.0.106] (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 12 Dec 2023 20:51:26 +0300 Message-ID: <7b362aef-6774-0e08-81e9-0a6f7f616290@salutedevices.com> Date: Tue, 12 Dec 2023 20:43:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH net-next v8 0/4] send credit update during setting SO_RCVLOWAT Content-Language: en-US To: "Michael S. Tsirkin" CC: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jason Wang , Bobby Eshleman , , , , , , References: <20231211211658.2904268-1-avkrasnov@salutedevices.com> <20231212105423-mutt-send-email-mst@kernel.org> <20231212111131-mutt-send-email-mst@kernel.org> From: Arseniy Krasnov In-Reply-To: <20231212111131-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 182068 [Dec 12 2023] X-KSMG-AntiSpam-Version: 6.1.0.3 X-KSMG-AntiSpam-Envelope-From: avkrasnov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a, {Tracking_uf_ne_domains}, {Tracking_from_domain_doesnt_match_to}, smtp.sberdevices.ru:5.0.1,7.1.1;lore.kernel.org:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;salutedevices.com:7.1.1;100.64.160.123:7.1.2;git.kernel.org:7.1.1;127.0.0.199:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2023/12/12 17:04:00 X-KSMG-LinksScanning: Clean, bases: 2023/12/12 17:03:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/12/12 12:50:00 #22667219 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 12 Dec 2023 09:51:42 -0800 (PST) On 12.12.2023 19:12, Michael S. Tsirkin wrote: > On Tue, Dec 12, 2023 at 06:59:03PM +0300, Arseniy Krasnov wrote: >> >> >> On 12.12.2023 18:54, Michael S. Tsirkin wrote: >>> On Tue, Dec 12, 2023 at 12:16:54AM +0300, Arseniy Krasnov wrote: >>>> Hello, >>>> >>>> DESCRIPTION >>>> >>>> This patchset fixes old problem with hungup of both rx/tx sides and adds >>>> test for it. This happens due to non-default SO_RCVLOWAT value and >>>> deferred credit update in virtio/vsock. Link to previous old patchset: >>>> https://lore.kernel.org/netdev/39b2e9fd-601b-189d-39a9-914e5574524c@sberdevices.ru/ >>> >>> >>> Patchset: >>> >>> Acked-by: Michael S. Tsirkin >> >> Thanks! >> >>> >>> >>> But I worry whether we actually need 3/8 in net not in net-next. >> >> Because of "Fixes" tag ? I think this problem is not critical and reproducible >> only in special cases, but i'm not familiar with netdev process so good, so I don't >> have strong opinion. I guess @Stefano knows better. >> >> Thanks, Arseniy > > Fixes means "if you have that other commit then you need this commit > too". I think as a minimum you need to rearrange patches to make the > fix go in first. We don't want a regression followed by a fix. I see, ok, @Stefano WDYT? I think rearrange doesn't break anything, because this patch fixes problem that is not related with the new patches from this patchset. Thanks, Arseniy > >>> >>> Thanks! >>> >>>> Here is what happens step by step: >>>> >>>> TEST >>>> >>>> INITIAL CONDITIONS >>>> >>>> 1) Vsock buffer size is 128KB. >>>> 2) Maximum packet size is also 64KB as defined in header (yes it is >>>> hardcoded, just to remind about that value). >>>> 3) SO_RCVLOWAT is default, e.g. 1 byte. >>>> >>>> >>>> STEPS >>>> >>>> SENDER RECEIVER >>>> 1) sends 128KB + 1 byte in a >>>> single buffer. 128KB will >>>> be sent, but for 1 byte >>>> sender will wait for free >>>> space at peer. Sender goes >>>> to sleep. >>>> >>>> >>>> 2) reads 64KB, credit update not sent >>>> 3) sets SO_RCVLOWAT to 64KB + 1 >>>> 4) poll() -> wait forever, there is >>>> only 64KB available to read. >>>> >>>> So in step 4) receiver also goes to sleep, waiting for enough data or >>>> connection shutdown message from the sender. Idea to fix it is that rx >>>> kicks tx side to continue transmission (and may be close connection) >>>> when rx changes number of bytes to be woken up (e.g. SO_RCVLOWAT) and >>>> this value is bigger than number of available bytes to read. >>>> >>>> I've added small test for this, but not sure as it uses hardcoded value >>>> for maximum packet length, this value is defined in kernel header and >>>> used to control deferred credit update. And as this is not available to >>>> userspace, I can't control test parameters correctly (if one day this >>>> define will be changed - test may become useless). >>>> >>>> Head for this patchset is: >>>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=021b0c952f226236f2edf89c737efb9a28d1422d >>>> >>>> Link to v1: >>>> https://lore.kernel.org/netdev/20231108072004.1045669-1-avkrasnov@salutedevices.com/ >>>> Link to v2: >>>> https://lore.kernel.org/netdev/20231119204922.2251912-1-avkrasnov@salutedevices.com/ >>>> Link to v3: >>>> https://lore.kernel.org/netdev/20231122180510.2297075-1-avkrasnov@salutedevices.com/ >>>> Link to v4: >>>> https://lore.kernel.org/netdev/20231129212519.2938875-1-avkrasnov@salutedevices.com/ >>>> Link to v5: >>>> https://lore.kernel.org/netdev/20231130130840.253733-1-avkrasnov@salutedevices.com/ >>>> Link to v6: >>>> https://lore.kernel.org/netdev/20231205064806.2851305-1-avkrasnov@salutedevices.com/ >>>> Link to v7: >>>> https://lore.kernel.org/netdev/20231206211849.2707151-1-avkrasnov@salutedevices.com/ >>>> >>>> Changelog: >>>> v1 -> v2: >>>> * Patchset rebased and tested on new HEAD of net-next (see hash above). >>>> * New patch is added as 0001 - it removes return from SO_RCVLOWAT set >>>> callback in 'af_vsock.c' when transport callback is set - with that >>>> we can set 'sk_rcvlowat' only once in 'af_vsock.c' and in future do >>>> not copy-paste it to every transport. It was discussed in v1. >>>> * See per-patch changelog after ---. >>>> v2 -> v3: >>>> * See changelog after --- in 0003 only (0001 and 0002 still same). >>>> v3 -> v4: >>>> * Patchset rebased and tested on new HEAD of net-next (see hash above). >>>> * See per-patch changelog after ---. >>>> v4 -> v5: >>>> * Change patchset tag 'RFC' -> 'net-next'. >>>> * See per-patch changelog after ---. >>>> v5 -> v6: >>>> * New patch 0003 which sends credit update during reading bytes from >>>> socket. >>>> * See per-patch changelog after ---. >>>> v6 -> v7: >>>> * Patchset rebased and tested on new HEAD of net-next (see hash above). >>>> * See per-patch changelog after ---. >>>> v7 -> v8: >>>> * See per-patch changelog after ---. >>>> >>>> Arseniy Krasnov (4): >>>> vsock: update SO_RCVLOWAT setting callback >>>> virtio/vsock: send credit update during setting SO_RCVLOWAT >>>> virtio/vsock: fix logic which reduces credit update messages >>>> vsock/test: two tests to check credit update logic >>>> >>>> drivers/vhost/vsock.c | 1 + >>>> include/linux/virtio_vsock.h | 1 + >>>> include/net/af_vsock.h | 2 +- >>>> net/vmw_vsock/af_vsock.c | 9 +- >>>> net/vmw_vsock/hyperv_transport.c | 4 +- >>>> net/vmw_vsock/virtio_transport.c | 1 + >>>> net/vmw_vsock/virtio_transport_common.c | 43 +++++- >>>> net/vmw_vsock/vsock_loopback.c | 1 + >>>> tools/testing/vsock/vsock_test.c | 175 ++++++++++++++++++++++++ >>>> 9 files changed, 229 insertions(+), 8 deletions(-) >>>> >>>> -- >>>> 2.25.1 >>> >