Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4813722rdb; Tue, 12 Dec 2023 09:59:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHyXhk7dHHbJ9HjfHxYLWkmrM3JGFlgmJe3rn3pKMo1fvlQVZuhaOhyjvWT/5VnQeTnprxT X-Received: by 2002:a05:6a00:1d26:b0:6ce:696c:8341 with SMTP id a38-20020a056a001d2600b006ce696c8341mr3399467pfx.54.1702403989597; Tue, 12 Dec 2023 09:59:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702403989; cv=none; d=google.com; s=arc-20160816; b=oMOL5hqmYDqOQIrVNpl6Wk79GvVFgGw5SvRWBP2Fxf6KYdZo+pDegTUxNPFCX/NlQM Z60ELA0aGtZDgIHBka8i4Hr1QNTJ6rVGcKCPIn4hP/szHSOnfiyk3fkMs8Xtb8yR+e4C e5FAWnKuWSEPtWxu+U+Y3TbBcVONVNd/8PZ+ZNhVmzQwoWUSfdZH7JH+RevL+5LXJZKI 8gw/EPwH86bAZ8tWi6tDS5yucVDz0/thddCiAOOp0O/k5/dRZaS3AHTocsf4ukIzkk3k pYC7rVrAwP5s3SQlvTrvgSbsxX35R3khcLuy+jD4YgspJTJ27yKLBG9qAjPMp3EXLroR ClDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Qh2X6zRxFaZD3vhSzBqmOfC8+HyBhkzST6QMCYRhoTQ=; fh=ER+ZD7xuYICqLWPkD8syGBGlSQ7DL757QRdXc0m4QuY=; b=NxXYageehvOap76esT1Ky+eXopNcLki/vG+hmL5bTMgGlbEsctNK0D301S4oACKCgx HGxQyE2uHi7PxCsFS+lzrevCqIt5eraPKeiwT9XC0kghG+OWqzAgWO8+07utgszbZm4O XZiVfnT/x9RUXCywNrQrc1OATriPHEhtdiWTmwm5A+GLsiaBy9jfE5NFMFqJFtxspZAS NiB/OlL6I6awMdfEE4U1Um1EMjuzrEz9KcwGuYjHMLAISprvRNfQp7a42DNztOoodh22 3X02F8Zai01QSzFXBVzgRDQyUgnWU2FJQeWL8lMfSBEsVZocGTmuTqFNLD1G/DLzwAIn OvAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="om/wqvN1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id eb19-20020a056a004c9300b006ce02981808si8000694pfb.199.2023.12.12.09.59.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 09:59:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="om/wqvN1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 5810780A1E0A; Tue, 12 Dec 2023 09:59:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377037AbjLLR7f (ORCPT + 99 others); Tue, 12 Dec 2023 12:59:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230181AbjLLR7e (ORCPT ); Tue, 12 Dec 2023 12:59:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1642C94 for ; Tue, 12 Dec 2023 09:59:41 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73489C433C7; Tue, 12 Dec 2023 17:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702403980; bh=tz+1sOWttKcl3a8KlUuaREBKUL4WYsTUmoJCIWI8J2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=om/wqvN1PT76jVx/CfKav0nLkaf4CK4kqAC9r5+o/YFTFqzJLHV9AFhmuzmz4coDn fWzG57/kj9GpAm+RcsJS48A/3bH+zV98QatK9AWvebFMDP44ueRKvJkj4zBo87pv7B fFrEaCF70kW33lgPk7dL0BxUfuaG7uAvH/PK3mXtiUrg55cUSjJw2r6nV1ZHyyJ7kL zeLYMo0lW/ZaUtXclPRnko4YHMrqeIMR/n83FFlKHKDTycU9LDKXmnDSeXz+AcXTT0 Zelv8DCmuwKtE2ScA3Ogd/zM/KTKdvJ2jXprmgB2wLgTJ83ABdtQ7TNhrrvgqJ/l+I vnPkYllRSx33Q== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 945A9403EF; Tue, 12 Dec 2023 14:59:37 -0300 (-03) Date: Tue, 12 Dec 2023 14:59:37 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers , Adrian Hunter Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , John Garry , Will Deacon , Thomas Gleixner , Darren Hart , Davidlohr Bueso , =?iso-8859-1?Q?Andr=E9?= Almeida , Kan Liang , K Prateek Nayak , Sean Christopherson , Paolo Bonzini , Kajol Jain , Athira Rajeev , Andrew Jones , Alexandre Ghiti , Atish Patra , "Steinar H. Gunderson" , Yang Jihong , Yang Li , Changbin Du , Sandipan Das , Ravi Bangoria , Paran Lee , Nick Desaulniers , Huacai Chen , Yanteng Si , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [PATCH v1 00/14] Clean up libperf cpumap's empty function Message-ID: References: <20231129060211.1890454-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231129060211.1890454-1-irogers@google.com> X-Url: http://acmel.wordpress.com X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Dec 2023 09:59:47 -0800 (PST) Em Tue, Nov 28, 2023 at 10:01:57PM -0800, Ian Rogers escreveu: > Rename and clean up the use of libperf CPU map functions particularly > focussing on perf_cpu_map__empty that may return true for maps > containing CPUs but also with an "any CPU"/dummy value. > > perf_cpu_map__nr is also troubling in that iterating an empty CPU map > will yield the "any CPU"/dummy value. Reduce the appearance of some > calls to this by using the perf_cpu_map__for_each_cpu macro. > > Ian Rogers (14): > libperf cpumap: Rename perf_cpu_map__dummy_new > libperf cpumap: Rename and prefer sysfs for perf_cpu_map__default_new > libperf cpumap: Rename perf_cpu_map__empty > libperf cpumap: Replace usage of perf_cpu_map__new(NULL) > libperf cpumap: Add for_each_cpu that skips the "any CPU" case Applied 1-6, with James Reviewed-by tags, would be good to have Adrian check the PT and BTS parts, testing the end result if he things its all ok. - Arnaldo