Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
MIME-Version: 1.0
References: <20231212070547.612536-1-namhyung@kernel.org> <20231212070547.612536-2-namhyung@kernel.org>
In-Reply-To: <20231212070547.612536-2-namhyung@kernel.org>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 12 Dec 2023 10:07:59 -0800
Message-ID: <CAP-5=fUsVd-ZAL0yBeKpQ5RvQVWs+ujXZj679sYQAwPLmzrCXQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] perf genelf: Set ELF program header addresses properly
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org,
        Milian Wolff <milian.wolff@kdab.com>,
        Pablo Galindo <pablogsal@gmail.com>,
        Fangrui Song <maskray@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Dec 11, 2023 at 11:05=E2=80=AFPM Namhyung Kim <namhyung@kernel.org>=
 wrote:
>
> The text section starts after the ELF headers so PHDR.p_vaddr and
> others should have the correct addresses.
>
> Fixes: babd04386b1d ("perf jit: Include program header in ELF files")
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/util/genelf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
> index fefc72066c4e..ac17a3cb59dc 100644
> --- a/tools/perf/util/genelf.c
> +++ b/tools/perf/util/genelf.c
> @@ -293,9 +293,9 @@ jit_write_elf(int fd, uint64_t load_addr, const char =
*sym,
>          */
>         phdr =3D elf_newphdr(e, 1);
>         phdr[0].p_type =3D PT_LOAD;
> -       phdr[0].p_offset =3D 0;
> -       phdr[0].p_vaddr =3D 0;
> -       phdr[0].p_paddr =3D 0;
> +       phdr[0].p_offset =3D GEN_ELF_TEXT_OFFSET;
> +       phdr[0].p_vaddr =3D GEN_ELF_TEXT_OFFSET;
> +       phdr[0].p_paddr =3D GEN_ELF_TEXT_OFFSET;
>         phdr[0].p_filesz =3D csize;
>         phdr[0].p_memsz =3D csize;
>         phdr[0].p_flags =3D PF_X | PF_R;
> --
> 2.43.0.472.g3155946c3a-goog
>