Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4831884rdb; Tue, 12 Dec 2023 10:23:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRbKkF6FPjJML5KH2m3Bi3NCVugfywyGR4m1Uq4qCWKXEjU+QAnexJx237MgJGbInYEWGi X-Received: by 2002:a05:6a20:8423:b0:18f:f0ce:db81 with SMTP id c35-20020a056a20842300b0018ff0cedb81mr4277736pzd.77.1702405397479; Tue, 12 Dec 2023 10:23:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702405397; cv=none; d=google.com; s=arc-20160816; b=doLd/QHb7uGpW2zcYMSW2qROnCEArJmX+SPZKDXS2YJ0u5wzman6tbprYvH1UgcN5K RkViSeIpkL5ekbqKYp2qF/Sd18Mmj/xhc0O39pEhJn582nP4sHLIvoxgqsTftiQfHBp9 wCKr5XsiMMK2nP0D37ivJGD/uUtGd5of2TsBn5quQsw3FZ8iESMWtR/M5qKp4pxnulmr c0/JnrsYECLM/xsIXTNeopqQGSbeWevmZcdFOBDkZVCwWpCqaTZE+uAIa5hxag/Kodaj h1rBFkxA00RJNEfoN2Ch6lQJgGDK6IKQ0Bqb1YQlFAzYv1eZ5rEs/xcAIt9uaq1BiQ4p pkdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=FgWfXUf7JBwW1mgUeCk9UfFoo8bqlPOEEghFgzZFT2E=; fh=dwvx6jsB3r0Fb1ZWtzIEqIwUlmwdQCBVM9oiWkdmcUo=; b=pUykoMHo+iXHqh3L1Cez1Lp5xMoE9aSKcHKXN8THlDAxkwgNv74vTTOR2hQkqL9sJ+ NWdPw47wTC/LgX+pAfU1jGsKEnZuHQMSQXompWAQ/QtGxN65spjdtEkmU+lGsnPaUMBM mH/fgbTm/9jfOY8TxTWOgUO+nLueegrc4Er9QLtX+Aaw6fNHjF9XF27wlKp7H9P0Y6el QMRIT/Dekb0PmVZNVOFG92kQ3IG+n27D0XsEGlnpvUh+8q3YCZgEhkO2NZNBLlGfzuIw wfz7I7Ts5+mEDfs5NHbs5xb/USz648pOZgOrqyFRj1k2mqfuXkDFQCCNsBZUFCJ2+Jp5 Wtig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AfccAbTl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id z9-20020a656649000000b005b9602a7badsi8233141pgv.688.2023.12.12.10.23.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 10:23:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AfccAbTl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 2555480E60AB; Tue, 12 Dec 2023 10:23:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232907AbjLLSXB (ORCPT + 99 others); Tue, 12 Dec 2023 13:23:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232745AbjLLSXA (ORCPT ); Tue, 12 Dec 2023 13:23:00 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64FBBA7 for ; Tue, 12 Dec 2023 10:23:06 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88A32C433C7; Tue, 12 Dec 2023 18:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702405385; bh=uCBGOxwQmDbDUaJRetPxqIoUG3iao+4boB61ae9MrbY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AfccAbTlLY/jvEOi2N3unL2x/pV+T1rSEVJ4T6n2pRgpiY5eGQumcMvCDwWNSVv2P pO4ql3SyGZJ/ePLK18FplKmsohGHYOJbmDsU6I0KipvWwKs6wyGeemL+OydqurP2DI 3F+6meNb4zJe7R2j+dJkU5jp7OaMEcZuMxGrrf4fX1vclAMc66IYUbhE1YLjsRVRDc LHjiJvGQtBxcc771Lr+wzfsXxgoTTpLIX53YsmF3RPhR05YhTC+P5T4NBkFIy8zBKS RWyW4277N+QLgXAz064reLVML7WZQYlCxe0mXBg5PhckOX5h+G39VvznYK80HVy9+V SLpWU7yXmB2CA== Date: Tue, 12 Dec 2023 10:23:04 -0800 From: Jakub Kicinski To: Chengfeng Ye Cc: 3chas3@gmail.com, davem@davemloft.net, horms@kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] atm: solos-pci: Fix potential deadlock on &cli_queue_lock Message-ID: <20231212102304.4f37c828@kernel.org> In-Reply-To: <20231207123437.42669-1-dg573847474@gmail.com> References: <20231207123437.42669-1-dg573847474@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Dec 2023 10:23:15 -0800 (PST) On Thu, 7 Dec 2023 12:34:37 +0000 Chengfeng Ye wrote: > As &card->cli_queue_lock is acquired under softirq context along the > following call chain from solos_bh(), other acquisition of the same > lock inside process context should disable at least bh to avoid double > lock. These appear to have been applied to net, thanks!