Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4845050rdb; Tue, 12 Dec 2023 10:48:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcycRlriVllw987j5ED6MVwVM7o0ZWFPfflGkpevH1APgKa1RN7EVtzEZ9ueaM/aRdp5TN X-Received: by 2002:a05:6a20:bf10:b0:18f:cfed:6cc with SMTP id gc16-20020a056a20bf1000b0018fcfed06ccmr7741717pzb.117.1702406907308; Tue, 12 Dec 2023 10:48:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702406907; cv=none; d=google.com; s=arc-20160816; b=FbG12CiH3KH9wWsISZmLj+zh/2BE7P4rm/L63l7ggFpwmwr4zQsqPKxMZtpxRLdGQU Xaijtj4w8myrasLrVA2AAEw6uKkTKuRl3P0B0Lv6WRfl2x377jNMU0dIHUQYLgYJJE0q UHeyeWdOaP+q4wjTz3skZBpLjJ5YZp8189AWt08ftNK+0+1G5NU0U6jGRmv8dXYh54OH cEUtlqTAEAOUUad67wMWvmCbGPVyyIx5hRPYkTcI49C+BlW30rzNjVqt9XpjxDimzlPs rB4HLr5wY14ohU7bvBh+xhE95oPi813uHG+0bI/mXgO16nWG8ikbyxYuEMF3mNX/zr9z LSCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zBKMegGPkWb+G6Y8e5wBkM2Yy5ke+X/m+sZQHLFkJIY=; fh=OWKqgt+IbzgLpsOvVnJtlaXq0DWrbo5V3khzawq+6sI=; b=mHU74vmNggmHThC6rjRVjpycDrxo3YoY4kJ/eC6F0aSQVxlPfEbfnuYoVtnkLTbAEp BhcRG99tgIN+TQmgHjFccPRhnnHzNNMaeH8xbHuKZgas7unAs4ip13ldKjFjomLCbWD8 pskAGmkfoOqGqIbc3dkWZ2nSA7cyAK+s6/XBMXXJGuhsMC0SBLTQqp2KgnmIqPIRoLq7 2B9VoSEkC3xklMnLGN5oLT6XFlQJWKu5c97r3Dh7634kycYCQMjxLOQvGPlVymb/AO4l HQb1NrhiggHxDcvciNmBkihkrabdQyv6PMxsgMMN8Llc5F0eL7IwbyhpHmVODZgVkISx UWKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=USdyD2jj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id e1-20020a656881000000b005c627018c38si8203844pgt.307.2023.12.12.10.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 10:48:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=USdyD2jj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id DB57E80A64C4; Tue, 12 Dec 2023 10:48:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233046AbjLLSsL (ORCPT + 99 others); Tue, 12 Dec 2023 13:48:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233032AbjLLSsJ (ORCPT ); Tue, 12 Dec 2023 13:48:09 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D638CD0 for ; Tue, 12 Dec 2023 10:48:15 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B3A6C433C8; Tue, 12 Dec 2023 18:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702406895; bh=UQ8sRE4qQ4n3OeWeQ/x2EijHj4zYvZuf5iO56KaYMYk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=USdyD2jjP4yLtkFomWlwuqeB16OP1NFH0y8en3wYXly3blUxasIjop5aSKBQClcMy 7TEHzV1KpNlBCEXV5OyJ2IeSSYgMtwZioUQczT+/Ki2WC+urZD4zn03bLxXaaLHTW9 IZhZIqGFUsdvnAawqVuuVFK7wS71SnwP+LmNWYOxSid5xLQrEVK71TvyRgkhThsY28 INaElF8vnTYJPDMifK73H9UtxGnB9YqgzHCT6rhmrhpsaZGwQSfe9/DseSbPPKoFJb jEHA/jemjJMx1/hTgoPRf4uUdN43QstmbUE6ks4X/o0MtQSJiTPU/HbzrWlwYgUgvn cyRaw9O+rUbxg== Date: Tue, 12 Dec 2023 18:48:09 +0000 From: Simon Horman To: Andrew Halaney Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Giuseppe Cavallaro , Andrew Lunn , Serge Semin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: stmmac: Handle disabled MDIO busses from devicetree Message-ID: <20231212184809.GA5817@kernel.org> References: <20231211-b4-stmmac-handle-mdio-enodev-v1-1-73c20c44f8d6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231211-b4-stmmac-handle-mdio-enodev-v1-1-73c20c44f8d6@redhat.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 12 Dec 2023 10:48:25 -0800 (PST) On Mon, Dec 11, 2023 at 03:31:17PM -0600, Andrew Halaney wrote: > Many hardware configurations have the MDIO bus disabled, and are instead > using some other MDIO bus to talk to the MAC's phy. > > of_mdiobus_register() returns -ENODEV in this case. Let's handle it > gracefully instead of failing to probe the MAC. > > Fixes: 47dd7a540b8a (net: add support for STMicroelectronics Ethernet controllers.") nit: the tag above is malformed, there is a '"' missing before 'net:'. Fixes: 47dd7a540b8a ("net: add support for STMicroelectronics Ethernet controllers.") > Signed-off-by: Andrew Halaney ...