Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <53c6b75e-836e-45ba-8d16-017f907c3c3b@intel.com>
Date:   Tue, 12 Dec 2023 10:59:20 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 1/3] x86/resctrl: Add mount option "mba_MBps_event"
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        "Peter Newman" <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>, <x86@kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20231201214737.104444-1-tony.luck@intel.com>
 <20231207195613.153980-1-tony.luck@intel.com>
 <20231207195613.153980-2-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231207195613.153980-2-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UE43ZmYxOUJKNEs5SDdlZE5nc2FtMXJtQ1VHdXVnL1R1bDhKTkVuOXFXZmVM?=
 =?utf-8?B?TzVzb0JVTXBPUGt3cmZCd0E5c2tlbXFkb1NCU2ZDR2x4bEUvNUdady9WMks0?=
 =?utf-8?B?RXJwQ0c2N090VFV5QjFCdUxVeTJDS3cxSHd0U0hJdGQ5VlV0RmFsQTNmYWdq?=
 =?utf-8?B?WWlqVUtmRWFTQkNacXRhNlpiRlRqVFk2azFEQml4aFhYYmhOMWZxc0t2NmhD?=
 =?utf-8?B?emtuT3FqemRnNkp5dnNnRkdUUlYwbisvd1FzbVNLQkNOWDQwdjVpcHZ6OTNl?=
 =?utf-8?B?RklraGpuaGlHKzA1Y25qYkwzd1RrdkFLNE9IZ0IyY0pvblZNR0pjWWVtTmRw?=
 =?utf-8?B?SDM2Ni9EN3I2K2h2NGFNTHNPY0xyZVM3UWsxa2RkTHNzS0pWb0M2ZHJ3YU1w?=
 =?utf-8?B?T1lBSVFxR0Qya2t1YU0rRm5hc28xbkNTWGUxUVMzRDRSUmN1SGs4UnRLcUVq?=
 =?utf-8?B?LzY5cmtCZkU5Vno3WjdkeW1LT0dmRTdZZnE2WnlPUDFyYmlIQUpFcFlJTmNP?=
 =?utf-8?B?MnlnUmxlbUIyT2VpWFFXVW9QSVpVMEVSQkVnNjZpMUN2UzYxeHF1WGZwQjg5?=
 =?utf-8?B?VUtnSGY1OHY3KzQxRS8xd3hDQ0lIbGw3V3NlNFplcTBKQ0FZc001N01lOUdH?=
 =?utf-8?B?TFVHQ09uRE42ODlEay90YUtFUW9mUGNaZ0Ixb2R6UndFSmZIWGM2emlYNE90?=
 =?utf-8?B?S0FNYTZNTUZQR0s4OTNKVkhMRnl1WjlQYU1UNDl4Mmh3aUNndjdvTElOaHBT?=
 =?utf-8?B?Mmx3bjUwMDhoQmdFN2l2aFVwRnVyUjk4dlp1ak1vWndJcWM5Q1JVWW9RT0E4?=
 =?utf-8?B?blpWQ0dzOHJ4NURyYXdxQldCSEpEQ0hlNEVOeVgrK1Y1Mm1BTUliR21venoy?=
 =?utf-8?B?MDNlUEd4Tk1uQ2t1K3FNRW5QOHJZd21CSTUyTUExZkVESFVrdmZPbGxxWThE?=
 =?utf-8?B?RGdBUVByYlhZYUFWY2lLTUJBZXh3ZzQ0aU50b05vWjhBM3g3aGZNTGdlU3ZE?=
 =?utf-8?B?SU1XSHBSb29LVEJwcERGbUZ5dlRNQk9DSDdoYmlkMVRtdnpvU2ZCY0p2cUxu?=
 =?utf-8?B?UGtySVN5WVlLQzRsZGN4N2ZtSndCeVJ3RTFSVGRrYUJpR2s3U3Z2K2FxUGgx?=
 =?utf-8?B?d3gyOW5sRGdyTnFaM3hMbkwwcEJyK0VWd2lXWC9QbjRSTjk4SHBDbTU3VlBv?=
 =?utf-8?B?WTQvamxkRWRHMnJoVkVVYkRybEhCUHFVemZUZEkrbmF5Zzk3emlNUWxseXFy?=
 =?utf-8?B?OVhTeVRvRUgyWnJVWTdFcGxvUXZoNnM3ZUZVUVpxZmNFZ3B1MlJ6QkM4UFZ1?=
 =?utf-8?B?dlJQZlZ6VlQweGhFUzR3eGdZdWdjYTV6aDNiMWxCdmFXaUtsT2JlNEFaazRQ?=
 =?utf-8?B?Wll1c0E2S04vY3Z6bHJpVmZuZm5vSC96eGVuMlJyYjdXT3ZYdFljK1ZiS1Q5?=
 =?utf-8?B?NkJYYjFRdUtzMHJuUC84YTNpeFk3V2pwM0xLVUpTa1Q2MXBac3dDa20ydWQx?=
 =?utf-8?B?cUY0SEhxb2NBMWFXSXVBdjJhT2o0VDhEYTJ3Z3VDczhQTndGZk9VK0phSUdW?=
 =?utf-8?B?OFhvVHR3enBqT3JCbWxFWGVYSFZLRWRVUHYwdjl0Ui9vTUlRbWJQNWdvTXJJ?=
 =?utf-8?B?UGh2N2xYQ3FpRnNBbFF4NFZXNE9ZdHMrTkJnVktCL04wM0RUWEZ3UnRjNGpt?=
 =?utf-8?B?eVJrTFU0aEtxVGZZT3BxR0VYODFja1hiMzBBcUdpdG13VGthVDhIYXF0clMw?=
 =?utf-8?B?YzRqSXd1K2RpWlRQRHZUV3oyVTlTU242Z0E2TXJHbjZyN0FtYU04WmxKYWk3?=
 =?utf-8?B?WUNlSUJyME10cWh4RGJPdVZoZ0RENzVZZjh1WTZCMCtwRndNUzFteWM0RDlp?=
 =?utf-8?B?eC9IVUpRSlFMcWNMM1R6aVRCN096NjFOcTRMWEFQazlpNWk1WHZ6a1J0RGwx?=
 =?utf-8?B?bENxWnRzcUp1YnpBdGxJdGk4bUs2U1JDTUlaSGhlNUdyRmM0WUs5MDFyV2RR?=
 =?utf-8?B?cGI5RTF3bmlxOFdIb3J2ZGdLOENmMkVTQVpUcVh0RFlyWTA0MHluM2dMOVQ1?=
 =?utf-8?B?NmhoVjN5UFhQTThjU0pzZ3RMSzdac0RMSHdYM0lXTGFYZVdFM25IWHhVVlBN?=
 =?utf-8?B?Z1EvM1BsQnoveUU0QW5TVjJEYjZ6MWdsMWxFYXU0a0lSYmpweWhPbGF3NU95?=
 =?utf-8?B?dkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8be7b280-fce5-4847-e68b-08dbfb44740d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 18:59:22.8471
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1aVcX+L3fq4DAGP4E73iPsxqYwU6CHixfJKc4k7YPAPxbiRBXAyFcCGWpj40jGQid8R9//k0b+FLUBUQr6j4jxkFijJV1kRTR0J5g6vcdl0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5963
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Dec 2023 10:59:41 -0800 (PST)

Hi Tony,

I'm just adding a few minor comments to the bigger items already
mentioned ...

On 12/7/2023 11:56 AM, Tony Luck wrote:

...
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 66942d7fba7f..1feb3b2e64fa 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -129,6 +129,7 @@ enum membw_throttle_mode {
>   * @throttle_mode:	Bandwidth throttling mode when threads request
>   *			different memory bandwidths
>   * @mba_sc:		True if MBA software controller(mba_sc) is enabled
> + * @mba_mbps_event:	Event (local or total) for mba_sc

This is quite cryptic and does not add more than the variable name and type.
One example could be:
	"Monitoring event guiding feedback loop when @mba_sc is true."

Please feel free to improve.

...

> @@ -3780,16 +3806,27 @@ static int rdtgroup_rename(struct kernfs_node *kn,
>  	return ret;
>  }
>  
> +static char *mba_sc_event_opt_name(struct rdt_resource *r)

This can be "const char *".

Reinette