Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <5737811.DvuYhMxLoT@kreacher> <cf055d45-8970-4657-ab86-d28636645c81@linaro.org>
 <CAJZ5v0ic_=2wvge1T7YmGe5icR5dPxrvKy2N4gXP+KMievobmA@mail.gmail.com>
In-Reply-To: <CAJZ5v0ic_=2wvge1T7YmGe5icR5dPxrvKy2N4gXP+KMievobmA@mail.gmail.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 12 Dec 2023 20:04:58 +0100
Message-ID: <CAJZ5v0gkBZh42obB-g95T2DBFntYrnidjAeUoFN+e-CqGrSQCw@mail.gmail.com>
Subject: Re: [PATCH v1] thermal: trip: Send trip change notifications on all
 trip updates
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Linux ACPI <linux-acpi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Lukasz Luba <lukasz.luba@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Dec 6, 2023 at 5:01 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> Hi Daniel,
>
> On Wed, Dec 6, 2023 at 3:38 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> >
> >
> > Hi Rafael,
> >
> > On 05/12/2023 20:18, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > >
> > > The _store callbacks of the trip point temperature and hysteresis sysfs
> > > attributes invoke thermal_notify_tz_trip_change() to send a notification
> > > regarding the trip point change, but when trip points are updated by the
> > > platform firmware, trip point change notifications are not sent.
> > >
> > > To make the behavior after a trip point change more consistent,
> > > modify all of the 3 places where trip point temperature is updated
> > > to use a new function called thermal_zone_set_trip_temp() for this
> > > purpose and make that function call thermal_notify_tz_trip_change().
> > >
> > > Note that trip point hysteresis can only be updated via sysfs and
> > > trip_point_hyst_store() calls thermal_notify_tz_trip_change() already,
> > > so this code path need not be changed.
> >
> > Why the ACPI driver is not calling thermal_zone_device_update() after
> > changing the trip point like the other drivers?
>
> It calls that function, but because it may update multiple trips in
> one go, it does that after all of the updates are done, via
> acpi_thermal_check_fn().
>
> > It would make sense to have the thermal framework to be notified about
> > this change and check if there is a trip violation, no ?
>
> It is notified as noted above, but not synchronously.

I believe that the question above has been answered, so are there any
other comments or concerns regarding this patch?