Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4863648rdb; Tue, 12 Dec 2023 11:19:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFPYmcQrU3Z5fVdLKEdrMKswpc28iQabqvSxa5qaEQXvw6KG/7igIQKH/poQ9IekZiL1hsU X-Received: by 2002:a17:902:e542:b0:1d1:cdb2:a93c with SMTP id n2-20020a170902e54200b001d1cdb2a93cmr7725433plf.130.1702408759322; Tue, 12 Dec 2023 11:19:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702408759; cv=none; d=google.com; s=arc-20160816; b=P7fAdnTKZ00PRRFbgg7RVueTN6iLDxAJ1BLtliWS/LlH+TcN4lIzGvG5vjMOt85dB3 CNz13gaZgXDRT4tmYTraNV1VVd2wqZHq2DrWa9X7PjvEpF8hVh7TL6xwK14ps16GllWT WjclR6YvsI4pCTWcPnyK3DZdR64PEZGg4zRRvWUXIghXypXZIrSRO4dI4yTSTmotj2nq Ii2I8gboAQaiRKVdjJWam29D8WGFMGpkui/fyIEwtCm4llEUtfwVXOBLrsalx0F2C7yb r8lTMwhlPPAErEGZBDBwKlKkQmGpuQnkiC/kuyuTEWyBGiknPERndP7EE3uvMYAPmAgw URYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Spl4uVpVpDBBC6FUFB90x0KZV7dsKNPMFjBZoK/YaWY=; fh=QdJR9jtNIj2Sbd7syGL/9waVyGlQYJT1MzIZmEabwTw=; b=U5i/JIJFWBGFziq7y2ypdYzQMVwsvpzKId5nm6F+Y/dwpeG/zCyooRA3XizYNMWGYQ BTrxth8CwXxeB049SonT72se21WXIEWD8jfiaG3LWCMsImHrq9k0Oy88HwlKAWJPkKs9 t8M2UdpeulDIl2kzqZKsv2sdBPOCABQM5Mh5eaHg9GoMn4pQYnwpVSDZuQse0G/tHp/D q/h6zBR3iHS2RILemCzviBlRmeYIESCZwFIz/Gt3myZd3k1mi0c93K26wP4b3w/R/M6O 0DC6W0C5991qq8SWFRHbX+08h3DETrrn9B6Qc2W4xLFTEKjc9uBufFag7j+3nNT2xrdg HocQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EJnt4hSj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id g14-20020a1709029f8e00b001d0522c0778si7996612plq.641.2023.12.12.11.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 11:19:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EJnt4hSj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id ADEF780B1233; Tue, 12 Dec 2023 11:19:16 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377091AbjLLTTE (ORCPT + 99 others); Tue, 12 Dec 2023 14:19:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233067AbjLLTTC (ORCPT ); Tue, 12 Dec 2023 14:19:02 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF5F2AF for ; Tue, 12 Dec 2023 11:19:08 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16CECC433C7; Tue, 12 Dec 2023 19:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702408748; bh=VxUoH5W5QC5FMheEWzI9jkp0t9473bp8pPVB/cabv8Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EJnt4hSjmhNoJdTQBC3pAIpLXXR60HMnuj7GY98aRzTVrTSMiSR7FQbNGgf04MACC UEJ1I75/BzQawTP6amcrMVoo0fzVVH7OlW78OY6upyqPsEBEtzu9wXuOK4cq0IQcMB FY1j3CqXTyoH0rLYlxeUcXAkSHJ694vOd9CmFZA1LTtN2Aw6hvxBwfuCRR2ZBcUic2 vZakpo64JMHxfEPwV5B47K7y5b12bTDGFDkhaPDhK97iLDYpjLBuEOBVsbTlMpDQM5 eqanzn7KJPQhcAk5KQfqIiu+NkkKPr66qK4V6//XNdTbTj6zMhgO0WG4zrZO7B8kbR oY8UG/MKLO46w== Date: Tue, 12 Dec 2023 11:19:07 -0800 From: Jakub Kicinski To: Justin Lai Cc: , , , , , , , Subject: Re: [PATCH net-next v14 09/13] rtase: Implement pci_driver suspend and resume function Message-ID: <20231212111907.543e8f04@kernel.org> In-Reply-To: <20231208094733.1671296-10-justinlai0215@realtek.com> References: <20231208094733.1671296-1-justinlai0215@realtek.com> <20231208094733.1671296-10-justinlai0215@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Dec 2023 11:19:16 -0800 (PST) On Fri, 8 Dec 2023 17:47:29 +0800 Justin Lai wrote: > +static int rtase_suspend(struct device *device) > +{ > + struct net_device *dev = dev_get_drvdata(device); > + > + if (netif_running(dev)) { > + netif_stop_queue(dev); > + netif_device_detach(dev); detach stops the queue, you don't have to call both > + rtase_hw_reset(dev);