Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4865523rdb; Tue, 12 Dec 2023 11:23:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEk2doZ4GuhICEDI69Yk91hJdRhfqK8VZ58aOn2+5T01p6xO+CmgvHS+na14z31VmhSHBc X-Received: by 2002:a05:6a21:789c:b0:18f:97c:928d with SMTP id bf28-20020a056a21789c00b0018f097c928dmr3897632pzc.114.1702408980341; Tue, 12 Dec 2023 11:23:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702408980; cv=none; d=google.com; s=arc-20160816; b=uWovlHJKBN0f1tYhasH+/SIFWwo5B78X/GYJWpNmmufv8Y+jxyCVsqZu3Q9BWyxGQi aciJWfUhttf54M2gCWJHb/diiahXKRWVGS9C3dA160TozECcwCDN0QeLSoYIpOLkv9xS oqB9HasD0o+1tUQiw8TUyOwIGKO7K4BgCjzpF8ZepZQbsY70+10g8aZ7EU0vOYXfrI3e eEQmwHJAiTXQRN7Nlbkaae5IJI6U1jOPfmcT8HcOuOSK7gR252D2hMAYGpOXreMZtYpS iYSo7cpFFaV1tD1L+yJ0XHnkh42dA3qstNqdQ7rPLFDMU+c2N+PVHL3/DukujbaLyvNo jykg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:autocrypt:references:cc:to:from:content-language :subject:reply-to:user-agent:mime-version:date:message-id :dkim-signature; bh=umUMg8BrauQqL1p4Yx4u2IynFqr2rPCz5Y0+oad9/5A=; fh=0veWeSfzdicyOdQu+DI6J4cC59Z6UyuYq6pTI7XrDXg=; b=1ApPdDDzXJoXb3WIyLWJTJcxu6dPyeMz9Oka3MxnmVPh3/mBmq7NY1zy0fYIxgP3tz Xx46RmH6AdXX7Mjng4h6Wqacs5MbIFke6CUaSe4jIG67QXlE8vKR+MiMCkQTj4DJTRhC R0aSa3VQxiW/D/2gEeEPlL22DvxCCf2SDpZi7+Ubvq/fV6m92JjFvw+XYrlcgHjvfnfu 7EIgHwIshj+ZH5oyJb4nhEVFAJmFxRwaJOn7IUePc3PAdA/f7Tlx1dVxEd3ydQcE6ImI V5CN6Em+URAQgDqm8Yq+T0XJZ5glCEcX9Ta8/cPrz7c43zLKde1dikVx5ZF0AB2craRG xA7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eqW+x99T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id u6-20020a6540c6000000b005b92fb731a9si8046856pgp.834.2023.12.12.11.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 11:23:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eqW+x99T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E64DB80739F6; Tue, 12 Dec 2023 11:22:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377196AbjLLTVm (ORCPT + 99 others); Tue, 12 Dec 2023 14:21:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230181AbjLLTVk (ORCPT ); Tue, 12 Dec 2023 14:21:40 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9C79AF for ; Tue, 12 Dec 2023 11:21:44 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40c339d2b88so46529005e9.3 for ; Tue, 12 Dec 2023 11:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702408903; x=1703013703; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=umUMg8BrauQqL1p4Yx4u2IynFqr2rPCz5Y0+oad9/5A=; b=eqW+x99T0KuolBrcizi9zlPxeuQPIFYK02cLb9iaujZ/uuZ5AZpU2kR88amoafzmA7 BvQdjjld1qzucRwHbVlDMJlnqrn4zk7nVs2L5yE3L+AJxlzJzIvb0J3BnRnRZIf1p1Zx KCSReO57W8WYKteChNJBSDcgsA4qvNhnEnej/LSHgyBkRIihfozmA95/vMGBfy0rCak1 SgxHULUe/FKJz3THKZeLBKmF0xwXEz6JJetu4VhH1mMLgfWVP+u4+lmyiNoCcL8wv5dI 22CZmXfg8S+UNDWOjcwUUWxA3Z/+qiWAnrLC185yZJjD7ykPaQ+xvZdsNeTLVheBabnx yHbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702408903; x=1703013703; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=umUMg8BrauQqL1p4Yx4u2IynFqr2rPCz5Y0+oad9/5A=; b=qzYYsR2M5pTD15AX9CkVqqjj5yv5P/XoDha8Y65nzxaPglMc85kLcIUQQx0OBXMt4O 4X+RJcBa6LmElOwAKzQlhVN9gt7tpMS2Br7nqy2vH2V2SAEwA6HZC05vsANCjTaLSHOS fVJTH0DotaL0fuytIPyvgU0TkmkqoNiK4/ZvdIdsU2yLHPoYSVMSWVzeFnEyitQA+kej 2I5pR9kd++p8x5iq1LdliLb/6DgzoD9kRymLMui+mtkvYy2A7JvI3lxMi3katbLA2szl zgOzeeqJQBUU7DHa40vhiFqlNt0IK1A9K30GxEQlyS1UfMeFM1MHbEHfJqRCttZ1D2tB lahw== X-Gm-Message-State: AOJu0YxI3D9XhHwbIY6n2MID459OVjDzHJl2EV6Y8iaZI0xBGZKOWXJb 1uoDS2mtMl0Cjvh60923mS3jSw== X-Received: by 2002:a05:600c:c1:b0:40c:2aeb:a7ca with SMTP id u1-20020a05600c00c100b0040c2aeba7camr3115859wmm.57.1702408902998; Tue, 12 Dec 2023 11:21:42 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:92fc:7790:1480:63bf? ([2a01:e0a:982:cbb0:92fc:7790:1480:63bf]) by smtp.gmail.com with ESMTPSA id b1-20020a05600c4e0100b00405959469afsm17722407wmq.3.2023.12.12.11.21.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 11:21:42 -0800 (PST) Message-ID: Date: Tue, 12 Dec 2023 20:21:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/3] soc: qcom: pmic_pdcharger_ulog: Search current directory for headers Content-Language: en-US, fr From: Neil Armstrong To: Andrew Halaney Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> <20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com> <320864f5-fdd2-4345-a0dd-b97bcf17f473@linaro.org> <139f9af0-ca6a-4a58-ae18-79ef6fac47e3@linaro.org> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <139f9af0-ca6a-4a58-ae18-79ef6fac47e3@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Dec 2023 11:22:14 -0800 (PST) On 12/12/2023 17:52, Neil Armstrong wrote: > On 12/12/2023 17:15, Andrew Halaney wrote: >> On Tue, Dec 12, 2023 at 09:54:48AM -0600, Andrew Halaney wrote: >>> On Tue, Dec 12, 2023 at 04:23:20PM +0100, Neil Armstrong wrote: >>>> Hi Andrew, >>>> >>>> On 06/12/2023 00:05, Andrew Halaney wrote: >>>>> As specified in samples/trace_events/Makefile: >>>>> >>>>>       If you include a trace header outside of include/trace/events >>>>>       then the file that does the #define CREATE_TRACE_POINTS must >>>>>       have that tracer file in its main search path. This is because >>>>>       define_trace.h will include it, and must be able to find it from >>>>>       the include/trace directory. >>>>> >>>>> Without this the following compilation error is seen: >>>>> >>>>>         CC      drivers/soc/qcom/pmic_pdcharger_ulog.o >>>>>       In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, >>>>>                        from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: >>>>>       ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory >>>>>          95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) >>>>>             |                                          ^ >>>>>       compilation terminated. >>>> >>>> I never experienced such error, and no CI even reported it, can you explain how you got this ? >>> >>> To be honest, I am unsure why I'm experiencing this (and until I saw >>> another thread about it today I thought maybe I had screwed something >>> up!). >>> >>> I just took it as an opportunity to try and read up on the tracing >>> infrastructure and sent this series. Definitely no expertise with the >>> in's and out's of tracing :) >>> >>> I'm able to reproduce this on next-20231211: >>> >>>      ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make mrproper >>>      >>>      ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make defconfig >>>      >>>      *** Default configuration is based on 'defconfig' >>>      # >>>      # configuration written to .config >>>      # >> >> Realized I missed a step, actually enabling tracing and the driver at >> play here... but the result is the same. >> >> Attached is a config where I hit this. >> >>>      130 ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make drivers/soc/qcom/pmic_pdcharger_ulog.o >>>        HOSTCC  scripts/dtc/dtc.o >>>      >>>        CC      drivers/soc/qcom/pmic_pdcharger_ulog.o >>>      In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, >>>              from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: >>>      ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory >>>         95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) >>>      >>>      2 ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % >>> >>> I even tried it in a fedora container with the above build commands and >>> the following podman invocation (plus some package installs) and saw the error: >>> >>>      podman run -it -v ~/git/linux-next:/linux-next:z quay.io/fedora/fedora:latest /bin/bash >>> >>> So I'm unsure if it's a fedora package version thing (which I'm running on my host) >>> or something else... Once I saw it was sort of spelled out in the >>> examples I referenced here I just decided it was something needed >>> fixing, regardless of why I'm hitting it while others seem ok. > > Interesting, I don't get the problem with the same tag, same .config but with gcc-arm-10.3-2021.07-x86_64-aarch64-none-linux-gnu > > I'll try with gcc 13. Ok tried with ARM's arm-gnu-toolchain-13.2.rel1-x86_64-aarch64-none-linux-gnu (https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads), and no error, and I even tried with https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/13.2.0/ and same no error... Neil > > Neil > >>> >>>> >>>> Thanks, >>>> Neil >>>> >>>>> >>>>> Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver") >>>>> Signed-off-by: Andrew Halaney >>>>> --- >>>>>    drivers/soc/qcom/Makefile | 1 + >>>>>    1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile >>>>> index 110108e23669..05b3d54e8dc9 100644 >>>>> --- a/drivers/soc/qcom/Makefile >>>>> +++ b/drivers/soc/qcom/Makefile >>>>> @@ -10,6 +10,7 @@ obj-$(CONFIG_QCOM_PDR_HELPERS)    += pdr_interface.o >>>>>    obj-$(CONFIG_QCOM_PMIC_GLINK)    += pmic_glink.o >>>>>    obj-$(CONFIG_QCOM_PMIC_GLINK)    += pmic_glink_altmode.o >>>>>    obj-$(CONFIG_QCOM_PMIC_PDCHARGER_ULOG)    += pmic_pdcharger_ulog.o >>>>> +CFLAGS_pmic_pdcharger_ulog.o    :=  -I$(src) >>>>>    obj-$(CONFIG_QCOM_QMI_HELPERS)    += qmi_helpers.o >>>>>    qmi_helpers-y    += qmi_encdec.o qmi_interface.o >>>>>    obj-$(CONFIG_QCOM_RAMP_CTRL)    += ramp_controller.o >>>>> >>>> >