Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20231211193048.580691-1-avagin@google.com> <20231211193048.580691-2-avagin@google.com>
In-Reply-To: <20231211193048.580691-2-avagin@google.com>
From:   Andrei Vagin <avagin@google.com>
Date:   Tue, 12 Dec 2023 11:45:33 -0800
Message-ID: <CAEWA0a5t=7U3xNKDDH36Z_37Xereosy49fz4q3pV=j0bCOjDZg@mail.gmail.com>
Subject: Re: [PATCH 2/2] selftests/overlayfs: verify device and inode numbers
 in /proc/pid/maps
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org, Amir Goldstein <amir73il@gmail.com>,
        Alexander Mikhalitsyn <alexander@mihalicyn.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Dec 11, 2023 at 11:30=E2=80=AFAM Andrei Vagin <avagin@google.com> w=
rote:
> +static long get_file_dev_and_inode(void *addr, struct statx *stx)
> +{
> +       char buf[4096];
> +       FILE *mapf;
> +
> +       mapf =3D fopen("/proc/self/maps", "r");
> +       if (mapf =3D=3D NULL)
> +               return pr_perror("fopen(/proc/self/maps)");
> +
> +       while (fgets(buf, sizeof(buf), mapf)) {
> +               unsigned long start, end;
> +               uint32_t maj, min;
> +               __u64 ino;
> +
> +               if (sscanf(buf, "%lx-%lx %*s %*s %x:%x %llx",
> +                               &start, &end, &maj, &min, &ino) !=3D 5)

inode is shown in the decimal format, so the last %llx has to be
replaced with %llu.
I will resend this test in reply to Amir's version of the first patch.

Thanks,
Andrei