Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Tue, 12 Dec 2023 11:41:49 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Vishal Verma <vishal.l.verma@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Jiang <dave.jiang@intel.com>
CC:     <linux-kernel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
        <linux-cxl@vger.kernel.org>, David Hildenbrand <david@redhat.com>,
        "Dave Hansen" <dave.hansen@linux.intel.com>,
        Huang Ying <ying.huang@intel.com>,
        "Joao Martins" <joao.m.martins@oracle.com>
Subject: Re: [PATCH v4 2/3] dax/bus: Introduce guard(device) for
 device_{lock,unlock} flows
Message-ID: <6578b77dc911e_22601629440@iweiny-mobl.notmuch>
References: <20231212-vv-dax_abi-v4-0-1351758f0c92@intel.com>
 <20231212-vv-dax_abi-v4-2-1351758f0c92@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231212-vv-dax_abi-v4-2-1351758f0c92@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BzAstGTQ5qJ2+HhC94uA9P+WWtwwrG2H51TINnXchz4CthHDlzwDO/7XpnK9?=
 =?us-ascii?Q?IW4z8DZ3mccChm/muw80nt1lIj8Mb1+ic/T069E0/UB6m70VX7gvtCaDSztU?=
 =?us-ascii?Q?Jwiineag2XXnKE0Ehza7I1SrcuAX62wJeiclTkS+Rx9OqeQNUXpWAayy9+5G?=
 =?us-ascii?Q?kQb6F6cCuGSFKBw2SmVdGlxW6rGUNFA9gAw3/iCEPHe50E/qiNpC0yQzJxnM?=
 =?us-ascii?Q?MCggMLRwORQCKebUhqZNoEj4z7WlLetkhUcqlnpuxldCvTxok1+SIH11RIrb?=
 =?us-ascii?Q?/BZ6xmxS8wTk/XVpOIScfhoB0C/6BsFrHe3RohkNJU5EA2PGCPiipCpbvDDa?=
 =?us-ascii?Q?oUdYGsQzOpst55jQ88RhrbUsyGULJxfJxrtWBssQc35dypW9bHXbJ2mCLH6v?=
 =?us-ascii?Q?Zazeu+iBkfvhN0jJzfBazLK1ndbmR5XuZfhh4WiwzPrS3n6ZJe56xyyeKmBv?=
 =?us-ascii?Q?SzItL+y9RPV2ZUcaIQk+xUgOLC243BdAKlkBFKa06EljFwNtcUBF5sC9DdKh?=
 =?us-ascii?Q?AAb2+LBBs96uqD2jPDi47qIj5asbEMAtUYOk2KlWiUXln8uYK7W6ujMVko3s?=
 =?us-ascii?Q?RuYc4ZQFAHtQIzrKfu9zx4nhFNbEG2i/uROSpLvNIkwvtOx8FXsqdUN9L8Ns?=
 =?us-ascii?Q?9A8VQE12N2fVzaNrgKnBI0Yz1Hr3h8lBKKP82m8Gjrp/kji/nVWACDl0hbfp?=
 =?us-ascii?Q?0tyOw3N0iJM31LE/I6ZM8rjY64EVeRZQUUgsmpYBE9VWkPcLFfaU+78HUstH?=
 =?us-ascii?Q?tNeBpMNxUtqHyvkx77GILNDqc0S0pRESaJkf5N9eaT13QNbJjLh1Dps60oJ3?=
 =?us-ascii?Q?FcHR9iThBy4Y0OXwCQMsROWAO9CirGffKbxyPeYlBt/7RVNKda22IEORelK1?=
 =?us-ascii?Q?Lw//FUTDCdbqUXotX3lyqzwUyuAEWf14UfUqECz21jB5DWQ1EzI5oss9IDjp?=
 =?us-ascii?Q?84JSqSmNU4MT/sS0IgdVz65ZZSDp4Rj/ZRjomKVndtB5wynHhJEHc1d9tLG6?=
 =?us-ascii?Q?jgl05G2OMmb5vj8RWcFQMmyddk0wShWD8KMHbMiRjOprO8Wb0z2dhBVlaBcS?=
 =?us-ascii?Q?bZ51agyUGYIvRfcYWf3GeJhXvMMwOwBp54uvyx3InFtnEIwGSN753umb1xgC?=
 =?us-ascii?Q?udqbb1Pu1AAhUJOFDLFntVCf8lbskeBGTgTzM46O6z9FdK54nO3mB4DIUfZz?=
 =?us-ascii?Q?tq1tGrti5NeYEGwBVJTI2pryjPgsu/iClV/fHwgZQPmxAFn93sm1uLlWHsXy?=
 =?us-ascii?Q?jMLzhdcQ6ab1Aq58PardA8aa8m/gJDlVFWf0XP3U2FB22tPDmOyFWKToYLei?=
 =?us-ascii?Q?APrn//p/c1CoqkzTuW4iBZhik1rE59uqssJyDUgVP86rYOr3DTgtgbL7sgzH?=
 =?us-ascii?Q?7NshOWDq2HatdHmBJYpycImfe3Sii/KXJ0ez2Y02UV3tH7kFm7ar7iVUsqyE?=
 =?us-ascii?Q?1aWfdkNYcNAQ03aQ3/LN5czMb4gW4Iic5JnYrptI1FacOvWaGPFtMX1NVIyy?=
 =?us-ascii?Q?flTjQhXsFgY4LWM6xwPmSfPVmiCktZiE0ZuXet9e9cvQUjNXXjRkqYi02V0F?=
 =?us-ascii?Q?zWK1iP22PGbFsFyHYi6ocUZlyNRpN1rDHCU+tbGv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2015c629-ecb9-4e04-e064-08dbfb4a640b
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 19:41:52.9474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PlcqWNjKBzigE+EWEaUxwMd5bejkKAU+6eNdmVONoq6Pxm4LLCx1rPAdy7lvkHunfu4WkDKQiIouI+r8GvZV7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB7703
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 12 Dec 2023 11:56:56 -0800 (PST)

Vishal Verma wrote:
> Introduce a guard(device) macro to lock a 'struct device', and unlock it
> automatically when going out of scope using Scope Based Resource
> Management semantics. A lot of the sysfs attribute writes in
> drivers/dax/bus.c benefit from a cleanup using these, so change these
> where applicable.
> 
> Cc: Joao Martins <joao.m.martins@oracle.com>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>