Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Feedback-ID: ifd194980:Fastmail
References: <20231212165637.17618-1-garyrookard@fastmail.org>
 <20231212165637.17618-5-garyrookard@fastmail.org>
 <6a065daf-3639-4a87-8ab6-7018e0362900@gmail.com>
User-agent: mu4e 1.10.6; emacs 29.1
From:   Gary Rookard <garyrookard@fastmail.org>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] staging: rtl8192e: rename variable pHT
Date:   Tue, 12 Dec 2023 15:14:01 -0500
In-reply-to: <6a065daf-3639-4a87-8ab6-7018e0362900@gmail.com>
Message-ID: <874jgnuqf0.fsf@fastmail.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Philipp Hortmann <philipp.g.hortmann@gmail.com> writes:

> On 12/12/23 17:56, Gary Rookard wrote:
>> oding style issue, Avoid CamelCase
>> rename it. pHT -> ht
>> Signed-off-by: Gary Rookard<garyrookard@fastmail.org>
>> ---
>>   drivers/staging/rtl8192e/rtl819x_HTProc.c | 20 ++++++++++----------
>>   1 file changed, 10 insertions(+), 10 deletions(-)
>> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c
>> b/drivers/staging/rtl8192e/rtl819x_HTProc.c
>> index ac85151a6069..add8f58b5b1e 100644
>> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
>> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
>> @@ -250,17 +250,17 @@ void ht_reset_iot_setting(struct rt_hi_throughput =
*ht_info)
>>   void ht_construct_capability_element(struct rtllib_device *ieee, u8 *p=
os_ht_cap,
>>   				  u8 *len, u8 is_encrypt, bool assoc)
>>   {
>> -	struct rt_hi_throughput *pHT =3D ieee->ht_info;
>> +	struct rt_hi_throughput *ht =3D ieee->ht_info;
>>   	struct ht_capab_ele *pCapELE =3D NULL;
>>   -	if (!pos_ht_cap || !pHT) {
>> +	if (!pos_ht_cap || !ht) {
>>   		netdev_warn(ieee->dev,
>>   			    "%s(): posHTCap and ht_info are null\n", __func__);
>>   		return;
>>   	}
>>   	memset(pos_ht_cap, 0, *len);
>>   -	if ((assoc) && (pHT->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) {
>> +	if ((assoc) && (ht->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) {
>>   		static const u8	EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 };
>>     		memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap));
>> @@ -275,9 +275,9 @@ void ht_construct_capability_element(struct rtllib_d=
evice *ieee, u8 *pos_ht_cap,
>>   	if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev))
>>   		pCapELE->ChlWidth =3D 0;
>>   	else
>> -		pCapELE->ChlWidth =3D (pHT->reg_bw_40mhz ? 1 : 0);
>> +		pCapELE->ChlWidth =3D (ht->reg_bw_40mhz ? 1 : 0);
>
> The last line changed with my patch:
> [PATCH 02/10] staging: rtl8192e: Remove variable ht_info->reg_bw_40mhz
>
> It is always difficult to know which patches are accepted by the
> maintainer but you may want to look into the following mailing list to
> see if there have been any patches send in for this driver.
> https://lore.kernel.org/linux-staging/
>
> You could apply the send in patches and build your ones on top. Then
> you do not have this issue. But when the patches you are using are not
> accepted you will run into the same issues.
>
> Thanks for your support.
>
> Bye Philipp

Okay, no problem.

Regards,
Gary

=2D-=20
Sent with my mu4e on Gentoo GNU/linux.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJNBAEBCAA3FiEEjsrWb+cZk1AuzV9C2li+Bks2LgAFAmV4v8MZHGdhcnlyb29r
YXJkQGZhc3RtYWlsLm9yZwAKCRDaWL4GSzYuAFpHEACxYwOhErAQCco8Srpcq/iI
tgRK7G0GMYdbXPOz7fNxuLv9AUKMijqMyXiGtO8L+koKollJqD/3l07Cnm8CAxR4
JWRu/nK8Dz6w1jWtStJxuhV1qlKenCrYPrCLOkRMG3S4VHHWnf1TOYl/l1hVu1bQ
aBBOYjQGR1tD/8rDCC/uu18iDVAW5o0uRhhYQyrCjSPmp5XNmdIPBTfLG18PtSBK
sfHA+UdZXt2wVjVgPworBuEHahBjgKG1Ev9eqaTiqNgWxxyX8APZl4smz90Jbm/W
mTL8/exIwQMLl4rtBJVD+i0ld07DWs/0Dw2kIwgqKenOHO+eb5c2KKdFbsGLiCeX
1GYwVo8zvDNx8U2SVFBVyAYQaoO73CSUG6ssr39WL37bdyXaYKQwLG8MFhdJlj9j
2yRdBSaECnLKBbYZyuIb/h8nbg3vZK+Qe+EHaDfXubFVfJt3LNm0x72Ndb+lTf84
6G9OvJpHJ3cYdU4uuTyH0oZibS8PVkBLv2aKjnZ8OCxGAhYtllB5bdCMIWD9Hyx4
68Cyp8j11fbNwwZ5Vqj6PtqZYYb0Qjb9tdcYVYKy3tBUlilwA7CquRBF5g6W9GJg
23lOk8/aaNgdZ+zzIUpduLOLiVfulh2wN9bhB77fE1XBn3PoO/8jUCTxNGd/PhC0
ooy5Ip9S0Ts73VCX4xGzDA==
=OyRa
-----END PGP SIGNATURE-----
--=-=-=--