Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4900820rdb; Tue, 12 Dec 2023 12:28:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+gYG8JwPyLRedrqgAzI9YxfN2Khdn4EvkYXekavkTgdq5WNRcMcd8MUP8mHcRGi+9jfxr X-Received: by 2002:a17:902:b18d:b0:1d0:bba1:57c6 with SMTP id s13-20020a170902b18d00b001d0bba157c6mr6895690plr.76.1702412910099; Tue, 12 Dec 2023 12:28:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702412910; cv=none; d=google.com; s=arc-20160816; b=sVtDP854u83utqi/Af1eBnOmZSmTZHAfTrqPHnF83o8HWLXJ9/Wxn6JtVbRskcqNhI ijiXW7wCiTg/DGGNy+1Fs8dszkozqsbwxgZo1dR8YY0Z8Zj7Z49XxsXm/LTGWTODEhz4 CxKV8CxMDBZ/5XbmbOsB0cslcAyWJDApH0semH6NdSSJjtI9t7QcxhZhNaLjpfIB5ySh PQzbrg1owBKqd/NW+e87ldDaVBflJOQtCfl89NJHu6iPriT2uvvXU2IlB23QrzZjH9uf ywrUO+zog7MEc9YQwV7Efm+1bgPIq3a1ZOkAhQPQGMXaGw9xzUJBScP7IrZyu4FVotXz SV0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :content-language:references:cc:to:subject:from:user-agent :mime-version:date:message-id; bh=kHahnm6x2RByOsvkFTXG4oUFShLbTIHM8FyPM7vnGko=; fh=pd4dcCROVxg/38uIEF4qJQXW5PKYANvk6Ozo/7MfzR4=; b=Jf7c4xmzYxLQQ51lenqD48ZrAzGQWG2Oss8oSqemnIBx3dkiV3T6MXpczfbg0bT72n 6KxmEFOET+RoTQ8a0D26Fqdl+EEHR4dFg2Gqrcuxu6lyDgNylSr/aOYvOKq6aeJaP5K8 7WFkRWtKXyct4j3t3JLKT+CzvKt53fD4f/bBvcK8yUWsyHmTz9SAphwzZhTdRYdb2py7 HblFtRWML1s8jVDvZO5dKoVGBPjxIAlwgr9a0PxYwwM47kjw3aA7xeNz7iZqstsNcMzf oPYXW1LFe+TGljWxI/cyuo7BNK02wtBYhFxHIr1zGcore7ZlZ4Fzg8InDCkOs1JU0zxj IaLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id f4-20020a17090274c400b001d33a5dd5d6si1366319plt.596.2023.12.12.12.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 12:28:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C7B3880B122A; Tue, 12 Dec 2023 12:28:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235119AbjLLU2P (ORCPT + 99 others); Tue, 12 Dec 2023 15:28:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235113AbjLLU2N (ORCPT ); Tue, 12 Dec 2023 15:28:13 -0500 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCAD2BD; Tue, 12 Dec 2023 12:28:19 -0800 (PST) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5ca29c131ebso1544842a12.0; Tue, 12 Dec 2023 12:28:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702412899; x=1703017699; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kHahnm6x2RByOsvkFTXG4oUFShLbTIHM8FyPM7vnGko=; b=njwVJjsa8uaKT859IyvqhVlkh+XVNzry8ne8nckUYBfUv1zS9XXX82NNG29qmX+FBt diY8ZtCrS9kaCOSdNOUTxTOy0iVhpo3OI0wkRFgIIFVt4evD7eluqskBOuyvT9io1iQ3 c9Smd3T2c+hTvJkNx2I70SDdbLUXBahOOWisDtQ0oy+g31EW41Yd92bcfeACDgkK+BoK TcDFVdGnOJbX/v+5Wv/69vWYWJG23PHMmyLUHhSR+pFCghTKT6UiSP79V3pqk25vsKYB ZldjTBzqo4Wle518bw8eGd/cTG8vIGqGfu0jiKabJXw6qORkbi9InfPJlbbxMjvMKDOR xTnw== X-Gm-Message-State: AOJu0YzFv8pgXtxEuXf8TtM+YEa6BxNxu7R906sKo4X9VJpHQ+RfgaPH xci+UPYZnSv7lrXEpxHA6Ms= X-Received: by 2002:a05:6a00:c93:b0:6ce:7af1:1be2 with SMTP id a19-20020a056a000c9300b006ce7af11be2mr9792581pfv.24.1702412899091; Tue, 12 Dec 2023 12:28:19 -0800 (PST) Received: from ?IPV6:2620:0:1000:5e10:c59a:35c6:9a2a:969f? ([2620:0:1000:5e10:c59a:35c6:9a2a:969f]) by smtp.gmail.com with ESMTPSA id s16-20020a62e710000000b006cb4fa1174dsm8507795pfh.124.2023.12.12.12.28.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 12:28:18 -0800 (PST) Message-ID: Date: Tue, 12 Dec 2023 12:28:17 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Bart Van Assche Subject: Re: [PATCH 1/2] scsi: myrb: Fix a potential string truncation in rebuild_show() To: Christophe JAILLET , hare@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com Cc: hare@suse.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <2d3096dd4b1b6e758287e4062e3147c57c007eaa.1702411083.git.christophe.jaillet@wanadoo.fr> <70b7e97b-2044-4515-aadc-87d202d32b93@wanadoo.fr> Content-Language: en-US In-Reply-To: <70b7e97b-2044-4515-aadc-87d202d32b93@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Dec 2023 12:28:27 -0800 (PST) On 12/12/23 10:20, Christophe JAILLET wrote: > In this case, do you still prefer 2 patches (one to fix > rebuild_show() and one for all the other _show function) or only 1 > with everything in it? One patch with all the changes is probably better. Thanks, Bart.