Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4928098rdb; Tue, 12 Dec 2023 13:27:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6shg3WVMBJgjxNHpiw0XftmnsJ8OHdC2mOCj5gT1Kna8rFW7t3hTE2tgHi3bl4aB6frlE X-Received: by 2002:a05:6a00:3a1d:b0:6d0:8b0f:1091 with SMTP id fj29-20020a056a003a1d00b006d08b0f1091mr3960518pfb.30.1702416428840; Tue, 12 Dec 2023 13:27:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702416428; cv=none; d=google.com; s=arc-20160816; b=AU21p+J7u5ivkzdsV9ieYTJjMKFd4Ik9z5K6Qb22cyM55VFcWJ4YzsfYGDEx+FmgTc U6BnuHIApQAHTTPjGHLQyi1hs+fJZPtAaqqksdUvNOFJCuwXENp5E6xk1er6TQJo8m7r 6BLrmlukOl0Pao3/RjgiLbwTJ6WuIbmTPFvDJX9iW+TCdL+m5RoxDDFZtNb7TMzlFswD qHAlvfxM4NJtzWEmZGvIEMc0BWZMhHaLwh2wjnK3qHElQzhp9zueaRKLLxrUCHB6bv0h 4jw0Bn1NeTlTRGQGsNtsXRuWibTS8kwsr+sehpeZU/p2YaUAli54MEPpXd3R7xBawK21 PNHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=iDkcdy1rLFiDTVMfWpv3hU1552hZlbVNVr8oF0N/vYU=; fh=BL3QPvt2giMGcIhWB6xImQ8WRfFfH/24QgxgASZSnV4=; b=BoF/+hMzLtrabvVAi5/g7zKs7L+csHIV50+pgAf0q49utTsEWgCurlUACCPBTKwWdT tNGOuIwHBZ6Q1J2Em9JswgABn4pl2W7tp81S0DY9NDYS7E5kJsW/XY2GzcLM3mfxvSMh 5nEYAWMjsNKCXNo1YbKNPmjM2XVgCGzH0RrgnGmPnqp5wQ6nYgCOJUnKkEPgGWMsLIQO DiRuOlx6PVJnJp5rnDWkyLeteuEB13Y9XutJu//FHrNEnUl1JO/Nm1YPHtWFiv1M3vA2 BxErDDXIyIBiJRF/BgVOdOytXP5eFqFZFAT7AczRD3S/kwUUp0wpbNhHqddDsMollGF6 IJug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=flRSOrwL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id h10-20020a63e14a000000b005c67bb15866si8444484pgk.52.2023.12.12.13.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 13:27:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=flRSOrwL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id A703F8046BDB; Tue, 12 Dec 2023 13:27:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377184AbjLLV0q (ORCPT + 99 others); Tue, 12 Dec 2023 16:26:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377764AbjLLV0c (ORCPT ); Tue, 12 Dec 2023 16:26:32 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D30E5B3 for ; Tue, 12 Dec 2023 13:26:38 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBA31C433C8; Tue, 12 Dec 2023 21:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702416398; bh=7MZqk1hNPj7r4egGXbPOB+Rztv8D/+/C7L1c9OmJaNM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=flRSOrwLQ6Kc4Jr7ORRXvJ9GkwBbbqmpb4qM7hK2Pq5Mo+ix+PgPwknWPbsyLrJk5 ATqdQHydWfdFqN7c1//tDtxjet1++b4i1v5AH8a+DDpq4uEldVokQHHzyzTEu4snaE PHEte5nKs1RG9Td3XkE5pZDvwXd0Al1n19rkQeezl55Mbx636qHNcj2XAigiLYP5I1 8nZMz9R8VtlS6dMY91F5MT1dyZv+mBHsFOeajqHZy8Z6jSX/NyTnzzkn1GuOQEALCY ujUJz7wtIS2l3TqBZ3cA72Q3XKBddfCGVKWrrvtxdIiQR7WlXf2k+1Tju5sYYLA2Mm J5FjKLntIkB8w== Date: Tue, 12 Dec 2023 13:26:37 -0800 From: Jakub Kicinski To: Kunwu Chan Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, jacob.e.keller@intel.com, przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kunwu Chan Subject: Re: [PATCH] igb: Add null pointer check to igb_set_fw_version Message-ID: <20231212132637.1b0fb8aa@kernel.org> In-Reply-To: <20231211031336.235634-1-chentao@kylinos.cn> References: <20231211031336.235634-1-chentao@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Dec 2023 13:27:06 -0800 (PST) On Mon, 11 Dec 2023 11:13:36 +0800 Kunwu Chan wrote: > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. > > Fixes: 1978d3ead82c ("intel: fix string truncation warnings") > Cc: Kunwu Chan > Signed-off-by: Kunwu Chan The allocation is rather pointless here. Can you convert this code to use snprintf() instead? -- pw-bot: cr