Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4928688rdb; Tue, 12 Dec 2023 13:28:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyZx3vgsXI5LjBkzbkWldINXOvsCQCOvG9L3kb8nWIcvVZ/ABhkIMBffdQ0x9AUz+06f81 X-Received: by 2002:a05:6e02:154e:b0:35f:6c6b:abd9 with SMTP id j14-20020a056e02154e00b0035f6c6babd9mr755779ilu.32.1702416513851; Tue, 12 Dec 2023 13:28:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702416513; cv=none; d=google.com; s=arc-20160816; b=BPtllRqFAWXjqkFTHJLniHYhUWAMX90ZzuIGm0THGeWUYhjXHeVbgoe6UBRfOkoq3C xlJ0kLaUYO8tHyWyTtMajUReZWvapx9QpI3c5m0QLLpZcXXy5WXeIGChMc2yJVN53oT1 KXCVKjVDVL6ebdlyQF01rPyp1bUi2Sr/qZl6khOx8DvzixFwdjQ3DFjuKjucT4pjTCCm v+9VsDjYYTZLtWgC/I0w+OYHFKzwQPvYkbCgB0/X7PEKn7yCQKIDIlNhW8OkXWidZMEv Y7JE4TI3duk+YEFzWUOb3X4FY7SuAKE/iaNEa6mFyOm+CobXZsr3n8l9aWcs/0n3+Q1L PFVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=oiS4m9p+IQvl+5n8wGQMkKKhnjn7pZ4WSP2spW8Q/Po=; fh=qE9iOhRxSInRzx4xEaIbXw027h0F+jIerm/HAAnzH8U=; b=K0TWoNg9lagZ1JFLRgpzzDHVzNyxw5moVhQq6FV3nftEcDMsesP8PyWhP2c7yq/n6G /2Jua7zidSx7wx6NOaWFZzcQ1ga4Yk4oRiV11vADMQXFCSY0zcv+e9q9bt77WiDN1ECG hXJhfvB0OVBanOlNEIQz43d1NhyQHDvuIuHzUVcJCSeLkFZPL6/1Gx/HpCLopT1r5gsw lsCH8Hgk62kQ2qChueaRlW7ORhBVU8191bc0hQCgNMunXxE7/AEKS3eUUgSW3R0qmUgy 3XQ9D+i/Eo6z88/hXHhfTR6ooi3U3mGoZqTuxoVRUhkB1Z4rDfdIC+LWv/+dI400fBjM MEZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cOoZS9ex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id o9-20020a655209000000b005c67e10f23bsi8529069pgp.362.2023.12.12.13.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 13:28:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cOoZS9ex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 393CB801C91D; Tue, 12 Dec 2023 13:28:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377406AbjLLV2Q (ORCPT + 99 others); Tue, 12 Dec 2023 16:28:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235199AbjLLV2N (ORCPT ); Tue, 12 Dec 2023 16:28:13 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 070CB126 for ; Tue, 12 Dec 2023 13:27:56 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14121C433C8; Tue, 12 Dec 2023 21:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702416476; bh=50sFTmtihceq90x+RGmpNwjBeohVEhFnNKDvNFakuCA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cOoZS9exiz+criCcYP/hy4pMCbxjVobEJPVZikpnLMiLu9+LcCWBzWPi4aTIDBXgc dSuTTDVXilOpc5MPdrnDKrT0+u8QHqj4d8uWVNQl/c9XwjMxtkutTKKLnnXZfAdDTU bo2A7ur6ykv92o4V0uNuKAc5gyTi759qgkJdhJHffc1XdriqXESYHJ3Objhp2J6TY6 3EJpTob+C4Y/YOylS/2shzOmc24laqtXsrKFepI8VhrfUJUK5f8QyxnW4eCkidKqKe lGmNtWKTd18InnWc19jXiik5Xtzg/VJQS+EPeW6TSrKPdzqD7qAwd+UcNiOJrHYofr UdTCg89/aKllg== Date: Tue, 12 Dec 2023 13:27:55 -0800 From: Jakub Kicinski To: Kunwu Chan Cc: andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kunwu Chan Subject: Re: [PATCH] net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe Message-ID: <20231212132755.261ee49d@kernel.org> In-Reply-To: <20231211024549.231417-1-chentao@kylinos.cn> References: <20231211024549.231417-1-chentao@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Dec 2023 13:28:31 -0800 (PST) On Mon, 11 Dec 2023 10:45:49 +0800 Kunwu Chan wrote: > vsc->gc.label = devm_kasprintf(vsc->dev, GFP_KERNEL, "VSC%04x", > vsc->chipid); > + if (!vsc->gc.label) { > + dev_err(vsc->dev, "Fail to allocate memory\n"); > + return -ENOMEM; > + } Don't add error prints on memory allocations. There will be an OOM splat in the logs. -- pw-bot: cr