Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4928899rdb; Tue, 12 Dec 2023 13:29:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfXh6lPVCVC/iywSfGrtBEqt2JX8EqiO3YFIsdWVdMDlHAgjoVRJ90OxL7NU9/KimowrTY X-Received: by 2002:a17:902:efcd:b0:1d0:bcb2:b910 with SMTP id ja13-20020a170902efcd00b001d0bcb2b910mr6409160plb.123.1702416543922; Tue, 12 Dec 2023 13:29:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702416543; cv=none; d=google.com; s=arc-20160816; b=g/qnPaqRIEYOl5+iYiZwqRfmKA1T7jdW4VCFPBO964nN87jY5CEK91mYD3ymSWDz6/ 4WOXx3KQey4zsiOynvODXBHbafB7ubpBhsPXlld93TiynMK+exLt9Ap0ZeGzgrxVgWyY AQSRBR+9bvOcUzVLAjIpIztGkv+W9u6r1+81TqctbYo6KaZhTvSIpVTqBv/+VIUtkYXY h+JQIRK32CW6SZoXDtk2XEYVp9cVW2JxncQvS7rubdNt+DVj3SKPG7Vghjzt9k2p0qcm yAeyXJE2u7QyhL5UyMC+RVEQNZftQ+nWjFcPWh+zsPQqvpG1wYfx+HtrHCJxHWTojWxA zzvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=6iaZPdTFgqmI4e69wyaZF4J3L1N7Bfa7UECGZ8SAPek=; fh=BL3QPvt2giMGcIhWB6xImQ8WRfFfH/24QgxgASZSnV4=; b=0PJn4BjVFYYICbyAMzFSQzdeeqokA6x5fpaxTpwjxjqWGztGSCRd0eADPQOHw0JwtL 82ndXVcbJdDu0l1+m8LZOEYq3I1QnYjtYmMIB/wH/OySGcoToPM+Fi1gc6ZqiOUF+iw7 +NH0ZunT7ZqYrtQMCQnOpInBPcKV0aHe5/azJeTC33HN+T+7kT4g7KNUEd3BiaNMhs3/ w6+p5xYN1xEDZeno853lVTLwgMiXLVRvMuEO6FpS7j9lNuIgPbSTPQvDK8T7fZps7jw3 2U0nQEU24gYrVEof26WSgu6TdCp81c3csWXas05TzRbCCOAsXirbSHdG2d3wbCVRdiTm 881g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RcEo5PtV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id 6-20020a170902c10600b001d003f4a193si8232869pli.384.2023.12.12.13.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 13:29:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RcEo5PtV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id B43EF810756E; Tue, 12 Dec 2023 13:29:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377433AbjLLV2s (ORCPT + 99 others); Tue, 12 Dec 2023 16:28:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377406AbjLLV2r (ORCPT ); Tue, 12 Dec 2023 16:28:47 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF83AB3 for ; Tue, 12 Dec 2023 13:28:52 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CDA9C433C7; Tue, 12 Dec 2023 21:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702416532; bh=7g23NbUaG9IocrYKtfcJQkcARBOL/6cB9B3IBOO179w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RcEo5PtV4dcAiaQiaiYd9nV1ggHqQ2IfUnP05wzeW+Exw/eoKMP0vUwUlK+ubJvFm D7kgFLDhvfVL3xvjQzuFVEDI5tENiXmEq6M1OxK74Y+wAh/DOuK4XPs9a0VpSGAIUD i5IF/Az+XIJYBNC9C468l2agnMAnC8MrxjHg0h6riZL/zzzKFtO58KCnhPa1M+FkWm O72fM02HcAHtEEmUIzDrYIiFJzKVwvVmc5xd9E0gmajxplF6jVUAlHY9I2GmfQkAZ1 yGOsAKJjb/MtAJNIkGIpIb7pPD+2DwJXDOTrr3EE6r4MxjJ8C9BI/YIT8t5zkNRkRQ 8/rovDm3IMRZw== Date: Tue, 12 Dec 2023 13:28:51 -0800 From: Jakub Kicinski To: Kunwu Chan Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, jacob.e.keller@intel.com, przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kunwu Chan Subject: Re: [PATCH] iavf: Fix null pointer dereference in iavf_print_link_message Message-ID: <20231212132851.59054654@kernel.org> In-Reply-To: <20231211025927.233449-1-chentao@kylinos.cn> References: <20231211025927.233449-1-chentao@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Dec 2023 13:29:01 -0800 (PST) On Mon, 11 Dec 2023 10:59:27 +0800 Kunwu Chan wrote: > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. > > Fixes: 1978d3ead82c ("intel: fix string truncation warnings") No need for the allocation here, print to a buffer on the stack. -- pw-bot: cr