Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4934551rdb; Tue, 12 Dec 2023 13:42:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcCazW0A2COHVpDbxv+xsYo72zXl7xd1eGJi4AKiIYVxJi15Ye8IhtXKLB4HOgTERxPVmR X-Received: by 2002:a05:6e02:1e08:b0:35f:5366:51d0 with SMTP id g8-20020a056e021e0800b0035f536651d0mr5425889ila.69.1702417354627; Tue, 12 Dec 2023 13:42:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702417354; cv=none; d=google.com; s=arc-20160816; b=i9nsOdVckpKlIoVjGfIJ3RV7DM6Zvia7cl5SrRx520LWIbyDXpF9mKHSdT/vNKVTyl Rp0+eLrDha8IvAz3bc9X1wOZ3SQ35p1tumPCxu5SqiFwnMYg90QFNrEFbij2W1QNgADS FQMswcrGFhCeN/E6Nkx83x04ihcn5yaAkRMR3vnYwH1dY/BAz8C3QpbJFlvZgpumdz+C jMT40F21qSCx7qzyi04XVC7EA3F+jL0lLUy+7M84NjCgxr3l5B4GA7oW19TBvVkbw/Tb vm4aVJEenWVEzKy70Tndk18DU4JCcLaFYMQd4d7QL6hqvxYeDFdfSrhzkW/kHz1qeajM hesw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=Znqz6aHTY8JPFnwZYYOPnpComo9EgoWotl7261O33K8=; fh=jIQlCq2Vs88P8e3fU6WFZZnbscd7PqSxOK700b+S2bU=; b=G+x46SeYqOEuA1gLFIIyHr2vjsuug588aG9sCND18qWp1mVUM0GOFEaaIdNLAhlWVx kpxpr2bh03MlgibxZR4rHEhlYgaGxd2HFur7uonTnW/XQvacmbcfJejJIs4qlmk6nJnM u3JLXFBI4Q156SZIpwDrsuHLOILQe7Zw4obDii32IJuuXLfJ0IJCXJyzpdzjGkq/HP6M JtM/qjQOgiYnpnEIct0jBLIqQWUQ0ZDDm7qUxJ6c9MzlR6IFjgpYS4PG5SeTzJnaUcoc CClUI3cJhgT76cB4USGC6kGryLCUAb5k5NClBILzObMoeiVLgobbYWdGmwojZ9b5vMtO 7VFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="F/htd/Te"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id j64-20020a638b43000000b005bd11902100si8558232pge.840.2023.12.12.13.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 13:42:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="F/htd/Te"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 431AA8022EA0; Tue, 12 Dec 2023 13:42:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377189AbjLLVmS (ORCPT + 99 others); Tue, 12 Dec 2023 16:42:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377185AbjLLVmR (ORCPT ); Tue, 12 Dec 2023 16:42:17 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2CFDAB for ; Tue, 12 Dec 2023 13:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702417343; x=1733953343; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=cBEiH+vzaiQu86et3AisJJ8pnYlKgefFUdxSvsrRMrk=; b=F/htd/TeS/Wc8B4rxjrOUHHJ+Wd32EaDFB9XB8bCBzmNoTRD6DAh8bjB fy+m48ZGoWPEh3D0xgLwzTvKo3yRDWKD16cKOA9aWD1O5vtWOUOkwNPeo h3+XwxWeX9bWbEurkUggSaxgGgWTVwRpbPbGWIv35PlIEAdtXkIo/qvOq 99RDY12II2BSNkGxxKLMrCmFLgsg/pYJNC6+Vu32SxrpVvK38ErCS5mW+ xH3WoCNghFNmqlOpaAWZSt0cpNNNSSOiy3egR+FeSCVdwTcCmf/WqPB4U 7P7IKvYQxwp0wIwrkDNiofiRqr55w1DN0ZxXRb99xG6JogriTZ9KlgHXI g==; X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="425996817" X-IronPort-AV: E=Sophos;i="6.04,271,1695711600"; d="scan'208";a="425996817" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 13:42:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,271,1695711600"; d="scan'208";a="17648638" Received: from rlsparks-mobl.amr.corp.intel.com (HELO [10.209.59.101]) ([10.209.59.101]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 13:42:11 -0800 Message-ID: <39cf0ad5-bbef-4fb9-81a3-9d2891cc7450@intel.com> Date: Tue, 12 Dec 2023 13:42:09 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: tdx: hide unused tdx_dump_mce_info() Content-Language: en-US To: Arnd Bergmann , "Kirill A. Shutemov" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Yuan Yao , Kai Huang , Tony Luck Cc: Arnd Bergmann , "H. Peter Anvin" , Isaku Yamahata , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org References: <20231212213701.4174806-1-arnd@kernel.org> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20231212213701.4174806-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Dec 2023 13:42:31 -0800 (PST) On 12/12/23 13:36, Arnd Bergmann wrote: > From: Arnd Bergmann > > When TDX is enabled but MCE is not, the tdx_dump_mce_info() function > fails to link: Thanks for the report, Arnd. The only way that TDX has to report integrity errors is an MCE. I'm not sure it even makes sense to have TDX support but not MCE support. Maybe we should just make TDX host support depend on MCE.