Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <0d1183a7dd64d74c91ad15e2a4b2102f056a858d.camel@linux.intel.com>
Subject: Re: [PATCH] sched/headers: Remove duplicated struct rq declare
From:   Tim Chen <tim.c.chen@linux.intel.com>
To:     WangJinchao <wangjinchao@xfusion.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        linux-kernel@vger.kernel.org
Cc:     stone.xulei@xfusion.com
Date:   Tue, 12 Dec 2023 14:26:44 -0800
In-Reply-To: <202312072018+0800-wangjinchao@xfusion.com>
References: <202312072018+0800-wangjinchao@xfusion.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-12-07 at 20:19 +0800, WangJinchao wrote:
> `struct rq` has been declared at the top of the file,
> so remove the second declaration.
>=20
> Signed-off-by: WangJinchao <wangjinchao@xfusion.com>
> ---
>  kernel/sched/sched.h | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 2e5a95486a42..349c90554bd8 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -931,7 +931,6 @@ struct uclamp_rq {
>  DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
>  #endif /* CONFIG_UCLAMP_TASK */
> =20
> -struct rq;
>  struct balance_callback {
>  	struct balance_callback *next;
>  	void (*func)(struct rq *rq);

Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>

Tim