Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <b3c71b866bb249107ed2920e31a7ec185b2f0b15.camel@linux.intel.com>
Subject: Re: [PATCH] Documentation, mm/unaccepted: document accept_memory
 kernel parameter
From:   Tim Chen <tim.c.chen@linux.intel.com>
To:     Vlastimil Babka <vbabka@suse.cz>, Jonathan Corbet <corbet@lwn.net>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Date:   Tue, 12 Dec 2023 15:10:07 -0800
In-Reply-To: <20231212-accept_memory_param-v1-1-a9012402b887@suse.cz>
References: <20231212-accept_memory_param-v1-1-a9012402b887@suse.cz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-12-12 at 18:21 +0100, Vlastimil Babka wrote:
> The accept_memory kernel parameter was added in commit dcdfdd40fa82
> ("mm: Add support for unaccepted memory") but not listed in the
> kernel-parameters doc. Add it there.
>=20
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>=20
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentat=
ion/admin-guide/kernel-parameters.txt
> index 65731b060e3f..3a4ebb46073c 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1,3 +1,13 @@
> +	accept_memory=3D  [MM]
> +			Format: { eager | lazy }
> +			default: lazy
> +			By default, unaccepted memory is accepted lazily to
> +			avoid prolonged boot at the cost of some runtime

Suggest rephrasing this line. Breaking up long line makes reading easier.

avoid prolonged boot.  The lazy option will add some runtime

Thanks.

Tim
> +			overhead until all memory is eventually accepted. In
> +			most cases the overhead is negligible but for some
> +			workloads or for debugging purposes accept_memory=3Deager
> +			can be used to accept all memory at once during boot.
> +
>  	acpi=3D		[HW,ACPI,X86,ARM64,RISCV64]
>  			Advanced Configuration and Power Interface
>  			Format: { force | on | off | strict | noirq | rsdt |
>=20
> ---
> base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
> change-id: 20231212-accept_memory_param-4a7adc5e5582
>=20
> Best regards,