Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <fd5e2d54-1309-48a9-8458-ee5f2ebb039e@infradead.org>
Date:   Tue, 12 Dec 2023 15:55:41 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] parse_phat: Add support for ACPI PHAT Table parsing
Content-Language: en-US
To:     Avadhut Naik <avadhut.naik@amd.com>, linux-acpi@vger.kernel.org,
        linux-edac@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, yazen.ghannam@amd.com,
        avadnaik@amd.com
References: <20231212195219.2348858-1-avadhut.naik@amd.com>
 <20231212195219.2348858-2-avadhut.naik@amd.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231212195219.2348858-2-avadhut.naik@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 12/12/23 11:52, Avadhut Naik wrote:
> ACPI Platform Health Assessment Table (PHAT) enables a platform to expose
> an extensible set of platform health-related telemetry. The telemetry is
> exposed through Firmware Version and Firmware Health Data Records which
> provide version data and health-related information of their associated
> components respectively.
> 
> Additionally, the platform also provides Reset Reason Health Record
> in the table highlighting the cause of the last system reset in case
> of expected and unexpected events. Vendor-specific data capturing the
> underlying state of the system during reset can also be optionally
> provided through the record.[1]
> 
> Introduce support for parsing, decoding, and logging the PHAT table, if
> supported by the system. By default, the table will be logged to stdout.
> The same, however, can be changed through the "-o" command line parameter.
> Additionally, the tool also provides a hexdump of the entire table, if
> needed, through the "-x" parameter.
> 
> Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
> ---
>  Makefile     |  12 ++
>  parse_phat.c | 516 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 528 insertions(+)
>  create mode 100644 Makefile
>  create mode 100644 parse_phat.c
> 

Does acpidump not parse the PHAT table?
Could it?  Should it?


thanks.
-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html