Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 12 Dec 2023 16:17:00 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Shiju Jose <shiju.jose@huawei.com>
CC:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH v2 7/7] cxl/memdev: Register for and process CPER events
Message-ID: <6578f7fc4e04a_22539529429@iweiny-mobl.notmuch>
References: <20231211-cxl-cper-v2-0-c116900ba658@intel.com>
 <20231211-cxl-cper-v2-7-c116900ba658@intel.com>
 <657897453dda8_269bd29492@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <657897453dda8_269bd29492@dwillia2-mobl3.amr.corp.intel.com.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tfSacMdk0WE/U0aRvoKJbH5zV8fa2GqCpWsRT0MjtgORYWIl2++HovJSZshP?=
 =?us-ascii?Q?LAsOp5KsQV7OGu3FXfOj+yw7/Wi3P3GBG7AFPt9Ew9N4w7EfJ1JAYKqLrzIz?=
 =?us-ascii?Q?K0hQSFyS3ClvyeO6GiiOTyBDeHdKkXP8ApQ66iAY1Q41MNMWjYn93TZ+dwjE?=
 =?us-ascii?Q?sdkKLoMasjYd3dBwwEWv8eVxeKvEVPEQ7C2lhD0yZNm4rfDSr7HIKOLlxHPG?=
 =?us-ascii?Q?6MiQMHklmuxWCMBiDnD8ch0/D/l6mN7sPBhk1sWZy0nq1ju2KXXQxhLmy4rt?=
 =?us-ascii?Q?muss/2tiALjLatbdbzHiqmO4xhxvYSN3bIqQ/1gRvC9Ppi1ffHIY2OPZIIVO?=
 =?us-ascii?Q?yLPF6cKeXhhRPytF+00tLEIacAC8H28ujetZq+esKFbBVADB5e3oG7rJAehX?=
 =?us-ascii?Q?scFkHcOBw2nuohfrhuGhJ5qzOn9lBkSR8b2af2CknWOzaznDdq8q9tulZlaH?=
 =?us-ascii?Q?rVPtH708k20QiJoqzMJAMr6Ey5oFEJQuy3qVQorYOkFdUYXKDrfBs2NeSNsy?=
 =?us-ascii?Q?Fl6iKextO0Ue+nmFvGEU1dthHOFUt2+32+eeXrNentxYbEYxtvZu+KtRM6xh?=
 =?us-ascii?Q?2qTollfyBMBWGEXaQ1WS7ubRbB1m+3PC55FZau9EA8gnLbG8x3OpmXY2JQAb?=
 =?us-ascii?Q?j/iax13+pqmrh2oBXfl+BVqGEgcV8cSjW12IUSOFcS7CPeLsNjSlBCI8JJf/?=
 =?us-ascii?Q?g30AWHw0FbfwGgITQaqarmiv6JPu5vmVIFcvNSiK63xGF+gSth8wqVFna313?=
 =?us-ascii?Q?pKIgIwZeCgDWXr5KZxzk8cueYymrL0+wT/ACAQxR4/x83IAinlr2MAiJTn8b?=
 =?us-ascii?Q?kQEydJPi41Jnb3vyHNupAUzKw8OPPvIiOA8MUsu/OsG6DGyoM27NgZL+CXuf?=
 =?us-ascii?Q?RQZ6gi+Qq8S9m8/wnFkqsk92u4aKHFEaIkao89XzcjL2rmpLQZTwzGhQF0TK?=
 =?us-ascii?Q?kS2GZO0Yar4X/Mg+MunbOW7rqvou68mKIQNE20ls/wLbAVIAJLBUw9Y0U2yP?=
 =?us-ascii?Q?dbCr/NO06QWn+piKpZc5E+DRDw2awh+g4JEOJmOr0PS4bys8Ut5ALKGJoXGC?=
 =?us-ascii?Q?g0xye/bCR4yTrpeI3I9pDhcdoNgyI3sQqQ8QTwDBFLXKRrRr/0+z9qVzz+MG?=
 =?us-ascii?Q?4q4SenOAx7Em0O8SR/05uDq/mxo+K6sxKbU2sQc0fy4P9s2yQjYs0VtT7C+Y?=
 =?us-ascii?Q?k7weworVL3LsPsgtJPDdXYLJXDpcY4x3Ada0WJnZW2yX5RAjqfBdx8LxWV9p?=
 =?us-ascii?Q?T6NbMp2BPyB9ACtzzvr7j2xHjHGfJHuYMceCrMlFlTN3+bDTEA75DYbn/+8I?=
 =?us-ascii?Q?hbFbLzwNhNsTdM9ljTP3Wu/BD7hSt4rWf2peAwp+7Pl7QTRrLsEwgjQ0SZfT?=
 =?us-ascii?Q?S9jAihiP9clX41mpvDuXD7C3Jhl1Z9Veijf4mmrhkfrXZi5qhSwjfx0i4Yc7?=
 =?us-ascii?Q?gdY3m8h3gZBXifm8X8dBn6e5cp54dCRSeTp0mQF/pJa+L4nQ6knHhHID/FDk?=
 =?us-ascii?Q?lUNFTXT9+qLMw8JQGQSnHs+PlWHEdPb7P+0I0pVHf6PlQbaT713DAOJ2m8FM?=
 =?us-ascii?Q?xwxqjXXAixVCb9+N3/6cZAXUH9y+1qRqZNYEKQMD?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd86c513-6bcd-4547-5fce-08dbfb70d5fc
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 00:17:05.0118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zi0szGGTpOWAX20dT3DCWBMQNF9OVDA6KDAYAsEINm0kKUEXAInhlh6PU8qNbk6qvdPtpGnBSR6T/ghBc8Qfqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7201
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Dec 2023 16:18:26 -0800 (PST)

Dan Williams wrote:
> Ira Weiny wrote:

[snip]

> > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> > index e5d770e26e02..7a891b4641cc 100644
> > --- a/drivers/cxl/cxlmem.h
> > +++ b/drivers/cxl/cxlmem.h
> > @@ -481,6 +481,8 @@ struct cxl_memdev_state {
> >  	struct cxl_security_state security;
> >  	struct cxl_fw_state fw;
> >  
> > +	struct notifier_block cxl_cper_nb;

delete this...


[snip]

> >  
> > +#define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0)
> > +static void cxl_cper_event_call(struct cxl_cper_event_data *ev_data)
> > +{
> > +	struct cper_cxl_event_devid *device_id = &ev_data->rec->hdr.device_id;
> > +	struct cxl_dev_state *cxlds = NULL;
> > +	enum cxl_event_log_type log_type;
> > +	struct pci_dev *pdev;
> > +	unsigned int devfn;
> > +	u32 hdr_flags;
> > +
> > +	devfn = PCI_DEVFN(device_id->device_num, device_id->func_num);
> > +	pdev = pci_get_domain_bus_and_slot(device_id->segment_num,
> > +					   device_id->bus_num, devfn);
> 
> What if pci_get_domain_bus_and_slot() returned NULL?

:-/  yep.

> 
> > +
> > +	guard(mutex)(&pdev->dev.mutex);
> 
> Lets not open code this since device_lock() is so prevalent it deserves
> its own guard() type:
> 
> DEFINE_GUARD(device, struct device *, device_lock(_T), device_unlock(_T))

Good idea.

> 
> > +	if (pdev->driver == &cxl_pci_driver)
> > +		cxlds = pci_get_drvdata(pdev);
> > +	if (!cxlds)
> > +		goto out;
> 
> Lets not mix usage of cleanup.h helpers with usage of goto. The helpers
> are there to eliminate goto errors. Just add a new helper:
> 
> DEFINE_FREE(pci_dev_put, struct pci_dev *, if (_T) pci_dev_put(_T))
> 
> ...and declare @pdev as:
> 
> struct pci_dev *pdev __free(pci_dev_put) = NULL;
> 

Even better idea.  Done.

Thanks,
Ira