Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Tue, 12 Dec 2023 16:27:15 -0800
From:   Josh Poimboeuf <jpoimboe@kernel.org>
To:     Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Cc:     Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Make objtool check actually fatal upon fatal
 errors
Message-ID: <20231213002715.w5cqo5ataaevivop@treble>
References: <20231212185339.1562967-1-dimitri.ledkov@canonical.com>
 <20231212203031.uudk57xhegi5yziz@treble>
 <CADWks+aDuPcwmOCSmnQ4T-mKZ-N55-L+cS1ww2huEAXQnc_q8Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CADWks+aDuPcwmOCSmnQ4T-mKZ-N55-L+cS1ww2huEAXQnc_q8Q@mail.gmail.com>
Precedence: bulk

On Tue, Dec 12, 2023 at 08:39:30PM +0000, Dimitri John Ledkov wrote:
> Well, I'm hoping to add --error option next, and yeah, make warnings
> fatal. Or for example at least make the retpoline, sls, rethumb ones
> to be fatal - because i found myself in a very surprising situation
> where retpoline enabled build of kernel, had non-retpoline paths
> remaining and not otherwise silenced as safe.
> 
> Maybe I should finish that second patch and make it available as a
> config option.
> 
> At least right now, with Ubuntu Noble (development series) and
> v6.7-rc4 everything is squeaky clean to enable CONFIG_OBJTOOL_WERROR=y
> and make all warnings, fatal.
> 
> Also i think having it as a config option will result in various
> automation tools able to flip it on, and submit bug reports when
> something somewhere regresses.

Right, the warnings should never be ignored.

I agree we need CONFIG_OBJTOOL_WERROR.  Problem is, upstream supports a
lot more than just Ubuntu configs, and there are several outstanding
warnings, reported by both bots and humans.

Fixing them is on my TODO list, it's just that other things are taking
priority.

If we introduce CONFIG_OBJTOOL_WERROR now, build bots will start
reporting build failures and people will start complaining more loudly.
Without more help I'm lacking the bandwidth to stay on top of that.

-- 
Josh