Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <333bf7dc-7a87-438f-a4dc-fc5e254ae049@amd.com>
Date:   Tue, 12 Dec 2023 18:48:25 -0600
User-Agent: Mozilla Thunderbird
Subject: [PATCH 1/1] parse_phat: Add support for ACPI PHAT Table parsing
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>, linux-acpi@vger.kernel.org,
        linux-edac@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, yazen.ghannam@amd.com,
        Avadhut Naik <avadhut.naik@amd.com>
References: <20231212195219.2348858-1-avadhut.naik@amd.com>
 <20231212195219.2348858-2-avadhut.naik@amd.com>
 <fd5e2d54-1309-48a9-8458-ee5f2ebb039e@infradead.org>
From:   Avadhut Naik <avadnaik@amd.com>
In-Reply-To: <fd5e2d54-1309-48a9-8458-ee5f2ebb039e@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlZ0R2RXSmtxOWk0VUh4SWl4MUVScGVwNWxyQjFmcDRaVGNKRk8rMGNIclQ1?=
 =?utf-8?B?K1JKSzgvbnUyVVhlY3VOUnI0OU5yU2JlMGJNQW8zOWFuWkJlUG0vQU5ETUlR?=
 =?utf-8?B?eTdZVjRjVkhLY0w5aWZvcENzdlJnRkVVQUloUzNTdVNlYWNzZHlBRmVRMVdH?=
 =?utf-8?B?M29VMlFPalF3VDJuUmNrZlU1eU5rUUV5ZHpjVjM4WHRiR09uZklUODdxOXl6?=
 =?utf-8?B?V2pUbEpabEdkYUtDNnRTVSsrSmtuNVRJK2JTMGQzdXI4SDQvSS96UTdSbGFH?=
 =?utf-8?B?bWlDNE9pQlBxVm52Yk9PREYxNXB6RGEvL1F1N1NwM3FZQ3ZwbjZlY2Q1alQz?=
 =?utf-8?B?aGc3WDV3RVRLM29KWGVDVWkvaWEyU3pQcVMxWEo2M0JuNXlzRll1VVd1U2o2?=
 =?utf-8?B?RENSUzZqV2JVVVY1UUVkTDBIbGo2YzZDTzRFNmlvQ1lja2RobUtOUkl0dWVh?=
 =?utf-8?B?ekVPNHpnMXJLYWJVWDgzTysrUUU2bHgydWRUdjhpSjBpTE1Ga1A5ZWFnWjJ3?=
 =?utf-8?B?OFAzOE80TlJjMWJwWXgzMGp3Rjlyam1aRVFIL0QrWUZQZFhrdkd0Z2FVUHNC?=
 =?utf-8?B?MTNNWWcwckVkR1NVTXRqdHE2cy9xeUZkS0FGVCtGTlBFc2hHdVVycitlQ3pm?=
 =?utf-8?B?UitzWE4zNlZob0dSeXI5Z0t0UW9NdUpRSnpEbndhbGY2MXN2TWVwSTIydUla?=
 =?utf-8?B?UnFTdm9tUUpWalAydlREM0NPTGozaG5YQTBPQmFvT1ljY05MQTF0YlcvcWlN?=
 =?utf-8?B?cS8vVkh4V21mY1MrWVdoQkMvaW5GTXJyVzJXWU81NHNHMkN1UHZBYm5yV0F4?=
 =?utf-8?B?b0xrZTFhY05uaWVXbGtqcG5WSk94S0FOanVSSkgrUlJ4ZkdubVJoaGNlY1hh?=
 =?utf-8?B?RkpURGVLM2VtWE5udUs0RnZSdUFKU3ZHeUQvMUE3WFU0RFgySkl0a0UyemJa?=
 =?utf-8?B?a0grbDl4eFdXbzZsekQxbk1pWStOeXBTQktIM1RVVWxGTnRUNDR5TktWc1k4?=
 =?utf-8?B?aFE0cXhuT3R1dkpad21DRDd5RkZTYlE2WU9XUFVodTdtQlVzNHZLUDZZdmE1?=
 =?utf-8?B?QnUwbkx6bDVreGZsSm9jYTZPekx3UXpKcld1dHJ4VnpYd29TQkdXR0pTKzV5?=
 =?utf-8?B?K2xMMnY1WDRITEFycGliWndBbGt6RGlCN2hUK0swdngySGlPc0tha0dSMFJ5?=
 =?utf-8?B?TXBtR3U3TThUSlF1cmRQR2VpQTdhdUt3RFhDK05XT0xkTnJtSE93dmNlODVT?=
 =?utf-8?B?Vm1MakhNMTFDT09YM3BtU1JXdHJycWlRTXp0bnJiTkJGZU52TjNOOWZEVXBJ?=
 =?utf-8?B?Q1J4dUNvQ1FkT1pRMGhkQnJwTGdFZzRmYjZDWXJkN3hMY0pyRGplR3ByTW56?=
 =?utf-8?B?NVNpR2djZFNzSjJJM09YRG45bElVWTJTTEp0OUJOUVpleG1Oc0w5SmJUM1ZK?=
 =?utf-8?B?TDY0Ujc0NkZWN2JveXhvVTFOQTBXdEFKWWRkR080aGp0ZUdDOW1sVk1YWmdm?=
 =?utf-8?B?MUFYejQwMXdxU1hHcVRLWlUvSWxFZlRzUEhaVitTcmszZ0VhT3h3alhVYXhX?=
 =?utf-8?B?OS9JTmwxdU5jcDRsNG91SURvVFZSNlh0clhrRmkrMzFVMHFORWZleW1nOTBC?=
 =?utf-8?B?aHc1Q21ORjNERmt3a2F2TEphc09rR05kZ2IxaGp2YnZvNjZnRzhUVUgxNDNp?=
 =?utf-8?B?bnJCQm1NL3krTjl6K0dwZGs2THA0UkRaQmtlbGJWUFQzL2dITFBiRkhBblFV?=
 =?utf-8?B?YjQyZkVOdXZ6NjR4OTVUdGppU2l4aU5sb1pGUzJTUFJUY0doLzJPRTlJL05G?=
 =?utf-8?B?M2wrekxYa0o3ZytLUUU4Z3YzSWFrcVNpYjdZSDVnSnhBK1hwdURiOG15aDJJ?=
 =?utf-8?B?Tmc5dC9PK0YrQVpKYnRUYUJKRS8xR09NRG9FUmJSMHNQcmVUaEZMK1NlYXpp?=
 =?utf-8?B?V2tzUFBPRDZndWF5OVBGdnlKSG5UWkZRTEQyMm5RUmVVc29zTFJqR2RMOVlo?=
 =?utf-8?B?L0NzTkZ5WTFlTkxDOXFjNVc4OWY1VVlQc1FJZ1BPT0hBYWxPck9OcTU4RVE0?=
 =?utf-8?B?V21iSnBHazJZSElEUnZIS3NQb2x1MndLb2NISjdIMElJR2hmbWRKaTJmbTd5?=
 =?utf-8?Q?HalXraVk/Jd0lgY0K4y5dbONa?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdad2992-c602-4ce5-7702-08dbfb753848
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8403.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 00:48:27.8828
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0tykn0l1TapuyqI7mBsPvIRa0PtqgP9wmp+IZQixx3vIiVgvuw9ucASZwzdg1B9dCSdEFAGV6fgshANxr2MAiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5392
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 12 Dec 2023 16:48:53 -0800 (PST)

Hi,

On 12/12/2023 17:55, Randy Dunlap wrote:
> Hi--
> 
> On 12/12/23 11:52, Avadhut Naik wrote:
>> ACPI Platform Health Assessment Table (PHAT) enables a platform to expose
>> an extensible set of platform health-related telemetry. The telemetry is
>> exposed through Firmware Version and Firmware Health Data Records which
>> provide version data and health-related information of their associated
>> components respectively.
>>
>> Additionally, the platform also provides Reset Reason Health Record
>> in the table highlighting the cause of the last system reset in case
>> of expected and unexpected events. Vendor-specific data capturing the
>> underlying state of the system during reset can also be optionally
>> provided through the record.[1]
>>
>> Introduce support for parsing, decoding, and logging the PHAT table, if
>> supported by the system. By default, the table will be logged to stdout.
>> The same, however, can be changed through the "-o" command line parameter.
>> Additionally, the tool also provides a hexdump of the entire table, if
>> needed, through the "-x" parameter.
>>
>> Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
>> ---
>>  Makefile     |  12 ++
>>  parse_phat.c | 516 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 528 insertions(+)
>>  create mode 100644 Makefile
>>  create mode 100644 parse_phat.c
>>
> 
> Does acpidump not parse the PHAT table?
> Could it?  Should it?
> 
IIUC, acpidump will only provide a raw hex dump of the entire PHAT table, if present,
much like it does for other ACPI tables. The onus is on the user for deciphering the
hex dump.

I'd think that the parsing functionality can be incorporated in acpidump but not
sure if it should be. Would love to head from its maintainers, if possible.
> 
> thanks.

-- 
Thanks,
Avadhut Naik