Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231212214536.175327-1-arnd@kernel.org>
In-Reply-To: <20231212214536.175327-1-arnd@kernel.org>
From:   Guo Ren <guoren@kernel.org>
Date:   Wed, 13 Dec 2023 09:26:01 +0800
Message-ID: <CAJF2gTQckdn=uDfeLKu7wceOq7LT1KGJUT0vARMr9zUy3xc4xw@mail.gmail.com>
Subject: Re: [PATCH] leds: sun50i-a100: avoid division-by-zero warning
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Palmer Dabbelt <palmer@rivosinc.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Bill Wendling <morbo@google.com>,
        Justin Stitt <justinstitt@google.com>,
        linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 13, 2023 at 5:45=E2=80=AFAM Arnd Bergmann <arnd@kernel.org> wro=
te:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_COMMON_CLK is disabled, e.g. on an x86 randconfig compile tes=
t,
> clang reports a field overflow from propagating the result of a division =
by
> zero:
>
> drivers/leds/leds-sun50i-a100.c:309:12: error: call to '__compiletime_ass=
ert_265' declared with 'error' attribute: FIELD_PREP: value too large for t=
he field
>         control =3D FIELD_PREP(LEDC_T01_TIMING_CTRL_REG_T1H, timing->t1h_=
ns / cycle_ns) |
>
> Avoid the problem by adding an explicit check for the zero value here. Al=
ternatively
> the assertion could be avoided with a Kconfig dependency on COMMON_CLK.
>
> Fixes: 090a25ad9798 ("leds: sun50i-a100: New driver for the A100 LED cont=
roller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/leds/leds-sun50i-a100.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-sun50i-a100.c b/drivers/leds/leds-sun50i-a=
100.c
> index e4a7e692a908..171cefd1ea0d 100644
> --- a/drivers/leds/leds-sun50i-a100.c
> +++ b/drivers/leds/leds-sun50i-a100.c
> @@ -303,9 +303,13 @@ static void sun50i_a100_ledc_set_timing(struct sun50=
i_a100_ledc *priv)
>  {
>         const struct sun50i_a100_ledc_timing *timing =3D &priv->timing;
>         unsigned long mod_freq =3D clk_get_rate(priv->mod_clk);
> -       u32 cycle_ns =3D NSEC_PER_SEC / mod_freq;
> +       u32 cycle_ns;
>         u32 control;
>
> +       if (!mod_freq)
> +               return;
> +
Shall we need err_disable_bus_clk?

+ static int sun50i_a100_ledc_set_timing(struct sun50i_a100_ledc *priv)
- static void sun50i_a100_ledc_set_timing(struct sun50i_a100_ledc *priv)
 {
         const struct sun50i_a100_ledc_timing *timing =3D &priv->timing;
         unsigned long mod_freq =3D clk_get_rate(priv->mod_clk);
 -       u32 cycle_ns =3D NSEC_PER_SEC / mod_freq;
 +       u32 cycle_ns;
         u32 control;

+       if (!mod_freq)
+               return -EINVAL;

 +       cycle_ns =3D NSEC_PER_SEC / mod_freq;
         control =3D FIELD_PREP(LEDC_T01_TIMING_CTRL_REG_T1H,
timing->t1h_ns / cycle_ns) |
                   FIELD_PREP(LEDC_T01_TIMING_CTRL_REG_T1L,
timing->t1l_ns / cycle_ns) |
                   FIELD_PREP(LEDC_T01_TIMING_CTRL_REG_T0H,
timing->t0h_ns / cycle_ns) |
...
       return 0;

----------

+ ret =3D sun50i_a100_ledc_set_timing(priv);
+ if (ret)
+         goto err_disable_bus_clk;


> --
> 2.39.2
>


--=20
Best Regards
 Guo Ren