Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5029875rdb; Tue, 12 Dec 2023 17:29:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4Kuywov4ZX/B3iO3JgReydS0mA8bq+XBxsuOFxaGZ1+FSrTYull9Vk6V5k1Z1kEMYi2wG X-Received: by 2002:a17:90a:e544:b0:28a:d241:eea9 with SMTP id ei4-20020a17090ae54400b0028ad241eea9mr1064891pjb.82.1702430945287; Tue, 12 Dec 2023 17:29:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702430945; cv=none; d=google.com; s=arc-20160816; b=P8zdhRFfEnoJLpBDPpofJLSqBul6gSFJXottMPJIi9h9ErB1xw5vG9uGgbKuyAYeB4 XcgqqiY9IBUSwi3gnorrjJEAlq2QKJrjzoVLLCkvSzpv59MFCsI0nt90lnUa6+XLUadN 9RoT3fDIkW1z1+Hzz/lKX/pcav/y2xwf+HRV50nnhnrYZCJDtmUxvAZUdynrUJ7kNKQf gccoSpLbcVT1CxjX2QMnhH46f8iGbRhZ6tZcVivtWr8D+pcDQX/XEKesBrQmcM8iz/FT 97vQMUA7t1qaXaSnONbw3lEu8OAmMZ151DcYuBA1p5EZgh37WUWwxw2ZkHHVB8lZNAnf Xiag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=tbLF/xRBGFXTbCeNMbw4obwrMHh3RCnWbBeVvi5hy6U=; fh=zQ4KyqolXqQO+yNFGVuXxCeSvQq3rubOak+k9IB2PKU=; b=eG2g7P9s7dEMnOjFuMU4RGwUw1hz0+wutcYZIykdRryOheZAMHdMaQjnKmCWV7VbF/ gzZgUMPbKiMCQo4n30571RgB7D7c8++yNX5T+jYnTmhCIaoXm1YsjFcTqVnp6QS0c+L5 oQYGPI1yH0/yH6hDcsgKNA2L/+WoK+Ct8aPtoW2486Nx7X3H5/44eG91/9B1OYlDd3iU VrKl/0qreWa11PA82tcUqedzcD/jwL235dhT6Z/5DjrtT08X7e5Fp5dsQ0x7G3v8kMt0 cPyBAOHfBYuOQMmPZQTkXF/19LccCKWLmHPI5A511eJVOQmdzaSQi6uog1LK67BYxZB4 qD/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uAlEUEW5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id 60-20020a17090a09c200b0028659d5fb6bsi10179707pjo.143.2023.12.12.17.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 17:29:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uAlEUEW5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 3B0BF80465C3; Tue, 12 Dec 2023 17:29:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378167AbjLMB2t (ORCPT + 99 others); Tue, 12 Dec 2023 20:28:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378145AbjLMB2s (ORCPT ); Tue, 12 Dec 2023 20:28:48 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28957A7 for ; Tue, 12 Dec 2023 17:28:55 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AAF7C433C7; Wed, 13 Dec 2023 01:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702430934; bh=WHT7yhKML4b47HIYKO+zlfH79QBE5JY7QcP0BwiA0S8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uAlEUEW5DH1jtd23uEK97RhH1sMDjeaXr/+8cvWEY7H8DWnBRu9WYK4z+LquCqduC d5yOoh2A5t8B8EMIWYb/+gZFCeW5rcboH2p7gSXO7k25GkeuobI4SUO/xfBnDhwaT8 fUZiN3mFTu1WTUG2y7Qcl9x7bDatbIycB9nt/X2REgZt3O28IeY5TyBq656pRLqcKe icG6X4V1+maL9YYYzcb/kUaOEQmH86ymexTx4y3DT7GOKfxEHKID7v/k+vrJNQWZxC cPxMaWP0rOWZdesc5wteOUYZpT0C/rtvPIDjL/xrl/6+iqFuJ+l4wQ6VzP4crWZvvv ywikPVplcPtzg== Message-ID: <9dc77c35-bcb3-4a87-9926-36a0fa205d17@kernel.org> Date: Wed, 13 Dec 2023 09:28:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] f2fs: fix to check return value of f2fs_recover_xattr_data Content-Language: en-US To: Zhiguo Niu , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, niuzhiguo84@gmail.com, ke.wang@unisoc.com References: <1702347327-24181-1-git-send-email-zhiguo.niu@unisoc.com> From: Chao Yu In-Reply-To: <1702347327-24181-1-git-send-email-zhiguo.niu@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Dec 2023 17:29:03 -0800 (PST) On 2023/12/12 10:15, Zhiguo Niu wrote: > Should check return value of f2fs_recover_xattr_data in > __f2fs_setxattr rather than doing invalid retry if error happen. > > Also just do set_page_dirty in f2fs_recover_xattr_data when > page is changed really. > > Fixes: 50a472bbc79f ("f2fs: do not return EFSCORRUPTED, but try to run online repair") > Signed-off-by: Zhiguo Niu Reviewed-by: Chao Yu Thanks,