Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231212064533.233748-1-kai.heng.feng@canonical.com> <alpine.DEB.2.22.394.2312121441490.14041@eliteleevi.tm.intel.com>
In-Reply-To: <alpine.DEB.2.22.394.2312121441490.14041@eliteleevi.tm.intel.com>
From:   Kai-Heng Feng <kai.heng.feng@canonical.com>
Date:   Wed, 13 Dec 2023 09:59:03 +0800
Message-ID: <CAAd53p7BEanFM-3Z257WiEZpnuLP+bn2owx19z0s7Vx2KZ8H0w@mail.gmail.com>
Subject: Re: [PATCH] ASoC: hdac_hda: Fix NULL pointer dereference when hda_pvt
 is not set
To:     Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc:     lgirdwood@gmail.com, broonie@kernel.org,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Tue, Dec 12, 2023 at 8:45=E2=80=AFPM Kai Vehmanen
<kai.vehmanen@linux.intel.com> wrote:
>
> Hi,
>
> On Tue, 12 Dec 2023, Kai-Heng Feng wrote:
>
> > Kernel splat can be found on boot:
> > [    7.906438] BUG: kernel NULL pointer dereference, address: 000000000=
0000078
> > [    7.906449] #PF: supervisor read access in kernel mode
> > [    7.906455] #PF: error_code(0x0000) - not-present page
> [...]
> > This is caused by attempting to dereference hda_pvt, so check if it's
> > NULL before using it.
> >
> > Fixes: a0575b4add21 ("ASoC: hdac_hda: Conditionally register dais for H=
DMI and Analog")
>
> can you try this fix already merged to Mark's tree (merged on 7th Dec):
>
> "ASoC: SOF: Intel: hda-codec: Delay the codec device registration"
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/=
?id=3Dce17aa4cf2db7d6b95a3f854ac52d0d49881dd49

Yes this commit fixes the issue. Thanks!

Kai-Heng

>
> Br, Kai