Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Wed, 13 Dec 2023 10:47:52 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Yuntao Wang <ytcoode@gmail.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Simon Horman <horms@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86/kexec: Simplify the logic of mem_region_callback()
Message-ID: <ZXkbWMzCsU5S5szm@MiWiFi-R3L-srv>
References: <20231212150506.31711-1-ytcoode@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231212150506.31711-1-ytcoode@gmail.com>
Precedence: bulk

On 12/12/23 at 11:05pm, Yuntao Wang wrote:
> The expression `mstart + resource_size(res) - 1` is actually equivalent to
> `res->end`, simplify the logic of this function to improve readability.
> 
> Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
> ---
>  arch/x86/kernel/machine_kexec_64.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

LGTM,

Acked-by: Baoquan He <bhe@redhat.com>

> 
> diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c
> index 1a3e2c05a8a5..6f8df998890e 100644
> --- a/arch/x86/kernel/machine_kexec_64.c
> +++ b/arch/x86/kernel/machine_kexec_64.c
> @@ -42,12 +42,9 @@ struct init_pgtable_data {
>  static int mem_region_callback(struct resource *res, void *arg)
>  {
>  	struct init_pgtable_data *data = arg;
> -	unsigned long mstart, mend;
> -
> -	mstart = res->start;
> -	mend = mstart + resource_size(res) - 1;
>  
> -	return kernel_ident_mapping_init(data->info, data->level4p, mstart, mend);
> +	return kernel_ident_mapping_init(data->info, data->level4p,
> +					 res->start, res->end);
>  }
>  
>  static int
> -- 
> 2.43.0
>