Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5071759rdb; Tue, 12 Dec 2023 19:25:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFgqd/2k50cCFKFkgdPvcuM4uf7z7H7o+uJR07P64L9ksd/gAD3+QmPXlFzC2BkvEphbM/2 X-Received: by 2002:a05:6871:4e8f:b0:1fb:75a:de56 with SMTP id uk15-20020a0568714e8f00b001fb075ade56mr8520136oab.68.1702437943142; Tue, 12 Dec 2023 19:25:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702437943; cv=none; d=google.com; s=arc-20160816; b=NT9gKfUcAkTl/R+9mZmGxGGKoAGX7ktZlzwjdsi5+F7UuRQ08+L4X3ZGe14xmdAiPQ cwt8tZBcTz4ovjkPIgDl7HMnmlOccXuejnG3m4o7kglk6LlPjA++5688qb9W8bUEJ+Iq hPPMdVWUzCivepBUuEdCnu1gL1/TcGjcogj+iFdi8dYLJjDzELgn0UUJA73aKM1flMUw bVf/XlF0d9iWwdLAKFPbedpqiT658L67HbEcH/AyQnhgkn5gocNny9qcuv/DK6u1vZmZ WcQLfm9vKMJ59db4RbkDIyQBblUBjXb/L8gbxLyK8qJu6wEdw2hJ0Qwkvw3Eb8SajwhL 8s9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oHEWwWS/d+ov9oePzS5N8MzuKRMw9eiK625IUaQWN7E=; fh=IxNBpUB8GaBEwG4Gj/RwUUDACi/fBavS+TrIife4qMU=; b=WnmAstmm5l25PieKnp/YYRN9p1Dr3NarxTolTch2ynalCv2dg5SOm5ycdFUzmeRIwC g6ZLcMnWc0uHGwzx3kmhp7ld0KRq3DoUhRSpErT1WeU3FPvMPDsZ3Fjb/dMzHwU/WaK5 9GgpbGYeJxbHOCkPwNNUySs0Wu6gWR62KebS1DbUuQuKSNJ8GsYpCoAUxjME1otr457X Oe8z7JGppYkog48G46D4YmKSzEhSnc11Cb9o1kZaXskjLXMnxkHXfpDdejJBqYPrjiSM 3Uyd0Woy6IZsseuvWaOPA+IJKq6hXWIxii+Yj1iWW0WXXJ1o8I7Q8H8Jlq0KNV9RzApH hmzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@windriver.com header.s=PPS06212021 header.b=JK8gUTZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=windriver.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id r1-20020a6560c1000000b005be1ee5dfc7si8650675pgv.9.2023.12.12.19.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 19:25:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@windriver.com header.s=PPS06212021 header.b=JK8gUTZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=windriver.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B8E8A80B1826; Tue, 12 Dec 2023 19:25:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378442AbjLMDZZ (ORCPT + 99 others); Tue, 12 Dec 2023 22:25:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378403AbjLMDZY (ORCPT ); Tue, 12 Dec 2023 22:25:24 -0500 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4712CB0; Tue, 12 Dec 2023 19:25:31 -0800 (PST) Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BD2LqBh013286; Tue, 12 Dec 2023 19:25:09 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PPS06212021; bh=oHEWwWS/d+ov9oePzS5N8MzuKRMw9eiK625IUaQWN7E=; b= JK8gUTZXHPvpSOmd5yh39qi5MxiksPE2stT8b+AeTFA9zI3kZRacQz+d6wt0jFtC eLDYTH9SFVtCHY8jxavgvPE6rRfNIw10TC4d/Cr4VN7e6K7Xj1KZD7ftFopaFb2u cyIc7eHhUFmw+BxuHgzie5L46J+0YIluMDSWq9UpwXD5tEA9aMwf9cefNKaQ7mwu YNcaxPvnPtgHqC/zeGDWoaxVyyLh41jkA0/HTHLwhVrhJRv78+YGyXN/dyOijW54 F0n/Y4uWjAIcGJzMbMADD5FxxrsiRQ5t2AUUtuW8mzNzBCD4TPMW6wx9wkORy2AM o6e5ms9XJvIc116ttNRURw== Received: from ala-exchng01.corp.ad.wrs.com (ala-exchng01.wrs.com [147.11.82.252]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3uwyxja1f9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 12 Dec 2023 19:25:09 -0800 (PST) Received: from ala-exchng01.corp.ad.wrs.com (147.11.82.252) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 12 Dec 2023 19:25:13 -0800 Received: from pek-lpd-ccm6.wrs.com (147.11.136.210) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Tue, 12 Dec 2023 19:25:10 -0800 From: Lizhi Xu To: CC: , , , , , , , , , , , Subject: Re: [PATCH] radix-tree: fix memory leak in radix_tree_insert Date: Wed, 13 Dec 2023 11:25:04 +0800 Message-ID: <20231213032504.2133661-1-lizhi.xu@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <202312120651.92GGXeX4-lkp@intel.com> References: <202312120651.92GGXeX4-lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: 9iluF6xhpeAdVt-FoAhNtKxtKrWPHrdW X-Proofpoint-GUID: 9iluF6xhpeAdVt-FoAhNtKxtKrWPHrdW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-16_25,2023-11-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 mlxscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=789 adultscore=0 clxscore=1011 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312130022 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Dec 2023 19:25:40 -0800 (PST) On Tue, 12 Dec 2023 07:16:50 +0800, kernel test robot wrote: > kernel test robot noticed the following build warnings: > lib/radix-tree.c:558:24: sparse: got struct xa_node [noderef] __rcu *parent > >> lib/radix-tree.c:653:28: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct xa_node *pn @@ got struct xa_node [noderef] __rcu *parent @@ > lib/radix-tree.c:653:28: sparse: expected struct xa_node *pn > 651 struct radix_tree_node *pn; > 652 while (shift < mmshift && node) { > > 653 pn = node->parent; It can be clarified here that node->parent is the type just alloced as "struct radix_tree node *", so there is no need to use cast type conversion, Please ignore this warning. BR, Lizhi