Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 12 Dec 2023 21:00:12 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     Hongyu Jin <hongyu.jin.cn@gmail.com>
Cc:     agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
        axboe@kernel.dk, zhiguo.niu@unisoc.com, ke.wang@unisoc.com,
        yibin.ding@unisoc.com, hongyu.jin@unisoc.com,
        linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev,
        linux-block@vger.kernel.org
Subject: Re: [PATCH v4 3/5] dm-bufio: Support I/O priority
Message-ID: <20231213050012.GD1127@sol.localdomain>
References: <ZXeJ9jAKEQ31OXLP@redhat.com>
 <20231212111150.18155-1-hongyu.jin.cn@gmail.com>
 <20231212111150.18155-4-hongyu.jin.cn@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231212111150.18155-4-hongyu.jin.cn@gmail.com>
Precedence: bulk

On Tue, Dec 12, 2023 at 07:11:48PM +0800, Hongyu Jin wrote:
>  static void use_dmio(struct dm_buffer *b, enum req_op op, sector_t sector,
> -		     unsigned int n_sectors, unsigned int offset)
> +		     unsigned int n_sectors, unsigned int offset, unsigned short ioprio)

The ioprio argument to this function is unused.

>  bool dm_bm_is_read_only(struct dm_block_manager *bm)
> diff --git a/include/linux/dm-bufio.h b/include/linux/dm-bufio.h
> index 75e7d8cbb532..d270d48891f7 100644
> --- a/include/linux/dm-bufio.h
> +++ b/include/linux/dm-bufio.h
> @@ -11,6 +11,7 @@
>  #define _LINUX_DM_BUFIO_H
>  
>  #include <linux/blkdev.h>
> +#include <linux/ioprio.h>
>  #include <linux/types.h>

It's not necessary to include linux/ioprio.h here.

- Eric