Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <0d68fe7f-2a96-467d-87b0-52db36704e1d@nvidia.com>
Date:   Tue, 12 Dec 2023 21:52:18 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test
Content-Language: en-US
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Mark Brown <broonie@kernel.org>
Cc:     David Hildenbrand <david@redhat.com>,
        Suren Baghdasaryan <surenb@google.com>,
        akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com,
        lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com,
        hughd@google.com, mhocko@suse.com, axelrasmussen@google.com,
        rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com,
        jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com,
        kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com,
        linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        kernel-team@android.com, Peter Zijlstra <peterz@infradead.org>
References: <CAJuCfpFbWeycjvjAFryuugXuiv5ggm=cXG+Y1jfaCD9kJ6KWqQ@mail.gmail.com>
 <CAJuCfpHRYi4S9c+KKQqtE6Faw1e0E0ENMMRE17zXsqv_CftTGw@mail.gmail.com>
 <b93b29e9-c176-4111-ae0e-d4922511f223@sirena.org.uk>
 <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com>
 <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk>
 <CAJuCfpEcbcO0d5WPDHMqiEJws9k_5c30pE-J+E_VxO_fpTf_mw@mail.gmail.com>
 <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com>
 <3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com>
 <3d22f342-280f-4a44-87f4-8cca291cfce7@sirena.org.uk>
 <e3048458-726e-4b98-b2bf-908ea9066959@nvidia.com>
 <0f97db9c-5b86-4f56-8463-2520fe79f709@sirena.org.uk>
 <f1b0b80a-1cc6-48c4-8a53-0222b3e59c7f@nvidia.com>
 <2e4a719b-f2b3-48db-99db-d96040d78b12@collabora.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <2e4a719b-f2b3-48db-99db-d96040d78b12@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODZsK00rM3FxNUdnWnZLdDdLQmhSVHBIQmtiUDhnL2lYR1BJU3gyVU13VlhG?=
 =?utf-8?B?OVh0YlYxSUZnMnRDRXZBOHJhc1MwTWRKNTJXTzJqbVo5bnp6R1ZDcXZlYVc4?=
 =?utf-8?B?eW5wMEVFNWtmZ2dxZk50cXBqL29MU3VqU1hPYnViMWpEMXp4SU9xemtGMllu?=
 =?utf-8?B?bHBRenJrM1FjUkl1MVdmL3g1aXc2ZFZlNHV0NG5tSlZsaGo3TEY0TDFwT0pr?=
 =?utf-8?B?dGtrcnFyUTB0RmY4dlhCNWdpTXdNT0laU2dXUUdnOVFBMTJQSUEybG83d2dO?=
 =?utf-8?B?SFlqOEx4eVAwcDJWVjZDWnNzK3pTenhhMHNzUHc4MXVkczV0enpRWXpUeE02?=
 =?utf-8?B?VERtUE92TUVGQXVIaTJDRW1nWi9BbjY5MHFsN1Z1ME81OGY0UkJZY2FjUXRv?=
 =?utf-8?B?bGQ5aXBGODZDbTQ1Q3dmaVJRblc5eUNTYWR2YXZZUk0rSzFtQWxTZ002S2RY?=
 =?utf-8?B?NVBRLy9CczBkQUs4MVZRMFFEbTU1VDdTcVJVcW1Ud0dxYU5oaENobUFWTldm?=
 =?utf-8?B?VFpBbWxRZVZpSlA3NEljMlFaSDlEUFhoaXJvbm9NRGozdEtIU2FhWkc1WVEv?=
 =?utf-8?B?TXZ5bHRpQTdFSmQ1NHNxY3cxb2V0VmdJYmpmWHVFdDJwV0k2NDFaQ1VqSits?=
 =?utf-8?B?VnRGb0h3WGd1MnZadUVQNUw1RFA3TE5qMVk4MWc2WWFvVlVydksyeVVsczlK?=
 =?utf-8?B?cUVJV2t0YlVSZTUzY2Q0OHJBdUZidDh4OHloOU01MU5TOU8vc2RsVTlFbkZ5?=
 =?utf-8?B?a3FvZzcxRXNPRnBqeGo4Rmt5TzV6NFFrUzh5WUpEbEZzRE5aTjRCWjdCaytm?=
 =?utf-8?B?cUJOWGdUN2dYWnJsMWZCaFVnT3JPWk0vS2F2aWZZczlob3pWdzNaa0VKOTVP?=
 =?utf-8?B?TG92UHQvV2xUNWxDNGxBbVowZkRGbU9obXZrMDlKS3J4bS9sVjBRZ2F6TUNv?=
 =?utf-8?B?cTZMODZHUEFmdy80UkEzbjZISE1uZk1iQ3kyYnJYSzdBck15WEtnOUNhbW1k?=
 =?utf-8?B?MldOdWpSQ2xtZmlMYzkzU1J5TUtnMExENm14UDVGcm0wSm9FS2FmU0hOdHM0?=
 =?utf-8?B?bkFyL2oyZWlqT0pLM2FQUmVhYkRJL2JKOEd2TGtQVkM1Q2Z2NTNLa2FPWi80?=
 =?utf-8?B?ZVMrdHozSXlHUHVJYTZBNGtjcFg1MVE0M1ZiZDVWTkxYV1ozNGdHQktUTzkz?=
 =?utf-8?B?NG5LQWlEV3B4dHo2R095VXNlOEQyN0ZidURuSkdFa2NueUR3R0tFVW92b0VV?=
 =?utf-8?B?dkhhK3FXREtXenBnTEdpQm5XODlPMU14K0x1Y2w4NW5QKzlEb1JJSjVleHdQ?=
 =?utf-8?B?eSs0SlZ0cm5JQitmSEp2aTlRZnpsLzZWK2dJR0RKTEk0a3NvUTY2Mnp2Q0dt?=
 =?utf-8?B?dThocXg1d3FmQ2VzbXliUXlUaHhLd0tXRHVtOU9vdno2akNIUDdjMTlpSVJ4?=
 =?utf-8?B?amp0TzN2aEFRWTJkWE9zc0t1ZFB1bDNsRHBzNTA4dlBkc2JzdFVjNW41V2RF?=
 =?utf-8?B?Z3FmSjdSQURtRmFtTWhPVGkvUFdtVFdURUVlY21YN251V0F0MHBEVWM0UXBm?=
 =?utf-8?B?MUNoOS8rWld3VWlTaS9GTi8vaG5SSld4WE4wZThDbzhwcTRPeXBoSlkvSzZT?=
 =?utf-8?B?R1EycTNJYmtZYzVaUTdDdVVGYXpEYkJWZ2NmNlR3VGtSSkhqV0ROTHdkVUJW?=
 =?utf-8?B?cGtTRXdlUWszakRtRVVuQlVETUxxNk9HZDdXdXN3b1BBUjBxWGErM0Yra1ZP?=
 =?utf-8?B?TEdyajBVZzNpMmVkRW5LL1VLTjVSZjFmTjNZQzVZRVp1YnZZdXI1VHZpU2RQ?=
 =?utf-8?B?MGw3dmpoTkUvV1FRU2Z3R21pRkxpVUhvK3lXMytrYnNOS1pDTURGZzBmR2JS?=
 =?utf-8?B?TTJZNTBhYTRwN0k0T3RldlZHWkZwVU5lWkw1UXZYUGFsSjVzSXZJVitKak5I?=
 =?utf-8?B?QmN3TTJLa0NKVGkxTS9PQTdUTTEyVU1RNEdsekdSMnZGQ2Rnc1VCYWlQTnZ2?=
 =?utf-8?B?Y1VycFB2M1BxanhvSWF1OWFYeU9jUUMvUGNPdFhLUHI5ZWd2RXgwa2NKQTFY?=
 =?utf-8?B?c2tIRWd1bVZwME1zTzNCaEIrZFh1NmhqU3ZucE5DaWE3Vm9BYUFvR2JxRm5Z?=
 =?utf-8?B?dU5XUHFBWlFHMzAweVFIbzhLVGNlY2VpTEROQ3RTVWJOOGRYalhLS29NQ1ln?=
 =?utf-8?B?R1E9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a47fbe38-a1f1-4ef4-1bf5-08dbfb9fbb5b
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 05:52:46.6848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m6QtjXjGuc+8XO5TSJUrWFe8HMD3MU37i/5uFeF59BD4Mx7atZ/95uTBbFVupNFHOSmlXhqFbHAJNhcmAqtuhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4858
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Dec 2023 21:53:03 -0800 (PST)

On 12/12/23 19:58, Muhammad Usama Anjum wrote:
>> ...
>> Oh, this sounds like it would work nicely. No more "make headers"
>> required (hooray!). Instead, the new approach would be "selftests are
>> allowed to include from tools/include", and then we can just start
>> copying the files that we need to that location, and gradually fix up
>> all the selftests.
> No, this wouldn't work.
> * The selftests are applications which include default header files. The
> application don't care from where the header files are picked up at compile
> time. We should be able to build the application on normal system with
> latest headers installed without any changes.
> * The header files cannot be included directly as they need to be processed
> first which is done by `make headers`. Here is a diff between kernel fs.h
> and processed header file to be used by applications:

Well, that's not the proposal. The idea is to snapshot various uapi/ headers
into tools/include, just like what is already being done:

$ diff ./include/uapi/linux/fs.h ./tools/include/uapi/linux/fs.h
$


thanks,
-- 
John Hubbard
NVIDIA