Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Yinjun Zhang <yinjun.zhang@corigine.com>
To:     almasrymina@google.com
Cc:     arnd@arndb.de, bpf@vger.kernel.org, christian.koenig@amd.com,
        corbet@lwn.net, davem@davemloft.net,
        dri-devel@lists.freedesktop.org, dsahern@kernel.org,
        edumazet@google.com, hawk@kernel.org, hramamurthy@google.com,
        ilias.apalodimas@linaro.org, jeroendb@google.com,
        kaiyuanz@google.com, kuba@kernel.org, linux-arch@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org,
        linyunsheng@huawei.com, netdev@vger.kernel.org, pabeni@redhat.com,
        pkaligineedi@google.com, shailend@google.com, shakeelb@google.com,
        shuah@kernel.org, sumit.semwal@linaro.org, willemb@google.com,
        willemdebruijn.kernel@gmail.com
Subject: Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider
Date:   Wed, 13 Dec 2023 15:49:12 +0800
Message-Id: <20231213074912.1275130-1-yinjun.zhang@corigine.com>
In-Reply-To: <20231208005250.2910004-9-almasrymina@google.com>
References: <20231208005250.2910004-9-almasrymina@google.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GJH1GrK/kcD+ggAEBKftEI72XHFTrDvAHUiUqPb43B9V6IB/iob6DX4nTInO?=
 =?us-ascii?Q?H/6eMN1QFQIIL/0Z41eCxtR+S2vlsUVJbHV4avP/VFLsD5o8V0XuaXTa5Aq7?=
 =?us-ascii?Q?QSDblKvK+8vrJpoaa0ko3bnJ+C8gdNX5QtbBYClusaAUVPVgeWXLCXL8K/R6?=
 =?us-ascii?Q?wXdDvkb99euwpbUw2aQruCIWl/GrkkwCGpXAzht8bCTpuYVhrm7yNqfL6nl5?=
 =?us-ascii?Q?PPGPO9fzRddEzAqGfSfn7mm4waheg57pWWtP6NjUiTv0NZXSbRWIw+b31Cgj?=
 =?us-ascii?Q?n0EvN5mNOHAy4YeMtkmgRHAsWMu0MsvD1ug3Wu7yUm8awPsyA93/sAUHzGwS?=
 =?us-ascii?Q?zhTjZiY11kI7/FXx5mYnzeq9rjAeXJwSjZ9A8isWhq8MCuxocKyXqJw/FKM9?=
 =?us-ascii?Q?O861Sd7MliRlGb0Yhq0jPMDy4biJXpHroPJSkpgwz6GaeRj5cYwbZtAJp0/n?=
 =?us-ascii?Q?rX8uy20r/sFd1Qj89HwvgigZY5n6QEvSPMb6JHHUVV+pwIUXINEmWXGeeyBw?=
 =?us-ascii?Q?QFGfYE/+2HHR7KQt7tQ9cElQAk5giAO1HPLyA7uto/pOImapiVKKzbycGBhi?=
 =?us-ascii?Q?ZXlS0JDNmnzy/CtNqWoC9vj764qlr16ByUYTVZ8a+joIEVZOJBwE5i4/xXLd?=
 =?us-ascii?Q?DJ77Y2jq+eEO5ZZ3p3nAG569NN/+zJ+UgFYwVPZLz5pDoSEh7gduv7U8uy6r?=
 =?us-ascii?Q?Tmx4uc4I7aShhbf4TSVnjLYiZvsnA5B2ybayjxggI7WNFG5JJmV4SDbGuTXU?=
 =?us-ascii?Q?SCvmzYqja6wefPr7I9Atc1OvDDbbiGFny2quETHPfKgsKuA5NG0dXtZdTL9d?=
 =?us-ascii?Q?Wm8AixU07Sz3NqAeI6tZXOuaO358QPSqlGUlzjwmkALXrqAjSKuFSViYaLRH?=
 =?us-ascii?Q?hOeBTnB6entC2EFxHRhlQGvhnwZ+mkyzbQsyXlC6cmCKj4ElWlM/dmko6mtI?=
 =?us-ascii?Q?NT08b0JpObax7s956MM5Jj7eku0vdxj3OG/s3YG9iaMDmlbqFq5uA+Z/xNIw?=
 =?us-ascii?Q?nPpH3akwGPfNtrZCYDMbEs08U2hfxlg1YleHmb8Z8hVwghXTcyOlVkSIbd6h?=
 =?us-ascii?Q?6Ol2eMfA7gdjSwUUQ8QPlx5HztwCThIHxO3gl5z/EMOI+HcLzf5khXu+d6ZD?=
 =?us-ascii?Q?a6ZY1xyOS6NLtgu4tgsDfEswxvA+uPzkJj3bFlxBm5n8nNBobya6jURi8DA+?=
 =?us-ascii?Q?hObg27au4MDBgQt33AU3HzkPiwM2EEbOzxTpZ7hJOAuZ6Ampzh4wrEMH/wsk?=
 =?us-ascii?Q?rlGEhaccSyeAH+PvXQxCLJsNO3Tlz3SBrqf21wIgUrjSvcJi8zs3/NDfbss1?=
 =?us-ascii?Q?xCvC9qMlW6xVeMhaULQ+uetM89CBfJ22M2NyO8fMkBMmhQuV1fYsOLZaowOb?=
 =?us-ascii?Q?c66aQ15RM3P8mgHUSNQXoIunhY3Y/HJ2rxEvhfCCURad+YCrJA/PRcbmMOoB?=
 =?us-ascii?Q?/b5VFGqU2v42Ie4PGFce5iBH9SqNApjzPBMuEzN6t77aAwNulddI9Nr2Ctoa?=
 =?us-ascii?Q?HPyKh9fJIT5T0t9wT/VyVIL3b/unQU4zz/pIJOfsj8O9fgQIiUZd/J1Fd4X/?=
 =?us-ascii?Q?nEtfa2esrgKAlVjmmx0u6sZnUJW8+T89bFq/FswaTJrpI7731PhLBTKwyDO7?=
 =?us-ascii?Q?Nw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ffd81d8-5acf-4e69-b4fb-08dbfbb00298
X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB3705.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 07:49:18.4956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VJGSBc4CBjl7hFKShRgkL1Xzv/9yW4v4oPFloOwak53LJsK0BMCy1D4Ste8jp4L7nt3qYEm2fgNWgJusDeJGu8VB1BavXe1OIAF4jiqyo+I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3911
X-Spam-Status: No, score=1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SORTED_RECIPS,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Dec 2023 23:49:31 -0800 (PST)
X-Spam-Level: *

On Thu,  7 Dec 2023 16:52:39 -0800, Mina Almasry wrote:
<...>
> +static int mp_dmabuf_devmem_init(struct page_pool *pool)
> +{
> +	struct netdev_dmabuf_binding *binding = pool->mp_priv;
> +
> +	if (!binding)
> +		return -EINVAL;
> +
> +	if (!(pool->p.flags & PP_FLAG_DMA_MAP))
> +		return -EOPNOTSUPP;
> +
> +	if (pool->p.flags & PP_FLAG_DMA_SYNC_DEV)
> +		return -EOPNOTSUPP;
> +
> +	netdev_dmabuf_binding_get(binding);
> +	return 0;
> +}
> +
> +static struct page *mp_dmabuf_devmem_alloc_pages(struct page_pool *pool,
> +						 gfp_t gfp)
> +{
> +	struct netdev_dmabuf_binding *binding = pool->mp_priv;
> +	struct page_pool_iov *ppiov;
> +
> +	ppiov = netdev_alloc_dmabuf(binding);

Since it only supports one-page allocation, we'd better add a check in
`ops->init()` that `pool->p.order` must be 0.

> +	if (!ppiov)
> +		return NULL;
> +
> +	ppiov->pp = pool;
> +	pool->pages_state_hold_cnt++;
> +	trace_page_pool_state_hold(pool, (struct page *)ppiov,
> +				   pool->pages_state_hold_cnt);
> +	return (struct page *)((unsigned long)ppiov | PP_IOV);
> +}
<...>