Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <d0308a65-4e78-5386-126c-9a7115d345b8@oracle.com>
Date:   Wed, 13 Dec 2023 00:12:16 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [RFC 0/2] PCI: acpiphp: workaround race between hotplug and
 SCSI_SCAN_ASYNC job
To:     Igor Mammedov <imammedo@redhat.com>
Cc:     linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
        mst@redhat.com, rafael@kernel.org, lenb@kernel.org,
        bhelgaas@google.com, mika.westerberg@linux.intel.com,
        boris.ostrovsky@oracle.com, joe.jin@oracle.com,
        stable@vger.kernel.org, Fiona Ebner <f.ebner@proxmox.com>,
        Thomas Lamprecht <t.lamprecht@proxmox.com>,
        linux-kernel@vger.kernel.org
References: <20231213003614.1648343-1-imammedo@redhat.com>
Content-Language: en-US
From:   Dongli Zhang <dongli.zhang@oracle.com>
In-Reply-To: <20231213003614.1648343-1-imammedo@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K05sM1JIbkVHT3lTcEdWS0dCZ2Z1UmRlcys5OEp4SlZhWXI0UEZMc3ZRazY3?=
 =?utf-8?B?ZGZuRkgrZE1SZDRDNGtWYTRQNDhYNDN2TzgrK3F4a21hOGExNVVuZy9oaE0z?=
 =?utf-8?B?Y3NxWXpsM09DanNzMnMwelpSN0s5TmEzNTlxaFA1Mk5QN25RdGRhaW54WlhR?=
 =?utf-8?B?L2JvUWRNSHlQdWxUeEhPRlYxOHVtaDl0bCtrckl5bjJsdzJaYWJoam5MZUtt?=
 =?utf-8?B?Q0kyaWVMMDRyT21hUnV1T1VtS0lOeThsQmhMSXdiK1ZQa3czOUsrVjEzd0xT?=
 =?utf-8?B?ZW5NVEZOY2tHUThuQmsybGd5NVJ4ckc0ZnJYVWZxT2c1c0xnS3d5OWxTZ1ZO?=
 =?utf-8?B?UGFEMW93N09zZXd5ajFpVUo5ajBMRm1aNVVxd1EyTWp5OTZWTmIwWjQ0YjIv?=
 =?utf-8?B?dVVWZFo4VEY1Rzc5U29JUC9VVmJxTVF0eCtrZ3owWHQza2hKTmYzbzdIcFpr?=
 =?utf-8?B?S0hYUHo0WnNFK2M1RzljR1RRU0pXd3dHancrWnNkcm51QTFxbjZScVdvMjcy?=
 =?utf-8?B?TERWZ1pPTDFNN2RsT1pGdGM5K3l0ZlZURGRubEUrY3BKYktRUlVPZk8vMFcy?=
 =?utf-8?B?aWdsbUIyb3JMakJsWCtTT3JOUkFWL0xJOHZuOFJwY1JQQUcxT1lxY0plQlc0?=
 =?utf-8?B?VVhabG9GbFd0bkpmNWlvdDlvNE11ME9UL3JsVFpBUXUrenN1OU92U0FtOW0w?=
 =?utf-8?B?WXJGTVVCeG9hUWVDN3lkQ0xFckowa2VsNzN3WWRqWGx6eEpPSnJKMFdXT2RY?=
 =?utf-8?B?RXBDYXhudWQzc0Ftc2Z0dEdFTXdXeXNzK2FXWlFhbFBXdWZSQ3diSTBKNGdC?=
 =?utf-8?B?eDNJQmk1MUIrNWxpc0tpSnJaOGJkWHgvb1NrcDgveHphWmNScXBqODVUU2lC?=
 =?utf-8?B?WUpCdEdaVnc0SmxaRGNQdEQxbE9BRzh5dit6SHpQSGZ4eTVxODNWcHd0Mjho?=
 =?utf-8?B?R2FxaHhpUFlIRXIxbnF0bzU2NENCVkpoZS84TmZ0N1JqeEVvcmJBMnJjN1I2?=
 =?utf-8?B?SFBLK3RWMElUV01oUTVuREltOWY2dFRCMU1QZ1czOHlpQzQyM2tXdXpKYmlG?=
 =?utf-8?B?S2Q3dkZTRHpyQWhJSFpTc0dLZitUYTk0NlJuVlBiUXVoZHJtWXdJOEdBN3F2?=
 =?utf-8?B?UXdVN25EMzVQUkxld2xjSVo3QTl4OFJxZi9ZVzBNVnlhbmhuOFM2RWYwNWxM?=
 =?utf-8?B?YWZSTFMxSEtEcVdMZXBRRlJYN2lyT29XNGpVZG9DdGp2N1dzU3oxdHdTVHlm?=
 =?utf-8?B?ZTFQa292TnFrQ0RoKzQxRGIxLzFQRlhkOTRDOVd0RDRRby9nd3Z3bUc5Qjdq?=
 =?utf-8?B?MHNqUk04ZlZSZWhqWkFLOHNYTDVEL1RsR2JLbGlDT2RYVFppNWN0aVNoYitU?=
 =?utf-8?B?cnV5aDNBSEUvUzdROGJ0aHZLaExhRTdxTURzTmt2b2ZudytCMDk5bHlkSUJl?=
 =?utf-8?B?NTlhRWZLb015QTVWT0hiZlovUmxpOWVlTGdKVVE3MVRxTDNWL0VtVDdMSHY3?=
 =?utf-8?B?RzRXQ00yeXFISzJZQ0NpaHdYNHMvRE1uSzBGbFVkOGlaaG1mL3lPVEJFQWMr?=
 =?utf-8?B?bTFDMkRvVEl5OWMrMnhhTTdCeFdLSTdaeWJtS1NENkNUdEFNTFRlQXhidzEr?=
 =?utf-8?B?Y3dRZTRaVmhHb2pRYXljQ3g2alBQWDV2bEJidmVzU2VWTjBuU084UU1lZEdG?=
 =?utf-8?B?VHBJQnp3bUtGUTd2QXJLU1l6MkREUGx5UG9UVlYxT2ZROWxvbGtUL1VKVk9X?=
 =?utf-8?B?Rkt6dmV6bWU0NU5WQ1ZzbTUxYlBlLzdpaWR3eG9KMVdtcDYwN0hPcTBaZS9k?=
 =?utf-8?B?c1d3TVpPRGo4bTVqUERoTmRsTjF3UjZTa2Yxb1JOb0xIaHVyZldWS0V5VnZr?=
 =?utf-8?B?MlM1OE1pY2RBUmFmNG9POFM1RXY0emQxc0w4UWRhK3VFQUJxSzZBOXRjZUwz?=
 =?utf-8?B?MDc4U21NbHNsSzlEblNzU2hVZ1pHK09GL3dmVlVzRWhEdU1xTGtwakQ1RDNS?=
 =?utf-8?B?MXlLWUd6b01zN09qRlNnSk5ZZkdVc3lheWFFWDloU2NPdmNDdjFwQ0x1M2Q0?=
 =?utf-8?B?ZUphQ2lENCtCa1FZay9GWnJ2NDN1L2tGU24zcDloNEJSNEg5YXpEU1FaM1hI?=
 =?utf-8?B?YlZ1bCtCSjVGbm9vTk5JbHB4ZEt3dzZVYlMyMGxyNzlleDhla2NLa3BuZDVB?=
 =?utf-8?B?N0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kcfu8Oc+ICJv6L5BAb2CWw7OYEP2QH5bJUP5M5+IU1XncNzqwzAJ9Bf27lnUkz/zzWlFVyJw7psXwwCFVe7+ElEJVQelk/Rb244N2J2M+8C20jxFHZc44yy0BE8zePWY8VDeBdrqTjA4nGWyHby2Rg5UPLL0KFTSyT4dtH/DiDO5G/scHR+dS4rvyluABlTxcIk2nHxiBP31399Qt7XyV889ZI1A7UnKcoyPJucB3gkw3cuO8ulEMsrZ8WQ00DIJwzTvj3xnjdC6iVLvCZlKRjQPvWcqQrsD20XbJq5nj9ASHjmPzT3dqLmfKHWsqL8DINSozi3enWUzxL0uFE0B253hktLRUXRdoT/wgsM5p2rNJr0z+WFh2BK2Hygt3P922+Q1fQOAVQlpmNPzxQroN+uAkRRJtjsv2+NLulXVb/2QS1gDEXlwnY6uaPvmeUGXY9x475qOngANzrVc8kos5mTPc/zldgcjMni2MGz0hoGSnt8u/szPSP2JU9nWLHp/uHbXMpMiA/tykMXJZbazrqLy5VMe/sYY1/tNDs9i0+DXlUjGCcHOVCiAEPJQJ9YUwTskoKAqTn/tgCeisoS9Zpyc12h06sAjyYmcPUJklys=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7da02f98-4f42-4dc4-0958-08dbfbb33b38
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 08:12:21.7028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JHSV1DhBagqXqiuw6FzJrls99BbKrZirwsn3SjTyu0Tfxi42o8tvZko6g05Rsj44DUTSpUfehzGt5et1C5Xfdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5096
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-12_14,2023-12-12_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312130058
X-Proofpoint-ORIG-GUID: zCbbgquTicLXERNd4GUEt6MOhX_B5FJp
X-Proofpoint-GUID: zCbbgquTicLXERNd4GUEt6MOhX_B5FJp
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Dec 2023 00:12:58 -0800 (PST)

Hi Igor,

I am not able to reproduce the issue any longer with the two patches on
top of the mainline linux.

Thank you very much!

Dongli Zhang

On 12/12/23 16:36, Igor Mammedov wrote:
> Hacks to mask a race between HBA scan job and bridge re-configuration(s)
> during hotplug. 
> 
> I don't like it a bit but it something that could be done quickly
> and solves problems that were reported.
> 
> Other options to discuss/possibly more invasive:
>  1: make sure pci_assign_unassigned_bridge_resources() doesn't reconfigure
>     bridge if it's not necessary.
>  2. make SCSI_SCAN_ASYNC job wait till hotplug is finished for all slots on
>     the bridge or somehow restart the job if it fails
>  3. any other ideas?
> 
> 
> 1st reported: https://urldefense.com/v3/__https://lore.kernel.org/r/9eb669c0-d8f2-431d-a700-6da13053ae54@proxmox.com__;!!ACWV5N9M2RV99hQ!ORo96Nh22kv1Yj0pazd3c692djoLbWscgouJoyVG1c1CNQnYz-H7nPM7RIp8N-0qQjScZ7BgORR_Lm4oMGMl$ 
> 
> CC: Dongli Zhang <dongli.zhang@oracle.com>
> CC: linux-acpi@vger.kernel.org
> CC: linux-pci@vger.kernel.org
> CC: imammedo@redhat.com
> CC: mst@redhat.com
> CC: rafael@kernel.org
> CC: lenb@kernel.org
> CC: bhelgaas@google.com
> CC: mika.westerberg@linux.intel.com
> CC: boris.ostrovsky@oracle.com
> CC: joe.jin@oracle.com
> CC: stable@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> CC: Fiona Ebner <f.ebner@proxmox.com>
> CC: Thomas Lamprecht <t.lamprecht@proxmox.com>
> 
> Igor Mammedov (2):
>   PCI: acpiphp: enable slot only if it hasn't been enabled already
>   PCI: acpiphp: slowdown hotplug if hotplugging multiple devices at a
>     time
> 
>  drivers/pci/hotplug/acpiphp_glue.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>