Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5179494rdb; Wed, 13 Dec 2023 00:49:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBGnizjZjUR2K6OjfxBOXUEtLtR8HqDC3hHF1ZXv0AAvKT2BlH/ILrY1yNdKS1GuDeaHie X-Received: by 2002:a05:6871:7a02:b0:1fb:75a:6d41 with SMTP id pc2-20020a0568717a0200b001fb075a6d41mr10316260oac.104.1702457391885; Wed, 13 Dec 2023 00:49:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702457391; cv=none; d=google.com; s=arc-20160816; b=J1R1Iu2JB5q2mwiZVOtAIkE5GztkkfLGxnB8x5rTV36Atl3HVOMBxrjeWm2ceeEamB awmWviN9Sm8bqZsTqBlOC3mnwJtn6Jbqun9yA23Suz+ZkQUx2sPK/DHh/SZ98AHELGm1 pyAL2pikfkiYmaNlbcHsxJEqcZrasx4J66XYDaFD5BpysZOh6pKfEs+WT4gBSHb/QyLX F25vgiNX2yU2C4j2GnsfLh0uD3KtuRJiiw4xK+797j949sWlnJpTkNmFYkG4uvKxqYdk vh2TFvB93RVtiolAiuT0cJ5NRoGi+21baMyOWVMISxvPUEWRnUGZ0AltgpjioMGoGCL+ nvfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I+dkvxeAcae4QrSyLPuuRO1x+IeiVhS+Knt3ouNUsYk=; fh=xaAShxbj3efqtEWl5ZkjHsBp46G7+aOmrqQwTETNik0=; b=SECFqkk88C3HzwJVMHNE4x3cjhkEH8tpO9U7kamR4E//YwisoSsueqjyTEMDyHgAwl F+zAn/y9lpxKfAdhgU4WBJ5A4oGNvugKGRX+2sMla96uMOu4/VatNbiLN64RCTr36lUx MuwJdrLeqULCcj6rqE5stPiu2LG+Cg4dB4M/9PAwAM+l5QiEpOjH9BeUMdQSnXob2FU0 o3hJb3RQcRbqWrtofFoocyAhRML1jaysGL78EBm5gw4fS7XVjF0EDNfJGE1GNoDpgtAN yY12tu3FVooh3hf34ZBnJCq/wnsnoMi59S3SKc9Jc5Vte4b8ARDTCz/qz4cP+ixpnqiK gMXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QCb0AqSk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id o2-20020a655202000000b005898d997f52si9329720pgp.66.2023.12.13.00.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 00:49:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QCb0AqSk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id AE5048043EFE; Wed, 13 Dec 2023 00:49:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230404AbjLMItd (ORCPT + 99 others); Wed, 13 Dec 2023 03:49:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjLMItc (ORCPT ); Wed, 13 Dec 2023 03:49:32 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36826E8; Wed, 13 Dec 2023 00:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=I+dkvxeAcae4QrSyLPuuRO1x+IeiVhS+Knt3ouNUsYk=; b=QCb0AqSkp4xdsj2xNyFWhYHV+F 5D6njHGju8uCFzrj9nxpbiOXMeQsgpOyg4rX/SgXH69cD+nVAZROL904DvKZW8IVwEg8nmiakvXZx MJ9zQAq7fRXDPAYCe5FYSx18oeCwfmD1XVCn1kWueFpbqhZfFV1d0/82E7r8X+pyOmFcNqUfphQYp r92j0FLSF4jlcVBD8U/6GLKha1o03Z8DWeBOJTKp3o5IyUw8o3V39O5gv7B9H5ylR+ABXjI3IkToz skDWmPOwgXvjjB99RtsCqDkHzjLs/M1qecbS/cqn2QOKllZZFo1MQtBbLARyE0g7KWWXPNOjqDmrG eaKXiJPA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rDKvu-00E5Bt-0l; Wed, 13 Dec 2023 08:49:34 +0000 Date: Wed, 13 Dec 2023 00:49:34 -0800 From: Christoph Hellwig To: Johannes Thumshirn Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/13] btrfs: factor out helper for single device IO check Message-ID: References: <20231212-btrfs_map_block-cleanup-v1-0-b2d954d9a55b@wdc.com> <20231212-btrfs_map_block-cleanup-v1-1-b2d954d9a55b@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212-btrfs_map_block-cleanup-v1-1-b2d954d9a55b@wdc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 13 Dec 2023 00:49:49 -0800 (PST) On Tue, Dec 12, 2023 at 04:37:59AM -0800, Johannes Thumshirn wrote: > The check in btrfs_map_block() deciding if a particular I/O is targeting a > single device is getting more and more convoluted. > > Factor out the check conditions into a helper function, with no functional > change otherwise. Looks good: Reviewed-by: Christoph Hellwig