Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5179928rdb; Wed, 13 Dec 2023 00:51:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IERnu71gEBXx/HAeZNxhKuLfUvUFapY6y9V/yTZryoPlpcKYnoHugWO77LNe78Es11CY4jf X-Received: by 2002:a05:6a20:72a6:b0:190:36c3:afd5 with SMTP id o38-20020a056a2072a600b0019036c3afd5mr3883129pzk.115.1702457469631; Wed, 13 Dec 2023 00:51:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702457469; cv=none; d=google.com; s=arc-20160816; b=z8MFwirClgi2QfC6TOMZvM5bv8i1YKLbJA0RnWkeBo06QHPnMLwMEIgTiQgUNoduUC IT0rI29qsBvFhBOznzXc2HecVrEkPT46ql5UrR1UW05ksRXO2RmdCoC7cu/cZIISheDY sjBtGjaT78p8reL5rJQsf7ZAznhXQBZ80mTbyEyX9bD7L4jsRngkXMkDzN9aXJwwJMuk duC1L9e7vwVhNK+4xxsPUNEfVfMriykIWkpaNFbc/G4KTtZQhnywxfeCc+YzVOpE7qll e4su44th1Q8nbGNaPLai2Y0IToXxJvnTqGWG/mQKidifMs3t+CC9LbDmbMhCxl+6m/vw Z2qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VsEFfbXYkoEiyCW2AjPqmE6JGQ/NnRAbJd6BX+OhLPk=; fh=xaAShxbj3efqtEWl5ZkjHsBp46G7+aOmrqQwTETNik0=; b=OxuAkvE5bKuXHq5cSkEmKSZO9VkNGZ7yEjLiq0iLmnproIf0r6S2AqIolxPIcjSL/N x5vqQQGz1FAxmYq9CDy/dJCxj1rW88f9lRZkcDZZSvE9gxSrVW0m8iBw5v+YY51FyMSs Itg92A1DPdTAZEYHZbNvZTKrbTWPMVkKG8RX8OzdMv+1Yw14DOOaf4Epjwjhs88K9VcW Nzg2XSNURwvzpKIVomKuFLlGQzz+cRVPnZk+kJCnXZ3AFS6lTPkzN/VaNvrziWq5dZWi mVi6bb8/29nXv3cQozsTPvrx+xD0pYOrhSyMDSjj1udvyCdFDh2qN4Cg+9vOjXB+mnBU OkWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="z+/71fcK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id w15-20020a170902a70f00b001cfabbeeda5si5051032plq.291.2023.12.13.00.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 00:51:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="z+/71fcK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id A0F9380576DC; Wed, 13 Dec 2023 00:51:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231226AbjLMIux (ORCPT + 99 others); Wed, 13 Dec 2023 03:50:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbjLMIuv (ORCPT ); Wed, 13 Dec 2023 03:50:51 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3650B7; Wed, 13 Dec 2023 00:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VsEFfbXYkoEiyCW2AjPqmE6JGQ/NnRAbJd6BX+OhLPk=; b=z+/71fcKw5r2E+N+ihmNs5HSEc 04Pl7NkpysRUp4baIDPUaVi46NzGq8+EUuO4jQ5xsBtRzwgQ5+wN1kIMOG/8BBA46Q28I4azn8oou RoftrV8TAlcJ7kb9aGOOFjVaZnUKo0n0lp2ib4acoa4gXXXEdWBj56EKW/rlLjnCiSMAHPoX0qtM2 HlaErUGqF6MvNpFr9+m5JA3INKoIwPc7vWzeLrIhLe6kWQdWw6LSM9T3HYszgevThamw2oZTSjThu EoxIE0gZeY9Z6pCLzx+h7HnJr9jSGfNK7WNvvNfkiXKz/YttEfUQ5GRJIgHGIBGqxG2nYhxeOuw0v O9ohzDvA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rDKxC-00E5Ke-1f; Wed, 13 Dec 2023 08:50:54 +0000 Date: Wed, 13 Dec 2023 00:50:54 -0800 From: Christoph Hellwig To: Johannes Thumshirn Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/13] btrfs: factor out block-mapping for RAID0 Message-ID: References: <20231212-btrfs_map_block-cleanup-v1-0-b2d954d9a55b@wdc.com> <20231212-btrfs_map_block-cleanup-v1-3-b2d954d9a55b@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212-btrfs_map_block-cleanup-v1-3-b2d954d9a55b@wdc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Dec 2023 00:51:06 -0800 (PST) > +static void map_blocks_for_raid0(struct btrfs_chunk_map *map, I'd skip the _for here as it is a bit redundant. > + enum btrfs_map_op op, Looking at all the patches: shouldn't the op also go into the btrfs_io_geometry structure?