Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5180773rdb; Wed, 13 Dec 2023 00:53:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFCH8HIg+gK/hsrrR4xlnMUqVcAlZyYRAQly55IsPCDxHn00MSnOe9VYXkpwzMlYGwZ2IkH X-Received: by 2002:a17:902:da8b:b0:1d0:6ffd:e2b6 with SMTP id j11-20020a170902da8b00b001d06ffde2b6mr8067024plx.80.1702457631075; Wed, 13 Dec 2023 00:53:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702457631; cv=none; d=google.com; s=arc-20160816; b=gM/sqw8PNnyUs98KXeH2vuanABcC4vYRvvTzgL//j40gdBAduqPyVNBuw0BGCfaURs DxhXs/wzp5cDb6F7cG5vA6x7Z254Unvj0e+5z3jMDnW/8bbhyrPweB+Bi4ZHrmTNtbHF lthoYyX3oD70DqfzHp01x0SbjY1M6mK5luSirWmc4H/YFMQU4AY+NjU62rssArZG4Kw2 8lOIAx5LVufRyhJAU5bv7Kxib6yJjfmlCZb6MMuT+LTSdCvFa40nK8T3DcqxjaT0RAtd 9Ib9zUX/BcQ1VkgF/BXiuVMC4tGJpHbJbhgiuESHe/5iR8vN7wztuVh4lca7eNAgbzQp 5rMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5X2SvqPtWo7gdK+k/g7tSjg+ZxJIl7QEcfpBU4ieBtM=; fh=xaAShxbj3efqtEWl5ZkjHsBp46G7+aOmrqQwTETNik0=; b=mt03t1G+0jeFc8uGncc3hye3SHSPYF5JJtqrwbE0jnBazct2K9+yI6r45R9O3oACq9 bVdWdICCbYtbSAsoN2ze1KKKyY7KU8/X8BUXuVngfH0Ugzrd039pzHpMtwAN6yFK09eg kvQQQvlOFo08eTfcqE8y8Y+nq76/i7UTJqmx2QGbUo7NpmjLYsAURSMQKtPphJdQagp5 PaVOCeEUeRaF88+RRS7N6+Yz3pASoSTIUftMNOECVau+3AvUkm2cyMmYbwFKdsnnwVrM O+9Q8ipaMI3SZJY3EuHXa5LMOQENrWzL5FagSWDlG7yGbxJ4wqCqROLfXgxd443taosn iSlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2ke4ezuC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id q4-20020a170902a3c400b001d0050e2466si9185737plb.23.2023.12.13.00.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 00:53:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2ke4ezuC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 8AC818136BCA; Wed, 13 Dec 2023 00:53:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231761AbjLMIxh (ORCPT + 99 others); Wed, 13 Dec 2023 03:53:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231226AbjLMIxg (ORCPT ); Wed, 13 Dec 2023 03:53:36 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32DE8B7; Wed, 13 Dec 2023 00:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5X2SvqPtWo7gdK+k/g7tSjg+ZxJIl7QEcfpBU4ieBtM=; b=2ke4ezuCb59ti/+WxgLBeNXl2P LveYl5CDnfVWE1Q/vO5SBOt8KtB5XZ01MZS9Zrx+liAyCk/X1L2UmSLzlUsW4QzEDjxRUiHstzV79 O1edyIh/fCuAZQS+qdL/0yUSROjsVffBTciCD0Qt9oDosBxsprTQdP6tBA7TTceFFd9N2n69SQEyB 2jBx5Z+wBenMvvEtqpFC8ttaxdkDzAAQ2+rOFEneEePJYr6T6t//cxCKbdFPQdu06lqQeJc+uvzi6 QqWptSQh7e3eLUgU3gs7sJoXiNZ9+yETXms48+8EZS8NsrLSMhMzqKFI3TcLgHfB9QdapTKViqtZL pO57hZ0A==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rDKzt-00E5d1-10; Wed, 13 Dec 2023 08:53:41 +0000 Date: Wed, 13 Dec 2023 00:53:41 -0800 From: Christoph Hellwig To: Johannes Thumshirn Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/13] btrfs: untagle if else maze in btrfs_map_block Message-ID: References: <20231212-btrfs_map_block-cleanup-v1-0-b2d954d9a55b@wdc.com> <20231212-btrfs_map_block-cleanup-v1-10-b2d954d9a55b@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212-btrfs_map_block-cleanup-v1-10-b2d954d9a55b@wdc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Dec 2023 00:53:48 -0800 (PST) Might be worth mentioning that you're using a switch statement :) Otherwise looks good: Reviewed-by: Christoph Hellwig