Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5191179rdb; Wed, 13 Dec 2023 01:17:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSod0c+1YqbIy5BA8qx0yP3BnsVZnsIcIBXAx0gJFKulY0qfJ2xh+QFYWy8JhRrbtRhCTI X-Received: by 2002:a05:6a20:8410:b0:190:22f3:caa3 with SMTP id c16-20020a056a20841000b0019022f3caa3mr10141227pzd.29.1702459048966; Wed, 13 Dec 2023 01:17:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702459048; cv=none; d=google.com; s=arc-20160816; b=ZlwMMyfddG7rntfvI0kNwhRJ8oXXR/16HF1hSOGlPjYhIDCs+HORMeihRFucUSd11l PFViTPifgVSdPJVKHG8zw6lfhUbKTYJiTTqLahsUzLMFzejexO03MmqJ/2XXzq3LXvFX BHzgwtv3r3BQX6pEq22WuURpykPYP01PW6j3T9XkR4Zkk50x71nZDaj6c9WmhnYDqWoR S1lhxTl8a/B/7jHT5+s8kEEeMAHEY3e6cxdSViLOA2nEZ0FCd3OD+W1gS4DBetifPLqG gr8EZXxoXogYias9FWfNBO4Fy27aK1/bHbh7yK3n5O6yyR+yQH8QiHblP51vGOgATVAW WbGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rUfGZho7K3qVy9Gsxf7KYBLzMAnHb4FXaY/ImZeL51o=; fh=W6oREW6Ix4ZyPkaseb8OpPJJA/ZYekAKi5DdeGz82Mo=; b=zQnyOS4Z/GQGo+L60HD9KoPHBMk75WMTa7RKK3+iQ9m5wn5ETDTEIkotxw9xSCU1Om fcE8TzPu4ZiJLfHFzO5JZV8SssCYWCTuFYCl7MXFkYL9ocJaVwtqkwynqYdr3/4TBKua 7kb5mAJiUDzvzNAIIPoGt2LASvwQN3hxVvrzQHT1+4f7WYR96G0dv1Pzm+UJMSK2byKE rzVrYDr2EL9NQ0sPRFLa7QCgBle93Elie2PpJOnhs93GZMh00lE2EPHH0lz2vFXBuLpE XFKS+t21bI1/0ZIqmPxnGXFxDuW2WGltE83AtqfdRNDzgiCzKhUwNJI85/r+Twclsbxp 1yDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="lRHjh1f/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id ls7-20020a17090b350700b002810ae70420si2184452pjb.121.2023.12.13.01.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 01:17:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="lRHjh1f/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8AA3E8043ED9; Wed, 13 Dec 2023 01:17:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232891AbjLMJRJ (ORCPT + 99 others); Wed, 13 Dec 2023 04:17:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231648AbjLMJRI (ORCPT ); Wed, 13 Dec 2023 04:17:08 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09ABEFE; Wed, 13 Dec 2023 01:17:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rUfGZho7K3qVy9Gsxf7KYBLzMAnHb4FXaY/ImZeL51o=; b=lRHjh1f/v8TJ3gPOlHvQgTclLv qygO+TeqmKCyUkmIBQqo6kkTe1wCYqrgzmKOrITbYUslPzl1oIN1HYglmwMJ4BllaFEV5HCkzk8Jj TCJGv0hEd/E5pFRXy/WYcdAb92VhykYcrJWJFHLwISVDYvKgJD+j+TAXTWvdm2hxVC1C04frjVFJ2 f/OOTBNue/0vBrImSJc4PchByRgPNQEmbshErUzEUreC0Vgkc/w2aQut8ItRzWy6R+PdKJbGSRQYF rjgt0fA4Rj1Xg7Q50y+0YF9tpws9MFJJgAmsgQggT7g8q4V8yZ6SkHzZ1vVYsXIZAngB7+8beVXTY UOc/tG4w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rDLMe-00E7rL-1b; Wed, 13 Dec 2023 09:17:12 +0000 Date: Wed, 13 Dec 2023 01:17:12 -0800 From: "hch@infradead.org" To: Johannes Thumshirn Cc: "hch@infradead.org" , Chris Mason , Josef Bacik , David Sterba , "linux-btrfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 11/13] btrfs: open code set_io_stripe for RAID56 Message-ID: References: <20231212-btrfs_map_block-cleanup-v1-0-b2d954d9a55b@wdc.com> <20231212-btrfs_map_block-cleanup-v1-11-b2d954d9a55b@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 13 Dec 2023 01:17:26 -0800 (PST) On Wed, Dec 13, 2023 at 09:09:47AM +0000, Johannes Thumshirn wrote: > > I think raid stripe tree handling also really should move out of > > set_io_stripe. Below is the latest I have, although it probably won't > > apply to your tree: > > > > That would work as well and replace patch 1 then. Let me think about it. I actually really like splitting that check into a helper for documentation purposes. Btw, this my full tree that the patch is from in case it is useful: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/raid-stripe-tree-cleanups