Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <6e40d76c-b4e7-4ed9-9d37-f0f7850f07a1@linaro.org>
Date:   Wed, 13 Dec 2023 11:28:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] clocksource: ep93xx: fix error handling during probe
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Nikita Shubin <nikita.shubin@maquefel.me>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        linux-kernel@vger.kernel.org
References: <20231212214616.193098-1-arnd@kernel.org>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <20231212214616.193098-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/12/2023 22:46, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When the interrupt property fails to be parsed, ep93xx_timer_of_init()
> return code ends up uninitialized:
> 
> drivers/clocksource/timer-ep93xx.c:160:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
>          if (irq < 0) {
>              ^~~~~~~
> drivers/clocksource/timer-ep93xx.c:188:9: note: uninitialized use occurs here
>          return ret;
>                 ^~~
> drivers/clocksource/timer-ep93xx.c:160:2: note: remove the 'if' if its condition is always false
>          if (irq < 0) {
>          ^~~~~~~~~~~~~~
> 
> Simplify this portion to use the normal construct of just checking
> whether a valid interrupt was returned. Note that irq_of_parse_and_map()
> never returns a negative value and no other callers check for that either.
> 
> Fixes: c28ca80ba3b5 ("clocksource: ep93xx: Add driver for Cirrus Logic EP93xx")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Applied, thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog