Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Wed, 13 Dec 2023 13:02:55 +0200
From:   Ido Schimmel <idosch@nvidia.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Jijie Shao <shaojijie@huawei.com>, yisen.zhuang@huawei.com,
        salil.mehta@huawei.com, davem@davemloft.net, edumazet@google.com,
        pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com,
        liuyonglong@huawei.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 5/6] net: hns3: Add support for some CMIS
 transceiver modules
Message-ID: <ZXmPXzSxq0k4eO0m@shredder>
References: <20231211020816.69434-1-shaojijie@huawei.com>
 <20231211020816.69434-6-shaojijie@huawei.com>
 <20231211192122.14da98f0@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231211192122.14da98f0@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OwbRup+Ouga2cINz1jtkX7emLEYPBqLJVfehVuChlzL79dh6HJmmo+wFGOwy?=
 =?us-ascii?Q?ru0a+zsYzFuWepDqnR+N80gc3DG3VwRou98c5IaB0tpMGigd4T8ZPVPyC+NO?=
 =?us-ascii?Q?P51nTbQBdm7A7F22r4mcF3g5ZD26uCZpyyGVxEi2b64NA70fgebGv33MBfFY?=
 =?us-ascii?Q?C1LTJSgqmmr/JOakvQSH0jSqSpUtBzfe2FtGe93hH/rCins1qGMWU81tnd6X?=
 =?us-ascii?Q?OXheLxSiVkD3pSDAosNCuXE+GpaTxuZUlSajPOX7TQI9WyAUwBgGc59yPB7D?=
 =?us-ascii?Q?/RjbnlfIPuYQ9aRbANz9eaf9jSfqYkUmLTHuVxFMNN35SQCGb1HZuASUn51g?=
 =?us-ascii?Q?qK4fDDJp9k2XLuLhtG4HWteLiptY8qN/uZyGQlxLHizp/oHKmTP/Ux1DWdEd?=
 =?us-ascii?Q?R0L6Kf8JjXqj6Pxuf5jGrdRPdcUlR7PC6ScyJe61dzrBTFUsSVzbnNZsShFC?=
 =?us-ascii?Q?ES9mKn9dk09tPbhQXfW3lWfx0BXiQROqmVJKQMf6Rrz3GYNf4v9AlEnGP6Gi?=
 =?us-ascii?Q?mp/r2UrhnoPQixezFwvnZySVrMlZ6dELPUWKBR6DbWsCE/TcKdeuvj1CPezZ?=
 =?us-ascii?Q?tBPak8G2zN14LXCt5DP98xFZ97t6FfaMafEmqq4cGWk/VHJXPRgs72FCdqLY?=
 =?us-ascii?Q?UmqiCswrI9V7VHFANNqBwuc//j55FYFcED8GkDFuYX3aGYbzg/mLz4kHQJic?=
 =?us-ascii?Q?jbHH1SPdkf0KB1UEflNG/sqWFoscLDrVKbBXKx3AHsGX691VUT1lVI1Grbie?=
 =?us-ascii?Q?tuGKPdjhGYZqI2quGhA7Y/C9lcyZxqDM21L0H3B2I3n7Mm54WhrCKBR41xkl?=
 =?us-ascii?Q?8ZbdBlXGJc7Dvp+rhKfcBXWl4GW6NZRArl0VtwO0+FXGlM8yYgZDDAfZqWvr?=
 =?us-ascii?Q?Y0WCnpuYTgd/AZUhTsKTjLlJc9ytvCLLYvHDBMjZthEtuITOB5mPFbatIbtv?=
 =?us-ascii?Q?hDCLuIvaztueRip9WehDHNSTcVUv4P/7HMkqAbHwptuUBNJptglIYesuRxVj?=
 =?us-ascii?Q?xG9MBlbLluyaLrA0t40Qh1BdIHavBtvTJ5lBmRzC1XaMwSDzM1etVIO3pMAc?=
 =?us-ascii?Q?Adayq3zUbmIhGAmHHHX116eQYdlCexOKd0o+i08pQavZoU16TYACVa/y0utZ?=
 =?us-ascii?Q?vnVmfo19uHUc/FsPp534yd1BvLaz5EN8Vmcce15JDNcjQAHtlhJG+Vx60Dgm?=
 =?us-ascii?Q?avjlYDyrTQFRzLQbM72asCx6UM34J/s3U+YxJ329c3V7YDNFDC7Zlxtjldkh?=
 =?us-ascii?Q?FFWbrPpmFhLzuO1H87mGH6Q1oAyz6PYSQQoU/oimTlqfqMLZJQka1ioOW4oq?=
 =?us-ascii?Q?QCaFwDyjK+SuicOSGfH6vRUbWT6zD4bb6eixNW0nztoBLvBhGAbAb3nVgD/w?=
 =?us-ascii?Q?LQsenMVCBQa29Xjn8/a6Ntg7h7B8fWkEUxVSvDD+LaKCAgxw+5+ABOH1v4SM?=
 =?us-ascii?Q?JURd+KvgJrT1ioy+I3WmubtrknV5BryD/zbejB6Y0E0VhxmV9dgjBVnOxq8j?=
 =?us-ascii?Q?mQBDAoz89f1GabUMai2XfTrNEwU715Ts6VDtijyCwxKdvScrcxYUecl45ag8?=
 =?us-ascii?Q?/jhSVCHPwk9mUoPwPeIxFLJYZHDsp8gJXJjpLRHV?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cff0631-f9fb-4c1a-a940-08dbfbcb11ac
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6163.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 11:02:59.8024
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jnIxImPC+e7y63XdHg8/VkMKNTL+DX6jUqQVtoNZZRtMPC0w6XdfkboYMe9D8fmQthg2RVY0rvthcOkvz6nlig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB9014
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Dec 2023 03:03:17 -0800 (PST)

On Mon, Dec 11, 2023 at 07:21:22PM -0800, Jakub Kicinski wrote:
> On Mon, 11 Dec 2023 10:08:15 +0800 Jijie Shao wrote:
> > Add two more SFF-8024 Identifier Values that according to the standard
> > support the Common Management Interface Specification (CMIS) memory map
> > so the hns3 driver will be able to dump, parse and print their EEPROM
> > contents.This two SFF-8024 Identifier Values are SFF8024_ID_QSFP_DD (0x18)
> > and SFF8024_ID_QSFP_PLUS_CMIS (0x1E).
> 
> Hm, you don't implement the ethtool get_module_eeprom_by_page op?
> I thought for QSFP DD page support was basically required.

You can read the first few pages with the legacy interface, but for the
rest you need the get_module_eeprom_by_page op. My recommendation is to
implement the new op and abandon the old ones.