Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <bb7c50da-1ee2-4ba1-9f54-8e98dff14b6d@oracle.com>
Date:   Wed, 13 Dec 2023 11:02:36 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 03/16] fs/bdev: Add atomic write support info to statx
To:     Jan Kara <jack@suse.cz>
Cc:     axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-scsi@vger.kernel.org, ming.lei@redhat.com,
        jaswin@linux.ibm.com, bvanassche@acm.org,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>
References: <20231212110844.19698-1-john.g.garry@oracle.com>
 <20231212110844.19698-4-john.g.garry@oracle.com>
 <20231213102401.epkxytqq7e5lskw2@quack3>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20231213102401.epkxytqq7e5lskw2@quack3>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEZEdmVDSXlMeGRvSVJzK2ZQN3RaQXFmeFF2UXltSEp0WTZrRWxIbld2VTBv?=
 =?utf-8?B?cHJaRzRyeGtyS3VWK2dyZDV0WTF5NWRranB4YmYvQ203TU01c0JWNjlxaS9s?=
 =?utf-8?B?aVRlQi9ReUFJT1BvTUVMbWNqTjA5L1E5aXZsNW5KQ21sbVZIVmtqbjVTYU9z?=
 =?utf-8?B?dGlnb3FYT3VENlVPc1ExbjRUSnpzQitLb2d1Syt4V1p2aXZaQ0pIeUhoQzhk?=
 =?utf-8?B?OWNqMEdTbjNjaVAwc0xnK3FVVjgxWWxUUWRyenpiMGVSb0hIVW5OMTZaT1pD?=
 =?utf-8?B?Wk5Wakl1U3JldFVzcnlaS3hEODlQdTRDaTQxS1VXUHV3WjV3K3RjV05LTm5z?=
 =?utf-8?B?SE9tZXYwZUF4M0FBaHY3M3NJV2VURFI4bEpURW9PVko5SnR4SEJ5Snlubzlx?=
 =?utf-8?B?R1h0UmVvQzlMcE1vNVhkV0hOUDBlVmJFVk1TRWNZWUZvZmIvSFNYZDdtZ2dE?=
 =?utf-8?B?TnhXZU9weUpPRkRJdGlnWk1CWnh4NDU5cEYrQ28rWExVTkZJa2dHNFdvVkdF?=
 =?utf-8?B?RU8wMEM0UXZJKzA4UnFWVyt6YXhBZ3JvOE5wR3cwTTZBNXNyK1B0eERYayt3?=
 =?utf-8?B?enBadHJxOUNKZkpUSlF4M2htSWJ5MDA5enBCeDczbENsS1c1RVJ6TVdibXRy?=
 =?utf-8?B?a0NBV2xrNzMwQ2VNUlM0emt2c091OTdWbXRxSGxsbDFxZmRTTW9TTHY3bGh0?=
 =?utf-8?B?NUN1blBjbWdtL25jczdXY0wxRFVFcXQ5QjFDaGZRdmdoUnNZNExTZ0plQkFP?=
 =?utf-8?B?ekRrcFRHVkRZZytzT2oyS0lJdWgzRm1VWHhoR0ZPM0ZYbEZPZ1Zabm5oRUVH?=
 =?utf-8?B?a0YxK0JNbGkvei8rZkpvVDRRREpGRzY5aGtnQ1E0NlNYR05yRHdDYk1uenZh?=
 =?utf-8?B?T1JmVldCQ2ltL0ZlY3E3VERZdmwxSjFtZXNiZmY5QjFUK0RNdk45NkVZaHg3?=
 =?utf-8?B?SkVLKytjbitBdElVZ1F5YWNNNGVtWkEyOG5zN2g3aFQ2NXlaWlRkRUNjQUQx?=
 =?utf-8?B?Mm9JdWwrVnNMcGFsYTQyL1hFclhBNDAwS0ZQdWdCY1JmS1cxTHVMSENrNm1B?=
 =?utf-8?B?THZkTzJ3dC8zdWx3Y0YzNXJVOXBVU3VvNWN2RXA2Q2ZzZTlYZHBrN0VmRTVB?=
 =?utf-8?B?cW5QUUZqSXYvRXYzVkpueGd2NVhsVTc4aVdFNUVzcStHS2VsZ2MwMW5KL0xR?=
 =?utf-8?B?RFRNb1pXRWpmcmJMdkwvOTJuZ2VWZ3NCWWNoSDF5UXl2RHZTUzBjSFMxT0R1?=
 =?utf-8?B?Nkd6NW1VVFNHMDMveGZwbDZuZTVSa0xLSnBuZXBqOWdPWk83ZnpxbUpScTNK?=
 =?utf-8?B?Z3lsUnQ2TS9acXNHRVdlU3Y0dzd0YjBNRkJzUXVCYmNiaXdEaFM1WWVoL1dE?=
 =?utf-8?B?VmU5U0xIQzBGS2FJc2VpUWlBenU5eWZERll4Y0JaQ1c1Mm1QcFZESmFkRnlH?=
 =?utf-8?B?ZTZ6STJacUhSZDlTaENrcjd6RFNVbVpaQmkyTFpvUFd0SFBtYlBTK0EyZi8v?=
 =?utf-8?B?akVVYTBjWGkyRFVaYmY4ZVJFQTE5d0E3SWU4KzlmckJqa3BkaUtqSkMwM3B1?=
 =?utf-8?B?MEpjK29sQVdwVmQxcWtERENOME0zQ2lKOXhRcUtVeWpSbmliRTBoUnRQZnV2?=
 =?utf-8?B?WmFrQjlkZklNdDREUTVCSzljdVRYLzJGOHIreWIxVnNveXR5NHN4bVhuNitw?=
 =?utf-8?B?ZmozTFZEbGp1STl4Zml1SXplRWdWdHhlNzlqVnV5bmdJajJtU3l6L045U2xy?=
 =?utf-8?B?UWFYRVE1NkFObHEwczJyc2s0aHFoWUtPN1ZES2JyWHozMjM0M2JJd2hLUThq?=
 =?utf-8?B?ckVFSi93V0RmRnBUQjNPSys3bzZOU3JWQWVXRzVweEJiSnYxekpOQ0lSOUp0?=
 =?utf-8?B?cGZtUlVnZXRaMklOdHo5ejFNbEN5MVduc1VpR01VdGJJemFuMmhtUE1nZ1d5?=
 =?utf-8?B?dTZ6T3VqUFVEeUJNcDZ2ODNpY3RnQ1QwNHVFc3hVRmpYZFBtamV0QWkvRmdF?=
 =?utf-8?B?Um00K3EwM1lqOUx1VW5XMUlCclU0ZDFlUjdlaHhON3VoNUtXd252aEFGSjFn?=
 =?utf-8?B?TVFhM2lqRnRydGZvZzhRdzlyK3NsSzJoa3B4dmxPK3Q1YTJoVi9WNFZHcDZp?=
 =?utf-8?B?VndrTGJKTmZCUkg0eHUrSXh6ZFZDb1ZFemwya2ttY2pDTUNMZlFycU5PL056?=
 =?utf-8?B?cUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: G50WKIcq7S+U4eoFTItgck1+T7VA+IXzEBfzsORlx43i2yRuYGXTEsBf2/ytUrDHWlykBOU+X4YSxyHut75fBl9PEPjQYdyEMkYpGf3skglLIjfQMFI5dxF8t5FQsJ7uT6dRhcYTlG/4HgeAfUefVCOUsdSmXXRuN6ao7qf/4b7Xo7EUBL3nKvYyidU3pQ2UshL7Gqlj27M7us+YnOaEQMwh7Dqi7dxG33y6Z4ONTdAcPxN+1yRY4/xjXJOblYHDQZVX2YK3yHCo3JKPv168l5lTk26Mn22atkLGpBqsD4B6XSgzQSl15r/EvGpI53iQTKiF1iY9pU6o6Hb4OzMKF41KSxU/52goYkFYB7ffTm68DF4DmT5O2ispPVf5g1Ule9Vm5M5/YBDcIbVnOjCCaXRd8e3xtJ7IissS41TnDjLu+PGJ/k3BZmKO43BzG2Tlcz6nzcqS4pqdyrNdiLTMhDeCCW2MP1LfqGH43CnUKYyhxsGUh7Fma/G2UAUjWFxdcS1teyNfMM2NMyzwgq31qFU/bUTlMc7TSAzg8G3IoW/ZTu/Ofo7Hk/7TiswxNRFKVt7csSKsTCxl3U8ewE0HuiwT5v1BkzMxTXjOb5Gi3tw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35942ec9-4eab-47a2-38f7-08dbfbcb06a8
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 11:02:41.3732
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5OEQz0COXdZE/QX+PqkkxBdFbtBsEgg1TgiidC/wwzmuSDwsQc3bqSXFB3/E/FwTvw0SO10Fh16DdPTttUEuLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4913
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-13_03,2023-12-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312130080
X-Proofpoint-ORIG-GUID: gOqRUzekoNiOu0SKRpLtide7sHxJficy
X-Proofpoint-GUID: gOqRUzekoNiOu0SKRpLtide7sHxJficy
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Dec 2023 03:03:29 -0800 (PST)

On 13/12/2023 10:24, Jan Kara wrote:
>> Signed-off-by: Prasad Singamsetty<prasad.singamsetty@oracle.com>
>> Signed-off-by: John Garry<john.g.garry@oracle.com>
> Just some nits below.
> 
>> +#define BDEV_STATX_SUPPORTED_MSK (STATX_DIOALIGN | STATX_WRITE_ATOMIC)
>                                  ^^^
> 				I believe saving one letter here is not
> really beneficial so just spell out MASK here...

ok

> 
>>   /*
>> - * Handle STATX_DIOALIGN for block devices.
>> - *
>> - * Note that the inode passed to this is the inode of a block device node file,
>> - * not the block device's internal inode.  Therefore it is*not*  valid to use
>> - * I_BDEV() here; the block device has to be looked up by i_rdev instead.
>> + * Handle STATX_{DIOALIGN, WRITE_ATOMIC} for block devices.
>>    */
> Please keep "Note ..." from the above comment (or you can move the note in
> front of blkdev_get_no_open() if you want).

ok, fine, I think that moving it to in front of blkdev_get_no_open() may 
be best.

Thanks,
John