Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5285732rdb; Wed, 13 Dec 2023 04:43:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmld5OYfzSqNDeJ9hh9Bl3GbdPMqXgtMp4XAd84/xY/Qzuhbu65uXRuOPVEXGf0t9zX9/5 X-Received: by 2002:a05:6a21:148d:b0:18f:e0f1:5546 with SMTP id od13-20020a056a21148d00b0018fe0f15546mr9156512pzb.47.1702471410130; Wed, 13 Dec 2023 04:43:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702471410; cv=none; d=google.com; s=arc-20160816; b=kMqagaA7UqdgtioI7VD2mw3PkMPAtMKHHszP+3ZvDmSueIhVVOZc3y1YfJt3Z412ze z18wSiNYxWv/DFssNpqUlrmjZpcY3ni9SZCF5PG2OIe2XbyLo5q3DsgxgkMSmIrVngBM pv2lA/YxR9XXJiqKDSq7WlaOIbQzZHZnxYL+OuEnxiq8uxZozZrz5Nl1R4CPTiJVoTrD 0SnibL8LwvjEm0lUpCZGQa3p+fGqRUVLP6HgP2kQKd/imwEjrnPOxZpSrmhnwPTDfKEv B6ecLHplxomLzZKBE3MiTonBJZVnBlVwXVHIns34hSgJmMVeqP6WO7Gbv4LcQPidMVFf 1Qcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Sx+DkdbfrbbICez2lAP79E7M3rOHNfJDuj+DFAYJXHA=; fh=fFpITan00wkAHxFKINrpH2e4BL1B8ibIImPYUNaRjsg=; b=HDduuXanjM4+ytcXPpta2IdWP8AaREHTjugrTpHQDUl3z+OMfQBsOpsB/33d9kTurK NdvrQxkIx9N8+I9Vnsv4GdwGIKkx7FarvCnw0DbbEzTpCVyAvGj6r93LdA1Ku4AxQo8f lSIaUaBiRpQMBvSkxmru6E/EhJWivjeXIToRMUu6sJ38WrauiIQZ4dfSz4X3/IWmO0g2 LCevXidiHUFS+MgPp7jeu8bUmMAb+ccueOVnFMg7XgNCO6fH+V/RXA5yzj9yv0FtuN18 wadzNnMMNPd7outgcoMPCFZXhks6lMvStl4tz1aKyDd07NNShFznBwFEm/KoTr3jSXz1 o8KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AtqJIpxE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id b18-20020a6567d2000000b005be1b2503ebsi9133320pgs.194.2023.12.13.04.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 04:43:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AtqJIpxE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id F16DA803A501; Wed, 13 Dec 2023 04:43:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378833AbjLMMnK (ORCPT + 99 others); Wed, 13 Dec 2023 07:43:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233379AbjLMMnJ (ORCPT ); Wed, 13 Dec 2023 07:43:09 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF701F5 for ; Wed, 13 Dec 2023 04:43:15 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D65C5C433CA; Wed, 13 Dec 2023 12:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702471395; bh=S5dSnA41y/QX1OV5ufybA5eBL4578WDAqBgybqwlsMY=; h=From:To:Cc:Subject:Date:From; b=AtqJIpxEVNKW8/4YwZ052AvcohHWiFlJwJj7skuxaQZeMTqux4ITVcKJZijEnWbT6 /9C+uxjHsphZIiLt6MdoI1FKPJG2VS+8OmXfi+lnmBcHrqxfHFO3FTYfDgxbQGvD7W /HAsU0ysZInnThshhwkyB9JyRVbVyZNDYUln1+N/361VCoV+PdMlgZw/dYt/Qe3NP0 dKYHlRgcW8D4x4oQ+BaJMuO6MjzjgB+V41lHrig55InkCXDbqu+r9SMMQ+ILDxfdRQ LYC/0mBhAYHpLandcdZd60VOS+ARalvZWZAcGIrO75MStxeQR5bkDTDBas+rYYSKMc wJgOyhJ5a92lg== From: Arnd Bergmann To: Tomas Winkler , Arnd Bergmann , Greg Kroah-Hartman , Wentong Wu , Sakari Ailus Cc: Alexander Usyskin , linux-kernel@vger.kernel.org Subject: [PATCH] mei: fix vsc dependency Date: Wed, 13 Dec 2023 13:43:05 +0100 Message-Id: <20231213124310.761638-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 13 Dec 2023 04:43:28 -0800 (PST) From: Arnd Bergmann The Kconfig dependency in the new module is reversed from the dependency on the exported symbols, so it fails to link with CONFIG_INTEL_MEI_VSC disabled and CONFIG_INTEL_MEI_VSC_HW enabled: ERROR: modpost: "vsc_tp_reset" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_init" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_xfer" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_need_read" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_enable" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_synchronize" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_disable" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_register_event_cb" [drivers/misc/mei/mei-vsc.ko] undefined! Make the dependency reflect the module dependency. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Signed-off-by: Arnd Bergmann --- drivers/misc/mei/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index 858bd701d68c..eb69987f8325 100644 --- a/drivers/misc/mei/Kconfig +++ b/drivers/misc/mei/Kconfig @@ -64,6 +64,7 @@ config INTEL_MEI_VSC_HW tristate "Intel visual sensing controller device transport driver" depends on ACPI && SPI depends on GPIOLIB || COMPILE_TEST + depends on INTEL_MEI_VSC help Intel SPI transport driver between host and Intel visual sensing controller (IVSC) device. @@ -73,7 +74,6 @@ config INTEL_MEI_VSC_HW config INTEL_MEI_VSC tristate "Intel visual sensing controller device with ME interface" - depends on INTEL_MEI_VSC_HW depends on INTEL_MEI help Intel MEI over SPI driver for Intel visual sensing controller -- 2.39.2