Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5323299rdb; Wed, 13 Dec 2023 05:46:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEeCDHWn1O0s+OaG5pJzno7N7ufpKiGubAtuT5UdlEpqJOWBQRCp2r86C4QwonH4zM2N2aP X-Received: by 2002:a05:6a20:325b:b0:18c:1d42:4e13 with SMTP id hm27-20020a056a20325b00b0018c1d424e13mr7942845pzc.25.1702475162639; Wed, 13 Dec 2023 05:46:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702475162; cv=none; d=google.com; s=arc-20160816; b=s7R8fe10hoJLiPEo1bONDX1JzkFcpESvfhYBb4Oy1p54TUJxtAeACth7ZucVFm9DWt lS9iRpWoXFP4Ce23qiZhkm2CqXsx7MQlKd6v4yhN6M4rncczygj4/1kiEJqVWbIFECnk ibuxfGDQc43sHxpIdVpANaOU6iIRdDYyibCEvYvHcCycK+yTPwj4XFjEJx24cJJuqZLi zvR1TzeYhile5nfy4ZY11cZX7kNJG9WfAQjPNNXM/Sa2eEQRjSeZ1MHXIvCZkmjjOiBi Z8o+vNH7CsvQJEDBLgzzLWC5eTEx2j+jthdoAswvHlcW26pVaHdklDI7k+Furfd8UjkF clzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=w4lBs1/L3lDTKmHK3QhCw5UpJd2+NwRi5ZLqALyVLVE=; fh=cvcyqEK+f9ER8PrICroeh0oMP0x2XX9SlCUD4MM1m+8=; b=U2JBWBEtcePKaaq+oZo6XC/Lw1opSScXI6d6UtWveora5Nwqnt4SPUoc55OA6bAIMi muVndu59A4yakQvBm3Y+Yi//6CN+kf1vPuXpaNbShKrSm5kvhjh6YnSY6yFPlwu7HUjx pbPZMtSLmZ6RSjHiGxe2MgyX5lnDcDfAkkw/dlqLZGAwhxj7lR+BMdN3pmqhJSNj0hYi BWK8/AxKBUlEzvudh8Z1gx4nAXsh5TgrzgUDEOym9YTFd5f7WYZ/5ZJktaG8WdRIwJbr RXdsgSXTQGxtZlGHMgLXOj/sHEk8pq3uv1WfZylz18+aPEhmtrUK2MN87jzQCV+NkX0u NI+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CoklJOec; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id o64-20020a634143000000b005c2060c72fbsi9673420pga.166.2023.12.13.05.46.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 05:46:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CoklJOec; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 1C9448078302; Wed, 13 Dec 2023 05:45:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235343AbjLMNpJ (ORCPT + 99 others); Wed, 13 Dec 2023 08:45:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233465AbjLMNpI (ORCPT ); Wed, 13 Dec 2023 08:45:08 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6A5F9C; Wed, 13 Dec 2023 05:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702475115; x=1734011115; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OuVJcynRVfgCAEWcQt4z1sKsI1HyzVA74uhdyZjaBoI=; b=CoklJOecJEDoaH5eAkiYX0Y23ECCLKqLaysG/QCf17HQYI4zfNaojVyh VcFiJn9mqmE1LMFzOe5XCwhHeli3OQwYQxwOdW5GR8fcD1PV09KWlAxpw tKOIkSVAkmtG1kPJxVITIwaMeCDZ9IcN5fAjjRpzRREwr7jafj1lnE2IH lri/lbNFspEiC9qqOIHo5Rkjn6hZ/YuaMpnMDVJBsmLtbypqem9acWr20 kRdm6YhxsXWQy0YSqBrvSLt//t1K1CrYLYEOUNHKBqa570DDYxU7pyv1t NHZ+RBON+CiH5dZ8mFqM0/zcC4HUf48ycU/3OgAlVgX8HEB9hsY9iwnPn Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="1806056" X-IronPort-AV: E=Sophos;i="6.04,272,1695711600"; d="scan'208";a="1806056" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 05:45:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="723652972" X-IronPort-AV: E=Sophos;i="6.04,272,1695711600"; d="scan'208";a="723652972" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 05:45:09 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDPXt-00000005XPs-42VY; Wed, 13 Dec 2023 15:45:05 +0200 Date: Wed, 13 Dec 2023 15:45:05 +0200 From: Andy Shevchenko To: Shenghao Ding Cc: broonie@kernel.org, conor+dt@kernel.org, krzysztof.kozlowski@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, 13916275206@139.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, soyer@irl.hu, tiwai@suse.de, peeyush@ti.com, navada@ti.com Subject: Re: [PATCH v1] ASoC: tas2562: remove tas2563 into driver Message-ID: References: <20231212050831.982-1-shenghao-ding@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212050831.982-1-shenghao-ding@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 13 Dec 2023 05:45:27 -0800 (PST) On Tue, Dec 12, 2023 at 01:08:31PM +0800, Shenghao Ding wrote: > Remove tas2563 from tas2562, it will be supported in separated driver code. No objection from the code perspective. The Q is, what is the behaviour of the current users? Imagine we have a used of this chip and this driver gets it enumerated. Does it work? if so, this patch can not be applied right now. Otherwise the commit message above is missing an elaboration of the case. -- With Best Regards, Andy Shevchenko