Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5326164rdb; Wed, 13 Dec 2023 05:51:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpz22WqoPTnGGOnnuXKucBhG9YNiNkjD0dTa6vr3YpZW44bcDdPELInrt9g2ZcX6cXHJez X-Received: by 2002:a05:6a20:6596:b0:18f:97c:8a37 with SMTP id p22-20020a056a20659600b0018f097c8a37mr8012509pzh.98.1702475487016; Wed, 13 Dec 2023 05:51:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702475487; cv=none; d=google.com; s=arc-20160816; b=cc+DkemSFsU+YCRvrx7ZwEg4eVTxsk59V0gCMz2SIAlntJrx75oWcwFU1xIoyPlFkY 52Lui85J6WcXknmyHKDofFRWFCmRx0YNy2WWEpYoC9NVhl6fNNb8EWbUAcNqvXR9Fdwv QF0eqkWPo+s9JmRGhpWtSXitGi5Y0IAUAHeJAArB0pcgMfYzEjOd+/qCAp4hvh4KOhLE DnRu1QzXaqqpTjYRjOxlGgn8Ud2KrGlDUxZxrt4PchBkfpKlvMypt4ZFY1ROxQAZ3ZPH luXWYau65HWPw43MiBN0ueA3CMvH2eUWg/9TrfVz3snYmfeLJuBHW1B38Mcw+MYHQDMu 4E8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=z3fXIPXuGexzb3JH5UnibU+knvRn4aWjn9nvZHgRZUg=; fh=9hT4l0EMR1D2zdgUoRXiqFwsybSJyrmM/FC/blQlPsI=; b=mHvJOv/dHuk94Wm81mzb+VC9rwc9cwqtBZkd4usSHRUoEgSXNeBLA+0SU3ZDbAELnN xS9Xcx0HpPfpQNxMJlHEn6pW8P5GC9l0BwzvWhaNxaP+2cTNBn/txaeX9uZT711/vt/9 UanRo//dZGGkh8Zf87h537r2HrlA/AzG+CTO0hDxCMA0tKywvapR2MjVrpHpMUHjvdsL cvrl7NimW5gt4YW2KUPd5V2U9zKgS0LFwYqpqTrDY8u00jJIV5Bins/KRJuZ75T6iWiQ cYclGRvvhmylyF+VWCGlGbdJakrNHqQPzyohxnDdF0ZHXcqV171eJ2utrxz9joj9qM6I fX5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bO2zIP4N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id e3-20020a656483000000b005859e22461csi9457085pgv.817.2023.12.13.05.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 05:51:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bO2zIP4N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 701B680C5F94; Wed, 13 Dec 2023 05:51:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379294AbjLMNu5 (ORCPT + 99 others); Wed, 13 Dec 2023 08:50:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379214AbjLMNu2 (ORCPT ); Wed, 13 Dec 2023 08:50:28 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE39318F for ; Wed, 13 Dec 2023 05:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702475430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z3fXIPXuGexzb3JH5UnibU+knvRn4aWjn9nvZHgRZUg=; b=bO2zIP4NzhJcdI+XmyhlwWevddlqgZHq2BRffFt02PV23xOjE2zsdQxpjd8yQ6p7nNB8kn cXJkZiED7BTMs4qv6/IqJV0h/MA8PCI2KIBPcbHsVO8+JuHJEJx4so+lWQLonNkohxPsUT et0DTnQ4u0ysj9bhb3PiwzZKQQtJbwg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-csY2hgwvOb-vxy8PjmHO1w-1; Wed, 13 Dec 2023 08:50:26 -0500 X-MC-Unique: csY2hgwvOb-vxy8PjmHO1w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DFC178828C6; Wed, 13 Dec 2023 13:50:25 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2160E1C060B1; Wed, 13 Dec 2023 13:50:25 +0000 (UTC) From: David Howells To: Marc Dionne Cc: David Howells , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 12/40] afs: Handle the VIO and UAEIO aborts explicitly Date: Wed, 13 Dec 2023 13:49:34 +0000 Message-ID: <20231213135003.367397-13-dhowells@redhat.com> In-Reply-To: <20231213135003.367397-1-dhowells@redhat.com> References: <20231213135003.367397-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Dec 2023 05:51:15 -0800 (PST) When processing the result of a call, handle the VIO and UAEIO abort specifically rather than leaving it to a default case. Rather than erroring out unconditionally, see if there's another server if the volume has more than one server available, otherwise return -EREMOTEIO. Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org --- Notes: Changes ======= ver #2) - Treat UAEIO as VIO too. fs/afs/rotate.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/afs/rotate.c b/fs/afs/rotate.c index 13ec8ffa911a..0829933f4d9a 100644 --- a/fs/afs/rotate.c +++ b/fs/afs/rotate.c @@ -330,6 +330,13 @@ bool afs_select_fileserver(struct afs_operation *op) goto restart_from_beginning; + case UAEIO: + case VIO: + op->error = -EREMOTEIO; + if (op->volume->type != AFSVL_RWVOL) + goto next_server; + goto failed; + case VDISKFULL: case UAENOSPC: /* The partition is full. Only applies to RWVOLs.