Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <05b4b5ab-a075-e693-7182-2477b40745dd@quicinc.com>
Date:   Wed, 13 Dec 2023 19:27:28 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] [RFC] mm: migrate: rcu stalls because of invalid swap
 cache entries
Content-Language: en-US
From:   Charan Teja Kalla <quic_charante@quicinc.com>
To:     Matthew Wilcox <willy@infradead.org>
CC:     <akpm@linux-foundation.org>, <david@redhat.com>,
        <hannes@cmpxchg.org>, <kirill.shutemov@linux.intel.com>,
        <shakeelb@google.com>, <n-horiguchi@ah.jp.nec.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <1700569840-17327-1-git-send-email-quic_charante@quicinc.com>
 <ZVzXLu4Ds+3aQtGm@casper.infradead.org>
 <51f727a2-75e9-d42f-bae6-d3e4c3328af1@quicinc.com>
In-Reply-To: <51f727a2-75e9-d42f-bae6-d3e4c3328af1@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

HI Matthew, Just a ping to have your valuable opinion here.

Thanks,
Charan

On 11/23/2023 7:55 PM, Charan Teja Kalla wrote:
>> What would you think to this?  I think a better fix would be to
>> fix the swap cache to user multi-order entries, but I would like to
>> see this backportable!
>>
>> diff --git a/mm/migrate.c b/mm/migrate.c
>> index d9d2b9432e81..2d67ca47d2e2 100644
>> --- a/mm/migrate.c
>> +++ b/mm/migrate.c
>> @@ -405,6 +405,7 @@ int folio_migrate_mapping(struct address_space *mapping,
>>  	int dirty;
>>  	int expected_count = folio_expected_refs(mapping, folio) + extra_count;
>>  	long nr = folio_nr_pages(folio);
>> +	long entries, i;
>>  
>>  	if (!mapping) {
>>  		/* Anonymous page without mapping */
>> @@ -442,8 +443,10 @@ int folio_migrate_mapping(struct address_space *mapping,
>>  			folio_set_swapcache(newfolio);
>>  			newfolio->private = folio_get_private(folio);
>>  		}
>> +		entries = nr;
>>  	} else {
>>  		VM_BUG_ON_FOLIO(folio_test_swapcache(folio), folio);
>> +		entries = 1;
>>  	}
>>  
>>  	/* Move dirty while page refs frozen and newpage not yet exposed */
>> @@ -453,7 +456,11 @@ int folio_migrate_mapping(struct address_space *mapping,
>>  		folio_set_dirty(newfolio);
>>  	}
>>  
>> -	xas_store(&xas, newfolio);
>> +	/* Swap cache still stores N entries instead of a high-order entry */
>> +	for (i = 0; i < entries; i++) {
>> +		xas_store(&xas, newfolio);
>> +		xas_next(&xas);
>> +	}
>>  
>>  	/*
>>  	 * Drop cache reference from old page by unfreezing
> Seems a cleaner one to store N entries. Supporting swap cache for multi
> order entries might be time consuming. Till then, can we use this patch
> as the solution, with the proper commit log conveying revert of this
> patch when swap cache supported with Multi-order indices?
> 
> Please Lmk, If I can raise this patch with suggested-by:you