Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20231207070700.4156557-1-claudiu.beznea.uj@bp.renesas.com> <20231207070700.4156557-11-claudiu.beznea.uj@bp.renesas.com>
In-Reply-To: <20231207070700.4156557-11-claudiu.beznea.uj@bp.renesas.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 13 Dec 2023 15:06:37 +0100
Message-ID: <CAMuHMdXD4WO-LR02wOgd3SsQ8Rfb+SUErUTcO7wPhAdyb-NF_A@mail.gmail.com>
Subject: Re: [PATCH v2 10/11] arm64: renesas: rzg3s-smarc-som: Use switches'
 names to select on-board functionalities
To:     Claudiu <claudiu.beznea@tuxon.dev>
Cc:     s.shtylyov@omp.ru, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        magnus.damm@gmail.com, mturquette@baylibre.com, sboyd@kernel.org,
        linus.walleij@linaro.org, prabhakar.mahadev-lad.rj@bp.renesas.com,
        biju.das.jz@bp.renesas.com, linux-renesas-soc@vger.kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-gpio@vger.kernel.org,
        Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Dec 7, 2023 at 8:08 AM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> The intention of the SW_SD0_DEV_SEL and SW_SD2_EN macros was to reflect the
> state of SW_CONFIG individual switches available on the RZ/G3S Smarc Module
> and at the same time to have a descriptive name for the switch itself.
> Each individual switch is associated with a signal name, which might be
> active-low or not on the board. Using signal names instead of SW_CONFIG
> switch names may be confusing for a user who just playes with switches to
> select individual functionalities, but also for the advanced user that
> looks over schematics. To avoid even further confusions, use the switches'
> names here and instantitate them with an ON/OFF state. This should be
> simpler, even though the name of the switch is not that intuitive. The
> switch names documentation reflects the switch's purpose.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>
> Changes in v2:
> - this patch is new and aims to replace patch "arm64: renesas: rzg3s-smarc-som:
>   Invert the logic of the SW_SD2_EN macro" from v1

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.8.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds