Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     "Zhang, Rui" <rui.zhang@intel.com>,
        "jsperbeck@google.com" <jsperbeck@google.com>,
        "tip-bot2@linutronix.de" <tip-bot2@linutronix.de>
Cc:     "andres@anarazel.de" <andres@anarazel.de>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-tip-commits@vger.kernel.org" 
        <linux-tip-commits@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [tip: x86/urgent] x86/acpi: Ignore invalid x2APIC entries
In-Reply-To: <c1d7e60329a62a9f6d70ffa664632db8db668efe.camel@intel.com>
References: <87ttonpbnr.ffs@tglx>
 <c1d7e60329a62a9f6d70ffa664632db8db668efe.camel@intel.com>
Date:   Wed, 13 Dec 2023 15:51:00 +0100
Message-ID: <878r5yp357.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, Dec 13 2023 at 07:39, Zhang, Rui wrote:
> Yeah, I agree.
>
> I have posted a patch to do more strict check
> https://lore.kernel.org/all/20231210143925.38722-1-rui.zhang@intel.com/
> in case there are some weird cases that LAPIC fails to probe any
> enabled CPU and we also lose the X2APIC cpus.

The return value of acpi_register_lapic() is not really useful.

It returns an error if

  1) the number of registered CPUs reached the limit.
  2) the APIC entry is not enabled

#1: any further X2APIC CPU will be ignored

#2: the return value is bogus as the CPU is accounted for as disabled
    and will eventually lead to #1

    In fact even 'disabled' entries are valid as they can be brought
    in later (that's what "physical" hotplug uses)

The topology evaluation rework gets rid of this return value completely,
so I really don't want to add an dependency on it.

Thanks,

        tglx