Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5373867rdb; Wed, 13 Dec 2023 07:03:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IELQx5BmE2HQzAejMsTmgJLXSPXixSneXVipT9HH1ON3XodIbBLOhQWaZO+L7B96OodTlF1 X-Received: by 2002:a05:6a20:560c:b0:190:2d3d:b08a with SMTP id ir12-20020a056a20560c00b001902d3db08amr8069235pzc.18.1702479802533; Wed, 13 Dec 2023 07:03:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702479802; cv=none; d=google.com; s=arc-20160816; b=f/Q0A2BDBWnTQKpWL6iWO+yxfduM/pbClSZ2qzoEB8pF4Qdi/O/2c3QrTXxXMdEDoC YQn4PHVPSyjTuRZD9uMhXB2r6XzndHNl5QsaFqurYD62uQkWhdhdEUJpn4z0wu0/YUQ6 TUpVIDS5zmeW/Z+q33N1az4i23Mb1bx9irENp2JLNC0hRSefP8IGO8c7f6iFbNmhUeZ2 WN5PAOCp8peGfqNQ5F23doU/whojSNDIzIhPgAOrJ5aLmRNfqsrPbwOeO7A9zKzaWvsv 89X0mumLYWd4bUKmWDRYIGhrzrePdHGXS1T2ZMBrhqB8HghB7NedVRupm9HxPBVhmGie rVQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:references :in-reply-to:subject:to:from:date:message-id:dkim-signature; bh=q5zTltisjw5F/QdAJ+2zhyvbqKygWef7TTCvrlod/Ko=; fh=/H1f4m18YULCOCiiSxjuhXIMZrkq2p9KI31aycs/0lA=; b=gATHVroblgcsUgL8ztZKPNrS8PdOBDcB3zq8r1ToBUX4/av0PXmMCieQWL4h+PWEvW FoEeUPbbYe2RbFP91hlVqYWlwwjehT+JH3ZEtU5tnfb4/3TxiqhFrtBmpDTQT1o5MjJN nSWmeQKidVDtBp+tafzZvJNtmEShPfDoxgeVMVTBHMJDcEkXZRIW9PzU0Gc3h/Jh8b26 Jp0j0BGYMIg6gG6uPCl2SByjWz/UQNyYfHlS5AawlTk6xubZaLbMFq+ukr1061A4TbLZ 9ZpVKswsjV483PWGwm1ZEwPte8tk8MSC/ME8br4WndsH4k8scbilGMj98gFi+sKsvI1f RX3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OSo1JyPI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id v22-20020a056a00149600b006ce3c0dd603si8840382pfu.340.2023.12.13.07.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 07:03:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OSo1JyPI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D6E14824775D; Wed, 13 Dec 2023 07:03:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442083AbjLMPDB (ORCPT + 99 others); Wed, 13 Dec 2023 10:03:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442067AbjLMPC7 (ORCPT ); Wed, 13 Dec 2023 10:02:59 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE51BA0 for ; Wed, 13 Dec 2023 07:03:05 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F3F8C433C8; Wed, 13 Dec 2023 15:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702479785; bh=ERYPWlZcuAsc3JTXR2wiRcqYpvAqlyOmPFSh5X5mKMU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=OSo1JyPIEEiOqSQkxHZc0rW9gEY26xIxY2pFyOxbAqRhG/rDBaAxtpEvgzIC3a3pt BOTZ1qII5VJxtazr9MqP8EACT+Y10dkh0nTg/2zbkGhXa39zOHCp0lS2agt9gVpSUA CltxBEF/1zLz9K6yQKhdzCOxewWh1wdpeSegUeTuIg7GJzS/3k3qz+1WtZ7QogvGzF xVziHZ9wNt/ymRn/TJmviMnMb+ThIlYT9UCT3XrJ4PtKzjYsjv5K19rJ/CRjLpihym bUxdTZmbWd91qtxA4hOgs52zd4GHLQMWjdLK6nitFMxSRK908BKfPZqXp/RqsI97M0 /RT3giJthg+FQ== Message-ID: <09db7e8dadfa5d73bdcbf2f6c6af9fbd@kernel.org> Date: Wed, 13 Dec 2023 15:03:02 +0000 From: "Maxime Ripard" To: davidgow@google.com Subject: Re: [PATCH v2 1/4] kunit: Add APIs for managing devices In-Reply-To: <20231208-kunit_bus-v2-1-e95905d9b325@google.com> References: <20231208-kunit_bus-v2-1-e95905d9b325@google.com> Cc: kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-sound@vger.kernel.org, "Brendan Higgins" , "David Gow" , "Greg Kroah-Hartman" , "Jaroslav Kysela" , "Jonathan Corbet" , "Kees Cook" , "Liam Girdwood" , "Mark Brown" , "Matti Vaittinen" , "Maxime Ripard" , "Rae Moar" , "Shuah Khan" , "Stephen Boyd" , "Takashi Iwai" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Dec 2023 07:03:20 -0800 (PST) On Fri, 8 Dec 2023 18:09:29 +0800, davidgow@google.com wrote: > Tests for drivers often require a struct device to pass to other > functions. While it's possible to create these with > root_device_register(), or to use something like a platform device, this > is both a misuse of those APIs, and can be difficult to clean up after, > for example, a failed assertion. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime